Flag --disable-component-update should not block existing components from being used |
||||
Issue descriptionToday when --disable-component-update flag is used, we don't register components at all: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chrome_browser_main.cc&l=1758 This means that: 1. We will not scan the COMPONENT_DIR for bundled components. 2. We will not scan the USER_DATA_DIR for existing downloaded components. 3. We will not try to update components. It seems a bit surprising to me that it does (1) and (2), which don't actually require any "update". This is causing some other issues like issue 613442 . We should probably clarify/update what this flag does, and/or add a new flag if we really want to disable (1) and (2)
,
May 20 2016
In general, we don't want to run code that is not being updated. That is the reason for (1) and (2). I agree that the naming of the flag is misleading, since it disables the component altogether. Let's discuss how to fix and what other features are needed.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3be44be552846983cf371256718ce8ec81c565b4 commit 3be44be552846983cf371256718ce8ec81c565b4 Author: xhwang <xhwang@chromium.org> Date: Wed May 25 17:24:49 2016 media: Use bundled Widevine CDM in encrypted media browser tests - Provide option to enable component update in browser tests - Enable component update in encrypted media related browser tests to pick up the bundled Widevine CDM. - Remove code that manually registers Widevine CDM. - Enable more tests that wasn't possible when CDM is manually registered. BUG= 613442 ,582622,613581 Review-Url: https://codereview.chromium.org/1996863002 Cr-Commit-Position: refs/heads/master@{#395922} [modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/browser/content_settings/content_settings_browsertest.cc [modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/browser/media/encrypted_media_browsertest.cc [modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/browser/media/encrypted_media_supported_types_browsertest.cc [modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/test/base/in_process_browser_test.cc [modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/test/base/in_process_browser_test.h [modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/test/base/test_launcher_utils.cc [modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/test/base/test_launcher_utils.h
,
Aug 23 2016
,
Dec 6 2016
There are testing scenarios where the presence of this flag complicates the testing, therefore we want to think of a solution to this problem soon.
,
Aug 16 2017
This complicates my lab testing as well. Is anyone looking into this?
,
Aug 16 2017
Thank you for bringing this up. I will look into this. |
||||
►
Sign in to add a comment |
||||
Comment 1 by xhw...@chromium.org
, May 20 2016