Issue metadata
Sign in to add a comment
|
REGRESSION: Extension Notification Icon Text Too Small in MD
Reported by
m.cube...@gmail.com,
May 20 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version : 52.0.2739.0 OS Version: 6.3 Other browsers tested: N/A What steps will reproduce the problem? 1. Install extension with a notification icon 2. Wait until notification icon has a number in it 3. Attempt to read the number in the notification icon What is the expected result? Ability to read the icon because the text is large enough. What happens instead of that? The text is too small to read. I imagine if you're a foot away from the screen or have superhuman sight that you can read it, but any further away from that and all you see is a red block with some barely-legible numbers. Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2739.0 Safari/537.36
,
May 20 2016
This is because the size of icons was reduced from 19x19 down to 16x16 (which is a pretty significant reduction). I think sgabriel was aware of this risk, but bringing it back to his attention. Also +estade FYI. To some extent, we can say that it's up to extension developers to make this work, but, on the other hand, this is a pretty common feature for browser actions, and it should be generally readable.
,
May 26 2016
I believe that affects all OS'es?
,
May 26 2016
,
May 26 2016
opensuse x64 here
,
May 26 2016
Win 8.1 Pro here. I imagine it hits all platforms.
,
May 26 2016
Yes, since this results from the MDification of chrome, this will hit all platforms. sgabriel@, any thoughts here?
,
May 26 2016
Evan, I do not remember what size we ended up using. My spec says 9pt are we reducing the font size when reaching 3 digits? What was the original font size?
,
May 26 2016
we use gfx::FontList::DeriveWithHeightUpperBound with the height of the badge. So it's basically the biggest size that is small enough to fit inside the badge. For one reason or another, we bottom-justify the text which is why there's slightly more space above than below in the above badge. I suspect the height of the font in this case is taking into account certain characters with ascenders that would stretch above a 6 or a 2.
,
May 26 2016
i think simply that icons now are a bit smaller (it is noticeable). 1-2 pixels.
,
May 26 2016
This seems to work a bit better on my local machine than on the screenshots posted above. I wonder if the base font for this machine is the source of the problem (perhaps it's a font that handles more non-latin characters?).
,
May 26 2016
nevertheless, I have a potential improvement posted up here: https://bugs.chromium.org/p/chromium/issues/detail?id=613576
,
May 26 2016
@estade, it looks like you just linked this bug?
,
May 26 2016
,
May 26 2016
Re #10. Icons are smaller but I don't think it has any impact on the badge which is a different UI surface.
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ad66522f53d6d74da96d2c31f5af7c72bfb3673 commit 8ad66522f53d6d74da96d2c31f5af7c72bfb3673 Author: estade <estade@chromium.org> Date: Fri May 27 01:41:00 2016 Use a larger font in the extension badge when possible. BUG= 613576 Review-Url: https://codereview.chromium.org/2012313002 Cr-Commit-Position: refs/heads/master@{#396347} [modify] https://crrev.com/8ad66522f53d6d74da96d2c31f5af7c72bfb3673/chrome/browser/ui/extensions/icon_with_badge_image_source.cc
,
May 31 2016
Can those who were experiencing this problem try canary and see if it's gotten any better?
,
Jun 1 2016
Well, now it's at least more visible. It's still smaller than non-MD version, but certainly better.
,
Jun 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 3 2016
Could Issue 617089 be related to your fix?!
,
Jun 3 2016
,
Jun 7 2016
Issue 612748 has been merged into this issue.
,
Jun 7 2016
There is still a lingering problem that may be related to this: notice that the whitespace above the badge text is very inconsistent. There's significantly more of it above/to the right than below/to the left. Attaching a magnified screenshot.
,
Jun 9 2016
I have related but kinda opposite issue: icon text is too large (or trimming is too aggressive), hence even 5 digits won't fit in anymore, effectively rendering some extensions useless (see the screenshot, exchange rate is not readable any longe). It was fine before most recent Chrome crash/update. OSX 10.11.6 Beta (15G7b) Version 52.0.2743.33 beta (64-bit)
,
Jun 9 2016
Can confirm #24; before, badge could hold 5 characters.
,
Jun 9 2016
estade@, can you look into #24/25?
,
Jun 9 2016
Here's something relevant to #24: https://bugs.chromium.org/p/chromium/issues/detail?id=154270 From my tests with non-MD interface, the limit is actually closer to 4 characters. "1111" displays fully while anything over that is clipped without "...". For example, "mmmm" is clipped to "mmn" (where n is half of m) Documentation expressly says "Because the badge has limited space, it should have 4 characters or less."
,
Jun 13 2016
I think before V52 an extension badge could fit 4 charactes + a punctuation sign, i.e. 23.23 or 00:00 was fine, but with the new font punctuation makes text too wide. I think, a lot of extensions are negatively affected by this.
,
Jun 13 2016
,
Sep 19 2016
How to use this diff patch ? Please help https://codereview.chromium.org/2012313002
,
Oct 12 2016
See also bug 649054. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pucchakayala@chromium.org
, May 20 2016Labels: -Pri-3 M-52 Pri-2
Status: Untriaged (was: Unconfirmed)
2.9 KB
2.9 KB View Download