New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613573 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

GN: allow action without a python script

Project Member Reported by sdefresne@chromium.org, May 20 2016

Issue description

IIUC, we force "action" target to use python script for portability reason. However some of the action just invoke a tool that is part of the build (see for example https://codereview.chromium.org/2001613002/) which requires creating a custom made python script doing "os.execv(os.argv[1], os.argv[1:])". This feel wrong.

Can we have "native_action" target or if we are concerned about portability, can we have at least a "build/exec.py" generic script doing that command?
 
brettw/dpranke: WDYT?
I don't see a good way to allow either of those options without also allowing them to be used for exactly the sort of thing we're trying to prevent: calling out to random executables that are platform-specific.

It could be that we just need to give up on this idea, but we've made it this far without doing so ...
There's at least a shared .py for doing it here:
https://code.google.com/p/chromium/codesearch#chromium/src/build/compiled_action.gni
Status: WontFix (was: Available)
Ah, never found that one. I think it is good enough for me, thank you.

Sign in to add a comment