Simple Cache: switch to non-static member initialisation universally |
||||||||
Issue descriptionDuring the review of https://codereview.chromium.org/1977863003/ , rdsmith pointed out that it's at times confusing to mix non-static member initialisation and ctor initialisation becausae you have to look in two places to ensure good coverage for all initialisations. That change was out of scope for https://codereview.chromium.org/1977863003/ , and that CL had to use non-static member initialisation because it was initialising an array of bools. Nevertheless, let's follow this up and make this code cleaner.
,
May 22 2016
I'm interested in refactoring this and would be happy to work on it.
,
May 22 2016
Great! What can I do to help you get started? My guess is that one CL each for the large classes makes sense, then a final CL for the smaller classes in the simple cache.
,
May 22 2016
I notice you're not a project member yet, so I can't assign this bug to you. Micah, I'm assigning the bug to myself so that you can begin coding and be sure you won't be pre-empted by anyone else. Please let me know if you stop work on this, or if you aren't going to work on this, so I can return it to the free pool. I look forward to reviewing your code! Thanks again.
,
May 22 2016
,
May 22 2016
,
May 22 2016
Thanks Gavin! I've sent you some questions via email. I'll be sure to keep you up to date on the status of this patch.
,
Nov 20 2017
,
Feb 16 2018
,
Oct 4
,
Oct 8
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by gavinp@chromium.org
, May 20 2016