New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613549 link

Starred by 0 users
Status: Assigned
Owner:
grunell@chromium.org
Cc:
█ phoglund@chromium.org
solenberg@chromium.org
jansson@chromium.org
█ emadomara@chromium.org
webrtc-network-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

WebRTC's log overrides are hooked up to Chromium backwards

Project Member Reported by katrielc@chromium.org, May 20 2016 
rtc::LogToDebug sets the WebRTC logging level. When WebRTC is built in Chromium, this function is overridden by webrtc_overrides to call through to logging::SetMinLogLevel.

Unfortunately, WebRTC logging levels are the reverse of Chromium ones (see diagnostic_logging.h, line 52), so this does not do the right thing: it should first call WebRtcSevToChromeSev.

Beware: this code is used by JNI and not tested by the WebRTC tests. In particular, if you change the signature of the override from int to what it should be, LoggingSeverity, then tests will pass but Java will have a tantrum.

Comment 1 by kjellander@chromium.org, Oct 3 2016

Owner: grunell@chromium.org
Status: Assigned (was: Untriaged)
grunell: since you're familiar with the logging and overrides, can you have a look?

Comment 2 by grunell@chromium.org, Oct 18 2016

Cc: solenberg@chromium.org jansson@chromium.org
Background is  issue 561667 , that is when this was discovered.

A fix was landed in https://codereview.chromium.org/1982643002/ (together with another change) but reverted in https://codereview.chromium.org/1992243002/ ("The signature change for LogToDebug broke JNI on Android.").

rtc::LogToDebug is only used in tests and in a Java example: https://cs.chromium.org/search/?q=LogMessage::LogToDebug&sq=package:chromium&type=cs hence the low prio.
►

Sign in to add a comment