DevTools: captured screenshots show a dashed border |
|||||||||||||
Issue descriptionVersion: 52.0.2743.0 canary (64-bit) OS: Mac What steps will reproduce the problem? Capture a screenshot (device mode menu). What is the expected output? What do you see instead? Captured screenshot show a dashed border around the status- and navigation bar, see screenshot.
,
May 23 2016
These were added to account for partial screenshots, when not the whole page fits your screen (you can achieve this by resizing docked devtools leaving too little space for the page). What do you think we should do?
,
May 24 2016
Sorry, I don't quite understand. Is it supposed to explain something to the user or is it a technical requirement for the screenshot feature? If the second is the case, maybe we could use a transparent border?
,
May 24 2016
This is to explain user where the screen goes. I think it shouldn't be visible under the real screen image though. I will take a look.
,
May 25 2016
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a8e343e823740a06acf460131d08dd6f655119b commit 5a8e343e823740a06acf460131d08dd6f655119b Author: dgozman <dgozman@chromium.org> Date: Thu May 26 00:35:59 2016 [DevTools] Draw screen border below screen image when taking screenshot. BUG= 613515 Review-Url: https://codereview.chromium.org/2010773002 Cr-Commit-Position: refs/heads/master@{#396056} [modify] https://crrev.com/5a8e343e823740a06acf460131d08dd6f655119b/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js
,
May 30 2016
Verified the issue on Mac 10.11.5,Win 7 and Ubuntu 14.04 using 53.0.2751.0 and its working fine. Please merge the same to M 52 branch as the issue persists on 52.0.2743.17.
,
May 30 2016
,
May 31 2016
,
May 31 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa072a1b32f2a4a6e4a1c89477feb7e1377ba7c7 commit fa072a1b32f2a4a6e4a1c89477feb7e1377ba7c7 Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue May 31 19:47:14 2016 Merge to 2743 "[DevTools] Draw screen border below screen image when taking screenshot." > [DevTools] Draw screen border below screen image when taking screenshot. > > BUG= 613515 > > Review-Url: https://codereview.chromium.org/2010773002 > Cr-Commit-Position: refs/heads/master@{#396056} (cherry picked from commit 5a8e343e823740a06acf460131d08dd6f655119b) TBR=lushnikov@chromium.org Review URL: https://codereview.chromium.org/2026723003 . Cr-Commit-Position: refs/branch-heads/2743@{#141} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/fa072a1b32f2a4a6e4a1c89477feb7e1377ba7c7/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js
,
May 31 2016
|
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by eostroukhov@chromium.org
, May 23 2016Owner: dgozman@chromium.org
Status: Assigned (was: Untriaged)