Issue metadata
Sign in to add a comment
|
Unchecking checkbox on webrtc-internals hits assertion |
||||||||||||||||||
Issue descriptionVersion: 003cd61ab7a3e38d8f7fdfe55068c5450ed1bb68 OS: Linux What steps will reproduce the problem? (1) Check the "Enable diagnostic packet and event recording" checkbox on chrome://webrtc-internals (2) Check the "Enable diagnostic packet and event recording" checkbox on chrome://webrtc-internals What is the expected output? Recording stops. What do you see instead? Chrome core dumps. Stack trace below: [140880:140880:0520/101303:FATAL:ref_counted.h(322)] Assert failed: ptr_ != __null. #0 0x7fbd4e3969be base::debug::StackTrace::StackTrace() #1 0x7fbd4e3d603f logging::LogMessage::~LogMessage() #2 0x7fbd42f2fcbb scoped_refptr<>::operator->() #3 0x7fbd478d2207 content::WebRTCInternals::SetEventLogRecordings() #4 0x7fbd478db295 content::WebRTCInternalsMessageHandler::OnSetEventLogRecordingsEnabled() #5 0x7fbd43d18aa7 _ZN4base8internal15RunnableAdapterIMN11cloud_print29PrivetLocalPrintOperationImplEFvbPKNS_15DictionaryValueEEE3RunIPS3_JbS6_EEEvOT_DpOT0_ #6 0x7fbd43d189f3 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN11cloud_print29PrivetLocalPrintOperationImplEFvbPKNS_15DictionaryValueEEEEE8MakeItSoIJPS4_bS7_EEEvSA_DpOT_ #7 0x7fbd478dbd3d _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN7content29WebRTCInternalsMessageHandlerEFvbPKNS_9ListValueEEEEFvPS7_bSA_EJNS0_17UnretainedWrapperIS7_EEbEEENS0_12InvokeHelperILb0EvSD_EEFvSA_EE3RunEPNS0_13BindStateBaseEOSA_ #8 0x7fbd43033f16 base::Callback<>::Run() #9 0x7fbd478ae118 content::WebUIImpl::ProcessWebUIMessage() #10 0x7fbd478acbdb content::WebUIImpl::OnWebUISend() #11 0x7fbd4787dffb _ZN4base20DispatchToMethodImplIPN7content15WebContentsImplEMS2_FvRK4GURLRKSsRKNS_9ListValueEEJS4_SsS9_EJLm0ELm1ELm2EEEEvRKT_T0_RKSt5tupleIJDpT1_EENS_13IndexSequenceIJXspT2_EEEE #12 0x7fbd4787df25 _ZN4base16DispatchToMethodIPN7content15WebContentsImplEMS2_FvRK4GURLRKSsRKNS_9ListValueEEJS4_SsS9_EEEvRKT_T0_RKSt5tupleIJDpT1_EE #13 0x7fbd478b04cf _ZN3IPC16DispatchToMethodIN7content9WebUIImplEMS2_FvRK4GURLRKSsRKN4base9ListValueEEvSt5tupleIJS3_SsS9_EEEEvPT_T0_PT1_RKT2_ #14 0x7fbd478aeb8b _ZN3IPC8MessageTI26ViewHostMsg_WebUISend_MetaSt5tupleIJ4GURLSsN4base9ListValueEEEvE8DispatchIN7content9WebUIImplESA_vMSA_FvRKS3_RKSsRKS5_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #15 0x7fbd478ac9f2 content::WebUIImpl::OnMessageReceived() #16 0x7fbd47852461 content::WebContentsImpl::OnMessageReceived() #17 0x7fbd47852304 content::WebContentsImpl::OnMessageReceived() #18 0x7fbd475a988a content::RenderViewHostImpl::OnMessageReceived() #19 0x7fbd475bc173 content::RenderWidgetHostImpl::OnMessageReceived() #20 0x7fbd4758b833 content::RenderProcessHostImpl::OnMessageReceived() #21 0x7fbd464c0718 IPC::ChannelProxy::Context::OnDispatchMessage() #22 0x7fbd42f45726 _ZN4base8internal15RunnableAdapterIMN7banners20AppBannerDataFetcherEFvRK8SkBitmapEE3RunIRK13scoped_refptrIS3_EJS6_EEEvOT_DpOT0_ #23 0x7fbd464c477e _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEEEE8MakeItSoIJRK13scoped_refptrIS5_ES8_EEEvSB_DpOT_ #24 0x7fbd464c472d _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN3IPC12ChannelProxy7ContextEFvRKNS6_7MessageEEEEFvPS8_SB_EJSF_SB_EEENS0_12InvokeHelperILb0EvSE_EEFvvEE3RunEPNS0_13BindStateBaseE #25 0x7fbd42f30b6e base::Callback<>::Run() #26 0x7fbd4e3999ce base::debug::TaskAnnotator::RunTask() #27 0x7fbd4e3ec16c base::MessageLoop::RunTask() #28 0x7fbd4e3ec408 base::MessageLoop::DeferOrRunPendingTask() #29 0x7fbd4e3ec662 base::MessageLoop::DoWork() #30 0x7fbd4e3fe276 base::MessagePumpGlib::Run() #31 0x7fbd4e3ebb5f base::MessageLoop::RunHandler() #32 0x7fbd4e46b794 base::RunLoop::Run() #33 0x7fbd4301febf ChromeBrowserMainParts::MainMessageLoopRun() #34 0x7fbd46e48969 content::BrowserMainLoop::RunMainMessageLoopParts() #35 0x7fbd46e51f85 content::BrowserMainRunnerImpl::Run() #36 0x7fbd46e426f6 content::BrowserMain() #37 0x7fbd4e3384c6 content::RunNamedProcessTypeMain() #38 0x7fbd4e33a1b2 content::ContentMainRunnerImpl::Run() #39 0x7fbd4e337682 content::ContentMain() #40 0x7fbd42f15a32 ChromeMain #41 0x7fbd42f159e2 main #42 0x7fbd3a151ec5 __libc_start_main #43 0x7fbd42f158e1 <unknown>
,
May 20 2016
Thanks for reporting, this seems to be caused by an incorrectly placed DCHECK in the code, so this should only affect debug builds. I will include a fix for this in my upcoming CL, where I'm touching this part of the code anyway: https://codereview.chromium.org/1855193002/
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf0887d3df989061ca653339e7affa8e49a3cfe6 commit cf0887d3df989061ca653339e7affa8e49a3cfe6 Author: ivoc <ivoc@chromium.org> Date: Thu Jul 07 18:23:53 2016 Enable the WebRTC event log on PeerConnection instead of PeerConnectionFactory. This allows simultaneous recording of event logs of multiple PeerConnections, each in a seperate file. The number of files is limited, as well as the size of each file. A callback handler is added to RenderProcessHost to allow code in chrome/ to register callbacks to implement the WebRTC event log functionality. BUG= chromium:600661 , chromium:613499 , webrtc:4741 Review-Url: https://codereview.chromium.org/1855193002 Cr-Commit-Position: refs/heads/master@{#404183} [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/chrome/browser/media/webrtc_event_log_handler.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/chrome/browser/media/webrtc_event_log_handler.h [add] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_eventlog_host.cc [add] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_eventlog_host.h [add] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_eventlog_host_unittest.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_internals.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_internals.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/media/webrtc/webrtc_internals_message_handler.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/renderer_host/media/peer_connection_tracker_host.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/renderer_host/media/peer_connection_tracker_host.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/resources/media/dump_creator.js [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/browser/resources/media/webrtc_internals.css [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/common/media/aec_dump_messages.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/common/media/peer_connection_tracker_messages.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/content_browser.gypi [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/content_tests.gypi [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/public/browser/render_process_host.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/public/test/mock_render_process_host.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/public/test/mock_render_process_host.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/aec_dump_message_filter.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/aec_dump_message_filter.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/media_stream_audio_processor_unittest.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/mock_peer_connection_impl.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/peer_connection_tracker.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/peer_connection_tracker.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/rtc_peer_connection_handler.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/rtc_peer_connection_handler.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/webrtc/peer_connection_dependency_factory.cc [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/media/webrtc/peer_connection_dependency_factory.h [modify] https://crrev.com/cf0887d3df989061ca653339e7affa8e49a3cfe6/content/renderer/render_thread_impl.cc
,
Jul 11 2016
This is now fixed, closing the issue. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by terelius@chromium.org
, May 20 2016