New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613475 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: May 2016
Cc:
nyerramilli@chromium.org
█ ashej...@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird grey traces is observed on mouse hover.

Reported by lpa...@etouch.net, May 20 2016 
Chrome Version: 52.0.2743.0 (Official Build) 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} 32/64 Bit.
OS: Windows (7,8,8.1,10),Linux (14.04 LTS)

Steps:
1. Launch chrome and navigate to http://www.fabindia.com/personal-care/skin-care.html#/page/1
2. Hover the mouse pointer over the menu options and then hover anywhere on the page, observe.

Actual: Weird grey traces is observed.

Expected: No such grey traces should be seen.

This is a regression issue broken in M-52, will soon update the other info.
Actual.png
360 KB View Download

Comment 1 by lpa...@etouch.net, May 20 2016

Labels: hasbisect
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Manual Regression Range:
Good Build: 52.0.2730.0
Bad Build: 52.0.2731.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/a69b588abf1afd1e37e58463a07df4da722ded02..6958c09a512167e272ba30c3d1caeea283a803da?pretty=fuller&n=100

Suspecting: r392652

Note: Issue is not seen in Mac OS.
Actual_screencast.mp4
447 KB Download
Expected_Screencast.mp4
385 KB Download

Comment 2 by ashej...@chromium.org, May 20 2016

Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable as this is a recent regression.

Thank you!
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d35533844c94bece904fa16ca47acf43e659cb14

commit d35533844c94bece904fa16ca47acf43e659cb14
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Tue May 24 00:50:06 2016

Check subtree paint invalidation when overflow clip status changes

Before https://crrev.com/392652 because we included descendant overflow
into container overflow and the paint invalidation rect covered the
changed part of descendants.

Call setNeedsPaintInvalidationSubtree() to force checking of paint
invalidation of descendants when overflow clip status changes.

The other changes are needed because we need to move
clearPaintInvalidationFlags() after
newPaintInvalidationState.updateForChildren().

Several overriding invalidateTreeIfNeeded() methods in subclasses are
removed because they have been the same as inherited ones after we
changed the paint invalidation tree walk order.

BUG= 613475 
TEST=paint/invalidation/overflow-hidden-to-visible.html
TEST=paint/invalidation/overflow-visible-to-hidden.html

Review-Url: https://codereview.chromium.org/2000763003
Cr-Commit-Position: refs/heads/master@{#395491}

[modify] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/LayoutTests/fast/repaint/erase-overflow-expected.txt
[add] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-to-visible-expected.html
[add] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-to-visible.html
[add] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/LayoutTests/paint/invalidation/overflow-visible-to-hidden-expected.html
[add] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/LayoutTests/paint/invalidation/overflow-visible-to-hidden.html
[modify] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp
[modify] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp
[modify] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h
[modify] https://crrev.com/d35533844c94bece904fa16ca47acf43e659cb14/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

Comment 4 by wangxianzhu@chromium.org, May 24 2016

Labels: Merge-Request-52

Comment 5 by tin...@google.com, May 24 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3104da0648b2a0fac4ca5463180949a98f7c3414

commit 3104da0648b2a0fac4ca5463180949a98f7c3414
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue May 24 23:58:57 2016

Check subtree paint invalidation when overflow clip status changes

Before https://crrev.com/392652 because we included descendant overflow
into container overflow and the paint invalidation rect covered the
changed part of descendants.

Call setNeedsPaintInvalidationSubtree() to force checking of paint
invalidation of descendants when overflow clip status changes.

The other changes are needed because we need to move
clearPaintInvalidationFlags() after
newPaintInvalidationState.updateForChildren().

Several overriding invalidateTreeIfNeeded() methods in subclasses are
removed because they have been the same as inherited ones after we
changed the paint invalidation tree walk order.

BUG= 613475 
TEST=paint/invalidation/overflow-hidden-to-visible.html
TEST=paint/invalidation/overflow-visible-to-hidden.html

Review-Url: https://codereview.chromium.org/2000763003
Cr-Commit-Position: refs/heads/master@{#395491}

Review URL: https://codereview.chromium.org/2007003003 .

Cr-Commit-Position: refs/branch-heads/2743@{#44}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/LayoutTests/fast/repaint/erase-overflow-expected.txt
[add] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-to-visible-expected.html
[add] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/LayoutTests/paint/invalidation/overflow-hidden-to-visible.html
[add] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/LayoutTests/paint/invalidation/overflow-visible-to-hidden-expected.html
[add] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/LayoutTests/paint/invalidation/overflow-visible-to-hidden.html
[modify] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/Source/core/layout/svg/LayoutSVGInline.cpp
[modify] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp
[modify] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.h
[modify] https://crrev.com/3104da0648b2a0fac4ca5463180949a98f7c3414/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

Comment 7 by wangxianzhu@chromium.org, May 25 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment