New issue
Advanced search Search tips

Issue 613472 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Declare explicit specialization of VectorTraits before use

Project Member Reported by ericwilligers@chromium.org, May 20 2016

Issue description

Our WTF_ALLOW_INIT_WITH_MEM_FUNCTIONS macro defines a specialization of VectorTraits. This specialization must be defined before VectorTraits is first used, for example when appending to a HeapVector in CSSAnimationUpdate::startAnimation.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b9c6d09be1e69c2fd97bdcc0ca4c07a1d6d7528

commit 5b9c6d09be1e69c2fd97bdcc0ca4c07a1d6d7528
Author: ericwilligers <ericwilligers@chromium.org>
Date: Mon May 23 08:27:56 2016

Animation: Declare explicit specialization of VectorTraits before use

The specialization of VectorTraits for NewAnimation and UpdatedAnimation
is now defined before VectorTraits is used, for example in
CSSAnimationUpdate::startAnimation which appends to a HeapVector.

BUG= 613472 
R=alancutter

Review-Url: https://codereview.chromium.org/1996283002
Cr-Commit-Position: refs/heads/master@{#395293}

[modify] https://crrev.com/5b9c6d09be1e69c2fd97bdcc0ca4c07a1d6d7528/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h
[modify] https://crrev.com/5b9c6d09be1e69c2fd97bdcc0ca4c07a1d6d7528/third_party/WebKit/Source/core/animation/css/CSSAnimations.h

Comment 2 by loyso@chromium.org, May 26 2016

Labels: Update-quarterly OS-All

Comment 3 by suzyh@chromium.org, Jul 4 2016

Labels: Hotlist-Squash-A-Bug
Status: Fixed (was: Started)

Sign in to add a comment