New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613465 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 627698

Blocking:
issue 614228



Sign in to add a comment

Add quick view in Files app.

Project Member Reported by oka@chromium.org, May 20 2016

Issue description

Preview your files on Chrome OS with 1-click from within the Files App!

 

Comment 1 by oka@chromium.org, May 20 2016

Let's implement the feature behind a new flag.
Blocking: 614228
Labels: -Cr-Platform-Apps-FileManager
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02

commit 8adb61c8b82ae2ede29e1d81cec7e025ecbabf02
Author: oka <oka@chromium.org>
Date: Fri Jun 10 12:45:14 2016

Quick View: Space key opens quick view for image, video and audio in Download.
--disable-files-quick-view disables quick view.

Demo: https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbkw5UW5GVGNDLXc/view?pli=1

BUG= 613465 
TEST=manually
third_party/closure_compiler/run_compiler

Review-Url: https://codereview.chromium.org/2043333002
Cr-Commit-Position: refs/heads/master@{#399165}

[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/chromeos/chromeos_switches.cc
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/chromeos/chromeos_switches.h
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/externs/files_elements.js
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/elements/elements_bundle.html
[add] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[add] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/js/main_scripts.js
[add] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/manifest.json
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager_resources.grd

Comment 6 by oka@chromium.org, Jun 13 2016

Today's update: Added a functinoality to show generic metadata (size and modification time).
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbzhpSWRsQVZETFE/view?pli=1

Comment 7 by oka@chromium.org, Jun 14 2016

Today's progress: Implemented 
- close button
- open-external button
demo: https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhV1J2VUk1RlJFX2M/view?usp=sharing

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02

commit 8adb61c8b82ae2ede29e1d81cec7e025ecbabf02
Author: oka <oka@chromium.org>
Date: Fri Jun 10 12:45:14 2016

Quick View: Space key opens quick view for image, video and audio in Download.
--disable-files-quick-view disables quick view.

Demo: https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbkw5UW5GVGNDLXc/view?pli=1

BUG= 613465 
TEST=manually
third_party/closure_compiler/run_compiler

Review-Url: https://codereview.chromium.org/2043333002
Cr-Commit-Position: refs/heads/master@{#399165}

[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/chromeos/chromeos_switches.cc
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/chromeos/chromeos_switches.h
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/externs/files_elements.js
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/elements/elements_bundle.html
[add] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[add] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/js/main_scripts.js
[add] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/main.html
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager/manifest.json
[modify] https://crrev.com/8adb61c8b82ae2ede29e1d81cec7e025ecbabf02/ui/file_manager/file_manager_resources.grd

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/328d1470a1ee70d688f24d1eca3c51078ad2cdde

commit 328d1470a1ee70d688f24d1eca3c51078ad2cdde
Author: oka <oka@chromium.org>
Date: Wed Jun 15 08:45:27 2016

Quick View: Add functinoality to show generic metadata (size and modificationTime).
Demo(internal): https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbzhpSWRsQVZETFE/view

BUG= 613465 
TESTED=manually
third_party/closure_compiler/run_compiler

Review-Url: https://codereview.chromium.org/2060983003
Cr-Commit-Position: refs/heads/master@{#399863}

[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/externs/files_elements.js
[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/elements/elements_bundle.html
[add] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
[add] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/elements/icons.html
[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/js/main_scripts.js
[add] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js
[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
[add] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/foreground/js/quick_view_model.js
[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager/manifest.json
[modify] https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde/ui/file_manager/file_manager_resources.grd

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef6fecbba090d954afe3efd69d7c50bbc8a46168

commit ef6fecbba090d954afe3efd69d7c50bbc8a46168
Author: oka <oka@chromium.org>
Date: Wed Jun 15 18:53:08 2016

Quick View: Change file selection with arrow keys.

Also disable quick view if dialog type is not FULL_PAGE (e.g. download dialog).

BUG= 613465 
TEST=manually
third_party/closure_compiler/run_compiler

Review-Url: https://codereview.chromium.org/2070033002
Cr-Commit-Position: refs/heads/master@{#399977}

[modify] https://crrev.com/ef6fecbba090d954afe3efd69d7c50bbc8a46168/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/ef6fecbba090d954afe3efd69d7c50bbc8a46168/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

Comment 13 by oka@chromium.org, Jun 16 2016

Sent CL including
- initial implementation of "No preview available"
- UI update to match it with mocks to some extent.
- Audio thumbnail.
http://crrev.com/2074953002

Demo(internal): https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhQmczRld0MS1nVFU/view?usp=sharing

I spoke to the design team today, and to avoid problems with shield overlapping and dynamically changing preview window sizes, I've updated the Quick View layout (link below). 

One difference is moving the top bar higher above to "cover" the top bar. We can still showcase a breadcrumb so that users know where they are within Quick View. This bar remains the same width as the Files app window.

The "Close" icon is removed, as Quick View will be toggled via keyboard shortcut. This will prevent confusion of two "Close" buttons.

Info panel will not overlay the image/video/audio file, which caused odd "chunks" of color swatches (I can upload an example if needed). This benefits users who may shrink the Files app - the info panel size will remain static while the image/video/audio panel is responsive.

https://drive.google.com/open?id=0B0p7OJNHkJw8VGlBcm5mbTJFeHM
Thanks Tien. The new design looks good! :)

Comment 16 by oka@chromium.org, Jun 18 2016

Tien. Thanks for the update. Removing close button means Space key is the only way to close the window right?
Oka-san, you're welcome! We can close the quick view with the toggle key. We can also close if a user clicks on the quick view shield.
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/743414df7e53e88c911f469d604779e5399c85ed

commit 743414df7e53e88c911f469d604779e5399c85ed
Author: oka <oka@chromium.org>
Date: Sat Jun 18 04:28:33 2016

Quick View: Initial implementation of "No preview availale" and UI update.

Add initial implementation for "No preview available", and update appearance to somewhat match mocks.
Also supported audio thumbnail.

Demo(internal): https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhQmczRld0MS1nVFU/view?usp=sharing

BUG= 613465 
TEST=manually
third_party/closure_compiler/run_compiler

Review-Url: https://codereview.chromium.org/2074953002
Cr-Commit-Position: refs/heads/master@{#400576}

[modify] https://crrev.com/743414df7e53e88c911f469d604779e5399c85ed/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/743414df7e53e88c911f469d604779e5399c85ed/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/743414df7e53e88c911f469d604779e5399c85ed/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
[modify] https://crrev.com/743414df7e53e88c911f469d604779e5399c85ed/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
[add] https://crrev.com/743414df7e53e88c911f469d604779e5399c85ed/ui/file_manager/file_manager/foreground/elements/files_quick_view.css
[modify] https://crrev.com/743414df7e53e88c911f469d604779e5399c85ed/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[modify] https://crrev.com/743414df7e53e88c911f469d604779e5399c85ed/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
[modify] https://crrev.com/743414df7e53e88c911f469d604779e5399c85ed/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
[modify] https://crrev.com/743414df7e53e88c911f469d604779e5399c85ed/ui/file_manager/file_manager_resources.grd

Comment 19 by oka@chromium.org, Jun 18 2016

Ah. OK I just didn't remember clicking gray area also closes the window.

Comment 20 by oka@chromium.org, Jun 23 2016

Sent CL to review. https://codereview.chromium.org/2093673002/:
Support Drive and beautify UI for quick view.

Comment 21 by oka@chromium.org, Jun 23 2016

Sent CL for accessibility. With this, we can satisfy all but three level 1 a11y requirements. go/files-app-quick-view-a11y

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d88718883e2f0525a702482bbe14f148ce62b025

commit d88718883e2f0525a702482bbe14f148ce62b025
Author: oka <oka@chromium.org>
Date: Fri Jul 01 02:00:47 2016

Quick View: Add more metadata and update UI.

Added imageHeight, imageWidth, mediaArtist, mediaTitle and mediaMimeType.
Also added strings for metadata which will be implemented later.

Demo: https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhMDU4bGhTNW5CbDg/view?usp=sharing

BUG= 613465 , 624129 
TEST=manually.

Review-Url: https://codereview.chromium.org/2109563002
Cr-Commit-Position: refs/heads/master@{#403389}

[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/tools/gritsettings/resource_ids
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.js
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_quick_view.css
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_audio.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_folder.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_generic.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_image.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_video.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_audio.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_folder.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_generic.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_image.png
[add] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_video.png
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/js/metadata_box_controller.js
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
[modify] https://crrev.com/d88718883e2f0525a702482bbe14f148ce62b025/ui/file_manager/file_manager_resources.grd

Project Member

Comment 25 by sheriffbot@chromium.org, Jul 9 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 27 by oka@chromium.org, Jul 13 2016

Status: Fixed (was: Started)
Closing this bug since basic implementation is done. I filed known issues as separate bugs.

Imporove security: https://bugs.chromium.org/p/chromium/issues/detail?id=627698
Enable Quick View by default: https://bugs.chromium.org/p/chromium/issues/detail?id=627699
Add test: https://bugs.chromium.org/p/chromium/issues/detail?id=627696
Add UMA: https://bugs.chromium.org/p/chromium/issues/detail?id=627697

Support multiple selection: https://bugs.chromium.org/p/chromium/issues/detail?id=627700
Improve accessibility: https://bugs.chromium.org/p/chromium/issues/detail?id=627701

Comment 28 by oka@chromium.org, Jul 13 2016

Improve security is a blocking issue for launch.

Comment 29 by oka@chromium.org, Jul 13 2016

Blockedon: 627698
Status: Started (was: Fixed)

Comment 30 by oka@chromium.org, Jul 22 2016

Labels: Merge-Request-53
Merge request: please merge #c26 to M53.

Comment 31 by dimu@google.com, Jul 22 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 32 by sheriffbot@chromium.org, Jul 25 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 33 by bugdroid1@chromium.org, Jul 26 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2dd7b2021b62529119f92557f02087f9ec84f6e

commit c2dd7b2021b62529119f92557f02087f9ec84f6e
Author: oka <oka@chromium.org>
Date: Tue Jul 26 07:32:28 2016

Disable Quick View by default and add about flag to enable it.

Set --enable-files-quick-view to enable quick view.

BUG= 613465 
TEST=manually using link.
TBR=fukino@chromium.org,rkaplow@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2127853002
Cr-Commit-Position: refs/heads/master@{#404617}
(cherry picked from commit 0a9c9cdd253d3b0963b7676166bd612cdab7838a)

Review-Url: https://codereview.chromium.org/2178073006
Cr-Commit-Position: refs/branch-heads/2785@{#354}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/c2dd7b2021b62529119f92557f02087f9ec84f6e/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/c2dd7b2021b62529119f92557f02087f9ec84f6e/chrome/browser/about_flags.cc
[modify] https://crrev.com/c2dd7b2021b62529119f92557f02087f9ec84f6e/chromeos/chromeos_switches.cc
[modify] https://crrev.com/c2dd7b2021b62529119f92557f02087f9ec84f6e/chromeos/chromeos_switches.h
[modify] https://crrev.com/c2dd7b2021b62529119f92557f02087f9ec84f6e/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/c2dd7b2021b62529119f92557f02087f9ec84f6e/ui/file_manager/file_manager/foreground/js/file_manager.js

Comment 35 by oka@chromium.org, Aug 17 2016

Status: Fixed (was: Started)
I'd say we've created basics of Quick View. Hence closing the issue.
Status: Verified (was: Fixed)
Verified

Sign in to add a comment