Issue metadata
Sign in to add a comment
|
Regression: Page turns blank in Guest mode when in fullscreen mode.
Reported by
vvishwak...@etouch.net,
May 20 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 52.0.2743.0 (Official Build) 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} (32/64-bit) OS: Windows (7,8,8.1,10) What steps will reproduce the problem? 1) Launch chrome, click on avatar bubble and select 'Switch person'. 2) In 'Switch person' window, enter 'Guest' mode and then press F11 (to enter fullscreen mode). 3) Press Windows button from keyboard, and minimize the Guest profile window. 4) Again click on Guest window profile icon in taskbar and observe. On clicking Guest window icon, page turns blank. On clicking Guest window icon, page should not turn blank. This is a Regression issue broken in M-50, below is the bisect info Manual bisect Good build: 50.0.2657.0 Bad build: 50.0.2658.0 Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/9aab13ccc6998c63acef84a523c29b40f38ef343..b8812fef3cb23bbb30ccfd2884aba1ee60681346?pretty=fuller&n=10000 Suspecting: r377084 Note: Issue is not seen on Mac and Linux OS.
,
May 24 2016
ananta@: Could you please take a look at this. Note: Reproducible on the latest canary(53.0.2746.0) on Windows 10.
,
May 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bda15a4588989436424bc74b05d6aad9c44b41df commit bda15a4588989436424bc74b05d6aad9c44b41df Author: ananta <ananta@chromium.org> Date: Tue May 24 19:08:32 2016 Fix a regression caused by the background fullscreen handling code. For context please refer to this patch https://codereview.chromium.org/1707233002 If a background fullscreen window's size changes again due to a minimize operation, we do inform the delegate about the size change. However during an activation gain if the background_fullscreen_hack_ flag is set we don't inform the delegate about the restored size (fullscreen) which leads to this bug Fix is to inform the delegate if the sent_window_size_changing_ flag is set in this case. BUG= 613461 Review-Url: https://codereview.chromium.org/2007513004 Cr-Commit-Position: refs/heads/master@{#395666} [modify] https://crrev.com/bda15a4588989436424bc74b05d6aad9c44b41df/ui/views/win/hwnd_message_handler.cc
,
May 27 2016
Issue found fixed on Windows 7 for Google Chrome Canary Version - 53.0.2750.0 Screen-recording is attached. @vvishwakarma: Could you please confirm the same. Thank you.
,
May 31 2016
@ananta: Any update on the above issue ? It is not reproducible on latest chrome versions, so can you please change the status to fixed ? Appreciate your help. Thank you!
,
Jun 3 2016
vvishwakarma@ is this issue reproducible in latest canary and Beta?
,
Jun 7 2016
ping to vvishwakarma@
,
Jun 7 2016
With response to comment #6: The above issue is not reproducible on latest canary. It is fixed and is working as intended.
,
Jun 10 2016
Verified this issue on Windows 7 using chrome latest canary M53-53.0.2764.0. No issues observed on clicking Guest window icon. The fix is working fine as intended, Hence adding TE-Verified label. Thanks!
,
Jun 13 2016
@ananta: Could you please change the status of this issue, since it is already fixed (as confirmed by TE in the comment #9) Thank you.
,
Jun 15 2016
ananta@, can you please request a merge to M52 branch as this is working fine on ToT build in # 9 ?
,
Jun 16 2016
A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!
,
Jun 21 2016
ananta@ gentle ping..
,
Jun 27 2016
ananta@ : Gentle ping..to merge the above CL to M52 branch at the earliest.
,
Jun 27 2016
,
Jun 27 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 27 2016
** IMPORTANT change in M52 merge date due to first 2 weeks of July no release weeks ** M52 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on July 1 to make into the desktop Stable final build cut. Thank you!
,
Jun 27 2016
ananta@, please merge the CL in to M52 branch by EOD so that it gets picked up for Beta promotion scheduled this wednesday.
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97690fc7759349821e04633c8b48542b54d6ba34 commit 97690fc7759349821e04633c8b48542b54d6ba34 Author: Anantanarayanan Iyengar <ananta@chromium.org> Date: Tue Jun 28 03:30:49 2016 Fix a regression caused by the background fullscreen handling code. Merging to M52 For context please refer to this patch https://codereview.chromium.org/1707233002 If a background fullscreen window's size changes again due to a minimize operation, we do inform the delegate about the size change. However during an activation gain if the background_fullscreen_hack_ flag is set we don't inform the delegate about the restored size (fullscreen) which leads to this bug Fix is to inform the delegate if the sent_window_size_changing_ flag is set in this case. BUG= 613461 Review-Url: https://codereview.chromium.org/2007513004 Cr-Commit-Position: refs/heads/master@{#395666} (cherry picked from commit bda15a4588989436424bc74b05d6aad9c44b41df) Review URL: https://codereview.chromium.org/2105643002 . Cr-Commit-Position: refs/branch-heads/2743@{#501} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/97690fc7759349821e04633c8b48542b54d6ba34/ui/views/win/hwnd_message_handler.cc
,
Jun 28 2016
,
Jun 30 2016
Verified this issue on Windows 7 using chrome latest M52-52.0.2743.60 by following steps mentioned in the original comment. No issues observed on clicking Guest window icon. The fix is working fine as intended, Hence adding TE-Verified label. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ashej...@chromium.org
, May 20 2016