New issue
Advanced search Search tips

Issue 613459 link

Starred by 1 user
Status: Fixed
Owner:
peria@chromium.org
Closed: May 2016
Cc:
yukishiino@chromium.org
haraken@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Binding: Drop hasInstance() method from ArrayBuffer interface

Project Member Reported by peria@chromium.org, May 20 2016 
It is confusing that we have hasInstance() in ArrayBuffer (+SharedArrayBuffer
and ArrayBufferView) interface, and it does a very light method call defined in V8.
So we can use both obj->IsArrayBuffer() and ArrayBuffer::hasInstance(obj, isolate)
to check if an object is a ArrayBuffer instance.

I'd like to remove hasInstance() to fix this confusing situation.
Project Member

Comment 1 by bugdroid1@chromium.org, May 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2

commit a75bcf89c90d9ea27b8ad6618d814a2e22b345d2
Author: peria <peria@chromium.org>
Date: Fri May 20 10:46:16 2016

Delete hasInstance() method from V8ArrayBuffer, V8ArrayBufferView,
V8SharedArrayBuffer, and V8{{Type}}Array.

We can use v->IsT() instead of T::hasInstance(v, isolate).

Files under tests/ were updated by scripts.

BUG= 613459 

Review-Url: https://codereview.chromium.org/1996903002
Cr-Commit-Position: refs/heads/master@{#395052}

[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/scripts/v8_union.py
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/templates/interface.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/templates/interface.h
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/templates/union_container.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.h
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.h
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.h
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandle.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/modules/fetch/Response.cpp
[modify] https://crrev.com/a75bcf89c90d9ea27b8ad6618d814a2e22b345d2/third_party/WebKit/Source/web/WebArrayBufferConverter.cpp

Comment 2 by peria@chromium.org, May 23 2016

Status: Fixed (was: Started)
►

Sign in to add a comment