Issue metadata
Sign in to add a comment
|
Regression: Wrong ‘Apps shortcut icon’ is seen on bookmark bar.
Reported by
dmascare...@etouch.net,
May 20 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:52.0.2743.0 (Official Build)2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} OS: Mac (10.10.5, 10.11.4) What steps will reproduce the problem? 1. Launch chrome,Open Ntp and observe ‘Apps shortcut icon’ on bookmark bar. Actual: Wrong ‘Apps shortcut icon’ is seen on bookmark bar. Expected: Apps shortcut icon should be proper. This is regression issue , broken in ‘M 52’ and narrow bisect: https://chromium.googlesource.com/chromium/src/+log/e18e3dd1a51cfdf6f278b4986e853a016effd249..6b693cb69c1731ac3e4fa0851e64fd10fa820a1c?pretty=fuller&n=1000 Suspecting: r394851 Good build:52.0.2742.0 Bad build:52.0.2743.0 Note: Issue is not reproducible on Windows and Linux OS.
,
May 20 2016
,
May 24 2016
shrike@: Is there an update on this Beta blocker? Note: Issue still repros on the latest canary(53.0.2347.0) on Mac OS 10.11.5.
,
May 24 2016
Plan to work on this today.
,
May 24 2016
,
May 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4faf1132c3d418b065d5600b8ed07f4175b15bfe commit 4faf1132c3d418b065d5600b8ed07f4175b15bfe Author: shrike <shrike@chromium.org> Date: Tue May 24 19:13:07 2016 [Mac][Material Design] Restore apps page shortcut icon in bookmarks bar. A recent bookmarks bar change caused the apps page shortcut button to display a document icon instead of the 9 colored dots icon. R=avi@chromium.org BUG= 613458 Review-Url: https://codereview.chromium.org/2007103002 Cr-Commit-Position: refs/heads/master@{#395669} [modify] https://crrev.com/4faf1132c3d418b065d5600b8ed07f4175b15bfe/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h [modify] https://crrev.com/4faf1132c3d418b065d5600b8ed07f4175b15bfe/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/4faf1132c3d418b065d5600b8ed07f4175b15bfe/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm
,
May 24 2016
,
May 25 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/751ce64520b7f5e38053fab2b56c47a4ca12de8d commit 751ce64520b7f5e38053fab2b56c47a4ca12de8d Author: Jayson Adams <shrike@chromium.org> Date: Wed May 25 18:26:13 2016 [Mac][Material Design] Restore apps page shortcut icon in bookmarks bar. A recent bookmarks bar change caused the apps page shortcut button to display a document icon instead of the 9 colored dots icon. R=avi@chromium.org BUG= 613458 Review-Url: https://codereview.chromium.org/2007103002 Cr-Commit-Position: refs/heads/master@{#395669} (cherry picked from commit 4faf1132c3d418b065d5600b8ed07f4175b15bfe) Review URL: https://codereview.chromium.org/2008403002 . Cr-Commit-Position: refs/branch-heads/2743@{#57} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/751ce64520b7f5e38053fab2b56c47a4ca12de8d/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h [modify] https://crrev.com/751ce64520b7f5e38053fab2b56c47a4ca12de8d/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/751ce64520b7f5e38053fab2b56c47a4ca12de8d/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm
,
May 25 2016
,
May 26 2016
Verified the merge on the latest M-52(52.0.2743.10) on Mac OS 10.11.5 and this is working as intended. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ashej...@chromium.org
, May 20 2016