Many of our classes are never copied, and should be declared as non copyable. For example, it is very rare for classes holding HeapVector members to be intentionally copyable.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9197d2dc48d4d24f540ca49295166d083db9c1ab commit 9197d2dc48d4d24f540ca49295166d083db9c1ab Author: ericwilligers <ericwilligers@chromium.org> Date: Fri May 20 11:26:44 2016 CSS: SelectorFilter is non-copyable Declare various CSS classes as non-copyable. BUG= 613450 R=timloh@chromium.org Review-Url: https://codereview.chromium.org/1996883002 Cr-Commit-Position: refs/heads/master@{#395056} [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/CSSStyleSheet.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/CSSValueList.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/CSSValuePool.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/FontFace.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/FontFaceSet.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/MediaQueryList.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/RuleFeature.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/SelectorFilter.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/invalidation/StyleSheetInvalidationAnalysis.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/parser/CSSParserImpl.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/parser/MediaQueryParser.h [modify] https://crrev.com/9197d2dc48d4d24f540ca49295166d083db9c1ab/third_party/WebKit/Source/core/css/resolver/MatchResult.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab4338e9e30c29c0bf95f47bc90f7d044c7e708d commit ab4338e9e30c29c0bf95f47bc90f7d044c7e708d Author: ericwilligers <ericwilligers@chromium.org> Date: Fri May 20 12:57:17 2016 Input: TouchEventManager and PointerEventManager are non-copyable Declare TouchEventManager and PointerEventManager as non-copyable. BUG= 613450 R=keishi@chromium.org Review-Url: https://codereview.chromium.org/1998963002 Cr-Commit-Position: refs/heads/master@{#395060} [modify] https://crrev.com/ab4338e9e30c29c0bf95f47bc90f7d044c7e708d/third_party/WebKit/Source/core/input/PointerEventManager.h [modify] https://crrev.com/ab4338e9e30c29c0bf95f47bc90f7d044c7e708d/third_party/WebKit/Source/core/input/TouchEventManager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c41bd0d73f5041c7eebc5fa35e44ce75984f5836 commit c41bd0d73f5041c7eebc5fa35e44ce75984f5836 Author: ericwilligers <ericwilligers@chromium.org> Date: Tue May 24 01:33:06 2016 AXObject is not copyable Declare AXObject and AXNodeObject as non-copyable. BUG= 613450 R=dmazzoni@chromium.org Review-Url: https://codereview.chromium.org/1996873002 Cr-Commit-Position: refs/heads/master@{#395506} [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXARIAGridRow.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXList.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXListBox.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXMediaControls.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXMenuList.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXMockObject.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXObject.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXProgressIndicator.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXRadioInput.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXSVGRoot.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXSlider.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXTable.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXTableCell.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXTableColumn.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXTableHeaderContainer.h [modify] https://crrev.com/c41bd0d73f5041c7eebc5fa35e44ce75984f5836/third_party/WebKit/Source/modules/accessibility/AXTableRow.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13e4f029fe21cda3df12bb34eb0b9f1e516c8d55 commit 13e4f029fe21cda3df12bb34eb0b9f1e516c8d55 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Sep 14 03:09:57 2016 WebGL: WebGLObject is non-copyable WebGLExtension, WebGLObject and WebGLRenderingContextBase are now declared non-copyable BUG= 613450 R=bajones@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2001503002 Cr-Commit-Position: refs/heads/master@{#418471} [modify] https://crrev.com/13e4f029fe21cda3df12bb34eb0b9f1e516c8d55/third_party/WebKit/Source/modules/webgl/WebGLExtension.h [modify] https://crrev.com/13e4f029fe21cda3df12bb34eb0b9f1e516c8d55/third_party/WebKit/Source/modules/webgl/WebGLObject.h [modify] https://crrev.com/13e4f029fe21cda3df12bb34eb0b9f1e516c8d55/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
Comment 1 by bugdroid1@chromium.org
, May 20 2016