New issue
Advanced search Search tips

Issue 613442 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 582622



Sign in to add a comment

Add option to enable component update in InProcessBrowserTest

Project Member Reported by xhw...@chromium.org, May 20 2016

Issue description

Now with the support of bundled components (see  issue 608128 ), we should be able to provide test coverage for it. However, currently a lot of browser tests (InProcessBrowserTest) have component update disabled by default:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/base/test_launcher_utils.cc&rcl=1463699816&l=72

We should provide a way not to disable component update in some cases to test features that rely on bundled components.
 

Comment 1 by xhw...@chromium.org, May 20 2016

Status: Started (was: Untriaged)
A tentative CL is at https://chromiumcodereview.appspot.com/1996863002/
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3be44be552846983cf371256718ce8ec81c565b4

commit 3be44be552846983cf371256718ce8ec81c565b4
Author: xhwang <xhwang@chromium.org>
Date: Wed May 25 17:24:49 2016

media: Use bundled Widevine CDM in encrypted media browser tests

- Provide option to enable component update in browser tests
- Enable component update in encrypted media related browser tests to pick up the bundled Widevine CDM.
- Remove code that manually registers Widevine CDM.
- Enable more tests that wasn't possible when CDM is manually registered.

BUG= 613442 ,582622,613581

Review-Url: https://codereview.chromium.org/1996863002
Cr-Commit-Position: refs/heads/master@{#395922}

[modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/browser/content_settings/content_settings_browsertest.cc
[modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/browser/media/encrypted_media_supported_types_browsertest.cc
[modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/test/base/in_process_browser_test.h
[modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/test/base/test_launcher_utils.cc
[modify] https://crrev.com/3be44be552846983cf371256718ce8ec81c565b4/chrome/test/base/test_launcher_utils.h

Comment 3 by xhw...@chromium.org, May 25 2016

Status: Fixed (was: Started)

Sign in to add a comment