Unprefix -webkit-filter (metabug)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a0f0e2eb0abdd68fb377d5b789682acfe10757d commit 7a0f0e2eb0abdd68fb377d5b789682acfe10757d Author: fs <fs@opera.com> Date: Mon Jun 20 19:59:36 2016 Unprefix the CSS 'filter' property Parse 'filter' in the same way as '-webkit-filter', and make the latter an alias of the former. For SVG content, only the "url(...)" function is allowed still, with the exception of the outermost <svg> (LayoutSVGRoot), since that "has a box". Update tests to use 'filter' where reasonable and applicable. Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/ZVT2kxuFMaA/discussion Based on https://codereview.chromium.org/1987943002 by noel@chromium.org. BUG= 613441 , 618160 , 550249 , 535786 , 244295 ,109224 Review-Url: https://codereview.chromium.org/2065593002 Cr-Commit-Position: refs/heads/master@{#400752} [add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/animations/animated-filter-svg-element-expected.html [add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/animations/animated-filter-svg-element.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/compositing/will-change/stacking-context-creation-expected.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/compositing/will-change/stacking-context-creation.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-all-on-background-expected.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-blur-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-blur.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-brightness-clamping-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-brightness-clamping.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-brightness-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-brightness.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-combined-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-combined.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-contrast-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-contrast.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-drop-shadow-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-drop-shadow.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-grayscale-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-grayscale.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-hue-rotate-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-hue-rotate.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-invert-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-invert.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-opacity-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-opacity.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference-composite-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference-composite.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference-ordering-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference-ordering.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-reference.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-saturate-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-saturate.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-sepia-hw.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/effect-sepia.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/fecomposite-non-zero-inoffset.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/feoffset-region-zoom-expected.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-property-computed-style.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-property-parsing-invalid.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-property-parsing.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-region-transformed-child-expected.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-blur.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/filter-repaint-shadow.html [add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/css3/filters/unprefixed.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/css/getComputedStyle-listing-expected.txt [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/filter-refresh-expected.txt [add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter-expected.html [add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-element-invalid-filter.html [add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-filter-child-box-reflect-expected.html [add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-filter-child-box-reflect.html [add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-filter-root-box-reflect-expected.html [add] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/svg/filters/svg-filter-root-box-reflect.html [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/DeferredLegacyStyleInterpolationTest.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/ElementAnimations.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/FilterListPropertyFunctions.h [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/CSSProperties.in [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/CSSPropertyEquality.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/frame/UseCounter.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/SVGResources.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/SVGResources.h [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/layout/svg/SVGResourcesCache.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/paint/SVGPaintContext.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/paint/SVGRootPainter.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/style/SVGComputedStyle.h [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/style/SVGComputedStyleDefs.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/core/style/SVGComputedStyleDefs.h [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp [modify] https://crrev.com/7a0f0e2eb0abdd68fb377d5b789682acfe10757d/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c81b98a7f75beceda209a72eb52bf88ca35e620e commit c81b98a7f75beceda209a72eb52bf88ca35e620e Author: fs <fs@opera.com> Date: Mon Jun 20 22:54:02 2016 Update baselines for svg/filters/filter-refresh.svg TBR=pdr@chromium.org NOTRY=true BUG= 613441 Review-Url: https://codereview.chromium.org/2086713002 Cr-Commit-Position: refs/heads/master@{#400818} [modify] https://crrev.com/c81b98a7f75beceda209a72eb52bf88ca35e620e/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5db19a97a574b0fe2e3ee50ecc2a84e6a1523575 commit 5db19a97a574b0fe2e3ee50ecc2a84e6a1523575 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Tue Jun 21 00:14:57 2016 Auto-rebaseline for r400818 https://chromium.googlesource.com/chromium/src/+/c81b98a7f BUG= 613441 TBR=fs@opera.com Review URL: https://codereview.chromium.org/2085823002 . Cr-Commit-Position: refs/heads/master@{#400848} [modify] https://crrev.com/5db19a97a574b0fe2e3ee50ecc2a84e6a1523575/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/5db19a97a574b0fe2e3ee50ecc2a84e6a1523575/third_party/WebKit/LayoutTests/svg/filters/filter-refresh-expected.txt
Is this fixed?
Yes, just needed to update the chromestatus entry. Now done.
Comment 1 by shans@chromium.org
, May 20 2016