New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613433 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 617826
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

14.8% regression in thread_times.key_silk_cases at 394768:394784

Project Member Reported by kouhei@chromium.org, May 20 2016

Issue description

See the link to graphs below.
 

Comment 1 by kouhei@chromium.org, May 20 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=613433

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgjInivgoM


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 20 2016

Cc: jaydasika@chromium.org
Owner: jaydasika@chromium.org

=== Auto-CCing suspected CL author jaydasika@chromium.org ===

Hi jaydasika@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : cc : Track ids for which active opacity always wins on property trees
Author  : jaydasika
Commit description:
  
And then use this for partial sync of property trees at the time of
activation. PaintedScrollbarLayer and SolidColorScrollbarLayer currently
need the active tree opacity to win at activation.

BUG= 611899 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1991523002
Cr-Commit-Position: refs/heads/master@{#394784}
Commit  : ae9b7a05e087905774fb29807281fa771711ff3b
Date    : Thu May 19 16:14:26 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev     N  Good?
chromium@394767  2.03666  0.0294188   5  good
chromium@394776  2.05153  0.0123458   5  good
chromium@394780  2.05363  0.0045332   5  good
chromium@394782  2.07578  0.00729808  5  good
chromium@394783  2.06483  0.0160876   5  good
chromium@394784  2.42749  0.00662564  5  bad    <--

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 613433

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests thread_times.key_silk_cases
Test Metric: thread_renderer_compositor_cpu_time_per_frame/thread_renderer_compositor_cpu_time_per_frame
Relative Change: 19.19%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2194
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012176801082769248


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5775280145170432

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: ajuma@chromium.org
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This is caused because we push opacity of scrollbars from active tree to pending tree every frame. With layers, we would do it only if the layer pushed properties.
https://codereview.chromium.org/2035433002 has perf bot results where I removed the pushing opacity. 
Mergedinto: 617826
Status: Duplicate (was: Assigned)
Same

Sign in to add a comment