"WidgetTest.WindowModalityActivationTest" is flaky (Windows) |
||||||||
Issue description"WidgetTest.WindowModalityActivationTest" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMgsSBUZsYWtlIidXaWRnZXRUZXN0LldpbmRvd01vZGFsaXR5QWN0aXZhdGlvblRlc3QM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 20 2016
Log: [ RUN ] WidgetTest.WindowModalityActivationTest e:\b\build\slave\win\build\src\ui\views\widget\desktop_aura\desktop_native_widget_aura_unittest.cc(629): error: Value of: 1 Expected: activate_result Which is: 4 [ FAILED ] WidgetTest.WindowModalityActivationTest (87 ms)
,
May 20 2016
I can't find the culprit so I'm going to go ahead and disable the test
,
May 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e2e728ff381be4262498fe3095a2ac233b85d2f commit 8e2e728ff381be4262498fe3095a2ac233b85d2f Author: spqchan <spqchan@chromium.org> Date: Sat May 21 01:40:48 2016 Disabled flaky WidgetTest.WindowModalityActivationTest BUG= 613428 TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/2005463004 Cr-Commit-Position: refs/heads/master@{#395225} [modify] https://crrev.com/8e2e728ff381be4262498fe3095a2ac233b85d2f/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
,
May 21 2016
Detected 4 new flakes for test/step "WidgetTest.WindowModalityActivationTest". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMgsSBUZsYWtlIidXaWRnZXRUZXN0LldpbmRvd01vZGFsaXR5QWN0aXZhdGlvblRlc3QM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
May 23 2016
,
Jul 6 2016
,
Jan 24 2018
,
Jan 24 2018
,
May 29 2018
bsep: could you take a look? This is some Windows thing.
flakes started on try run at 2016-05-19 22:30:51 UTC - only observed on windows.
This test runs Windows only.
Failure is on
LRESULT activate_result = ::SendMessage(
win32_window,
WM_MOUSEACTIVATE,
reinterpret_cast<WPARAM>(win32_window),
MAKELPARAM(WM_LBUTTONDOWN, HTCLIENT));
EXPECT_EQ(activate_result, MA_ACTIVATE);
the EXPECT is backwards - MA_ACTIVATE is 1, MA_NOACTIVATEANDEAT is 4, so the failure is saying the top-level widget
assuming the plumbing is correct.. this should end up in
HWNDMessageHandler::OnMouseActivate(..)
Maybe the fix for the flake is to move this to widget_interactive_uitest.cc, or maybe there's something else going on.
,
Nov 16
Reenabling test. This seems to work fine with gtest_repeat=100.
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a895ac849216d4d01a1b859a910ffd79e242e44 commit 7a895ac849216d4d01a1b859a910ffd79e242e44 Author: Robert Liao <robliao@chromium.org> Date: Fri Nov 16 22:24:15 2018 Reenable WidgetTest.WindowModalityActivationTest This seems to work fine with gtest_repeat=100. BUG= 613428 Change-Id: I045735c4174c8656bfa8d51669142385d35f1233 Reviewed-on: https://chromium-review.googlesource.com/c/1340793 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#608989} [modify] https://crrev.com/7a895ac849216d4d01a1b859a910ffd79e242e44/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
,
Nov 16
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hirosh...@chromium.org
, May 20 2016