Making it a bit more consistent with newer Polymer WebUI will make it easier to extend for testing new settings.
attached the "after" screenshot from https://codereview.chromium.org/1999593002
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a658634192afc565b2d1cf703234579fe2f73e0a commit a658634192afc565b2d1cf703234579fe2f73e0a Author: michaelpg <michaelpg@chromium.org> Date: Sat May 21 04:48:06 2016 Update chrome://device-emulator with newer Polymer guidelines Lots of changes from recent Polymer updates. Also freshen up the style a little, make dialogs close on Escape, remove dependency on iron-icons. New screenshot (not much changed visually) in the bug. Note that this only applies to non-official Debug builds. After this I'll add new settings, e.g. pointer settings. BUG= 613416 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1999593002 Cr-Commit-Position: refs/heads/master@{#395248} [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/browser_resources.grd [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/audio_settings.html [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/audio_settings.js [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/battery_settings.html [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/battery_settings.js [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/bluetooth_settings.js [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/device_emulator.html [delete] https://crrev.com/495f126aa1c0f77e8b5a99fc0ea741501404ae7a/chrome/browser/resources/chromeos/emulator/device_emulator.js [add] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/device_emulator_pages.html [add] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/device_emulator_pages.js [add] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/icons.html [delete] https://crrev.com/495f126aa1c0f77e8b5a99fc0ea741501404ae7a/chrome/browser/resources/chromeos/emulator/shared_styles.css [add] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/resources/chromeos/emulator/shared_styles.html [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.h [modify] https://crrev.com/a658634192afc565b2d1cf703234579fe2f73e0a/chrome/browser/ui/webui/chromeos/emulator/device_emulator_ui.cc
@michaelpg Hi, trying to verify this bug. When I try to open chrome://device-emulator it says "Site cannot be reached. ERR_INVALID_URL" Am I missing something here?
This is a debug-only UI; it does not need verification, and only appears in Debug builds when not running on a Chrome OS device (ie, on Linux).
michaelpg@ Thanks for the update. Closing the bug as per #5
Comment 1 by michae...@chromium.org
, May 20 2016406 KB
406 KB View Download