New issue
Advanced search Search tips

Issue 613387 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Skip _CheckTestharnessResults() in LayoutTests/PRESUBMIT.py for files in platform/ and virtual/.

Project Member Reported by qyears...@chromium.org, May 20 2016

Issue description

In general, for testharness.js tests, we don't keep -expected.txt files that include only PASS lines. However, for platform-specific expectations, sometimes all-PASS files are required, because if an expectations file is missing then it falls back to a more general expectation which may include FAIL lines.

Example: https://codereview.chromium.org/1991613002/
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84044bffc3a99a4eb785ad1b207677a460d6a8e8

commit 84044bffc3a99a4eb785ad1b207677a460d6a8e8
Author: qyearsley <qyearsley@chromium.org>
Date: Mon May 23 18:35:23 2016

Don't check for all-pass baseline files in platform and virtual.

BUG= 613387 

Review-Url: https://codereview.chromium.org/2002513002
Cr-Commit-Position: refs/heads/master@{#395370}

[modify] https://crrev.com/84044bffc3a99a4eb785ad1b207677a460d6a8e8/third_party/WebKit/LayoutTests/PRESUBMIT.py

Owner: qyears...@chromium.org
Status: Fixed (was: Unconfirmed)
Fix verified: presubmit now does not warn about all-PASS expectations in platform directory.
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8039077e177e3a636caf28492e9f30c13d97060

commit b8039077e177e3a636caf28492e9f30c13d97060
Author: caseq <caseq@chromium.org>
Date: Mon May 23 22:23:49 2016

Revert of In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual. (patchset #4 id:60001 of https://codereview.chromium.org/2002513002/ )

Reason for revert:
This broke presubmit on layout tests with:
NameError: global name 'expected_files' is not defined

Original issue's description:
> Don't check for all-pass baseline files in platform and virtual.
>
> BUG= 613387 
>
> Committed: https://crrev.com/84044bffc3a99a4eb785ad1b207677a460d6a8e8
> Cr-Commit-Position: refs/heads/master@{#395370}

TBR=dpranke@chromium.org,tkent@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 613387 

Review-Url: https://codereview.chromium.org/2008753002
Cr-Commit-Position: refs/heads/master@{#395438}

[modify] https://crrev.com/b8039077e177e3a636caf28492e9f30c13d97060/third_party/WebKit/LayoutTests/PRESUBMIT.py

Hmm; I thought that I had verified this as working, but hadn't fully verified -- I had run it once in a case where _TestharnessBaselineFilesToCheck returned an empty list so it didn't get to the broken line.
Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98b84f707fd8961d40e9015cae79370975f1ac69

commit 98b84f707fd8961d40e9015cae79370975f1ac69
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 24 00:05:10 2016

Reland of In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual. (patchset #1 id:1 of https://codereview.chromium.org/2008753002/ )

Reason for revert:
Creating reland patch (fixing error)

Original issue's description:
> Revert of In LayoutTests PRESUBMIT, Don't check for all-pass baseline files in platform and virtual. (patchset #4 id:60001 of https://codereview.chromium.org/2002513002/ )
>
> Reason for revert:
> This broke presubmit on layout tests with:
> NameError: global name 'expected_files' is not defined
>
> Original issue's description:
> > Don't check for all-pass baseline files in platform and virtual.
> >
> > BUG= 613387 
> >
> > Committed: https://crrev.com/84044bffc3a99a4eb785ad1b207677a460d6a8e8
> > Cr-Commit-Position: refs/heads/master@{#395370}
>
> TBR=dpranke@chromium.org,tkent@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 613387 
>
> Committed: https://crrev.com/b8039077e177e3a636caf28492e9f30c13d97060
> Cr-Commit-Position: refs/heads/master@{#395438}

TBR=dpranke@chromium.org,tkent@chromium.org,caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 613387 

Review-Url: https://codereview.chromium.org/2006963002
Cr-Commit-Position: refs/heads/master@{#395473}

[modify] https://crrev.com/98b84f707fd8961d40e9015cae79370975f1ac69/third_party/WebKit/LayoutTests/PRESUBMIT.py

Cc: robertma@chromium.org mlamouri@chromium.org dpranke@chromium.org wolenetz@chromium.org ddorwin@chromium.org jsb...@chromium.org qyears...@chromium.org
 Issue 570044  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77a8696a4ddaa997b7047fc740aa7c57f799208b

commit 77a8696a4ddaa997b7047fc740aa7c57f799208b
Author: Robert Ma <robertma@chromium.org>
Date: Fri Nov 17 20:22:47 2017

Fix some docs for all-PASS baseline checking

Bug:  613387 
Change-Id: I3696db30690ea6bd7de673989e2846ec186bea25
Reviewed-on: https://chromium-review.googlesource.com/775758
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517534}
[modify] https://crrev.com/77a8696a4ddaa997b7047fc740aa7c57f799208b/third_party/WebKit/LayoutTests/PRESUBMIT.py
[modify] https://crrev.com/77a8696a4ddaa997b7047fc740aa7c57f799208b/third_party/WebKit/Tools/Scripts/check-testharness-expected-pass

Sign in to add a comment