New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613382 link

Starred by 2 users
Status: Fixed
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

UI string for Page Down is "PgDwn"; should be "PgDn"

Project Member Reported by mgiuca@chromium.org, May 19 2016 
I have never seen "PgDwn" as an abbreviation for Page Down; a Google Search shows no results in the top page referring to the key combination. Conversely, https://en.wikipedia.org/wiki/Page_Up_and_Page_Down_keys says "sometimes abbreviated as PgUp and PgDn" and this is the common abbreviation I have always seen.

Comment 1 by mgiuca@chromium.org, May 20 2016 

Note: I can't actually figure out how to make this show up in the UI, if it's at all possible. It's in the strings database because GetShortcutText will use it if a shortcut has PgDn in it (but I can't find any such shortcuts that get displayed in the UI).
Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5eb3649952f4e37b8759395a145e1e86664ab6f0

commit 5eb3649952f4e37b8759395a145e1e86664ab6f0
Author: mgiuca <mgiuca@chromium.org>
Date: Mon May 23 01:56:41 2016

UI strings: expand PgUp and PgDwn to the full words.

Now reads "Page Up" and "Page Down". This is consistent with all of the
other key names which use the full word.

BUG= 613382 

Review-Url: https://codereview.chromium.org/1992403002
Cr-Commit-Position: refs/heads/master@{#395279}

[modify] https://crrev.com/5eb3649952f4e37b8759395a145e1e86664ab6f0/ui/strings/ui_strings.grd

Comment 3 by mgiuca@chromium.org, May 23 2016

Status: Fixed (was: Started)
►

Sign in to add a comment