New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613347 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

IDS_FOO_BAR has to be cross-linked between grd/grdp and C++ source files

Project Member Reported by js...@chromium.org, May 19 2016

Issue description

How to reproduce:

1. Go to any source (C++) files with IDS_ (message id) referenced. 
 (say, https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc&l=234 )

2. Click on IDS_FOO_BAR ( e.g. IDS_BOOKMARK_EDITOR_CONFIRM_DELETE )

What's expected

1. In addition to cc/h files referencing that, grd/grdp files show up in the list

Actual:
Only cc/h files are shown. So, I have to copy'n'paste the string id to the searchbox. 

P.S. 
Even better would be to link IDS_FOO_BAR to actual xtb files (translated strings).  This requires mapping IDS_FOO_BAR to its numeric message ids in XTB (different from the integer value of IDS_FOO_BAR in a header file). So, I'll not ask for that, yet. :-)

 

Comment 1 by js...@chromium.org, May 19 2016

Cc: tinazh@chromium.org
As for searching for translated strings corresponding to IDS_FOO_BAR, what I do is to grep *en_GB.xtb files with (a substring of) the original message (en-US) because en-GB is almost identical to en-US to find out the corresponding xtb message id. 
Then, use that xtb message id to look for translated strings in other languages. 

Anyway, that should be a separate feature request. 

Comment 2 by js...@chromium.org, May 19 2016

Labels: -Type-Bug OS-All Type-Feature
I forgot to list the flip-side (going from grd/grdp to C++ source files):

How to reproduce:

1. Go to a grd/grdp file with IDS_FOO_BAR
(e.g. https://goo.gl/1dTT2n : src/chrome/app/chromium_strings.grd )

2.  Try to click on IDS_MESSAGE_CENTER_TOOLTIP_UNREAD 

<message name="IDS_MESSAGE_CENTER_TOOLTIP_UNREAD" desc="Tooltip for notification tray icon with unread notifications">
          Chromium - Notifications (<ph name="QUANTITY">$1<ex>3</ex></ph> unread)
        </message>

Expected:

IDS_FOO_BAR is clickable and linked to C++ source files where that message is used. 

Actual: 
It's not a link. 

Comment 3 by js...@chromium.org, May 19 2016

Components: UI>Localization UI>Internationalization

Comment 4 by js...@chromium.org, May 19 2016

Summary: IDS_FOO_BAR has to be cross-linked between grd/grdp and C++ source files (was: IDS_FOO_BAR has to be linked to grd/grdp files to/from C++ source files)
Status: Available (was: Untriaged)

Comment 6 by emso@chromium.org, Sep 15 2016

Labels: Lang Xrefs

Comment 7 by ecacho@google.com, Jun 28 2017

Components: -UI>Localization UI>Browser
Labels: Needs-TestConfirmation
Status: Unconfirmed (was: Available)
This is not a localization bug. Can't confirm that it's still relevant to the current English UI
Labels: -Needs-TestConfirmation
Tested this issue on Mac 10.12.5 with chrome #61.0.3144.0 as per steps mentioned in comment #0.

Observed Only cc/h files are shown on clicking "IDS_BOOKMARK_EDITOR_CONFIRM_DELETE"

Attaching the screen-cast for reference.
613347.mp4
3.1 MB View Download

Comment 9 by emso@chromium.org, Jun 30 2017

Status: Available (was: Unconfirmed)
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 2

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
I think this would require implementing a custom cross-reference parser and adding support for a new language to Kythe, which is infeasible in the near future.
Components: -UI>Browser -UI>Internationalization

Sign in to add a comment