New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613336 link

Starred by 2 users
Status: Fixed
Owner:
dmazz...@chromium.org
Closed: May 2016
Cc:
█ nek...@chromium.org
█ ananta@chromium.org
sky@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression
Team-Accessibility

Blocking:
issue 393665



Sign in to add a comment

LegacyRenderWidgetHostHWND sometimes not created!

Project Member Reported by dmazz...@chromium.org, May 19 2016 
This serious bug repros for me every time:

1. Enable accessibility by visiting chrome://accessibility and clicking on the link to turn it on globally
2. Load google.com, do a search for "Ace Hardware"
3. See that accessibility events are being generated as you Tab through the page - you can use Inspect.exe, or use logging with --vmodule="*browser_accessibility_event*=1"
4. Tab to the first organic result, press Enter
5. When the Ace Hardware homepage loads, no accessibility events are generated for the page as you tab through it
6. Now resize the window. Accessibility events are generated again

The underlying issue is that the LegacyRenderWidgetHostHWND is only created inside RenderWidgetHostViewAura::InternalSetBounds, and only if the parent HWND is known. However, under some circumstances like this one, InternalSetBounds only gets called once and it gets called *before* the aura Window is attached, so the legacy win never gets created.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7e78f6f5d453c52313b74de10c5f680aa3d5ee3

commit a7e78f6f5d453c52313b74de10c5f680aa3d5ee3
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue May 24 18:43:04 2016

Ensure LegacyRenderWidgetHostHWND is always created.

Previously, LegacyRenderWidgetHostHWND was only created inside
RenderWidgetHostViewAura::InternalSetBounds, and only if the parent
HWND was known. However, under some circumstances, InternalSetBounds
only gets called once and it gets called *before* the aura Window is
attached, so the legacy win never gets created.

Fix it by also trying to create the legacy win in
RWHVA::AddedToRootWindow().

BUG= 613336 

Review-Url: https://codereview.chromium.org/1996163002
Cr-Commit-Position: refs/heads/master@{#395649}

[modify] https://crrev.com/a7e78f6f5d453c52313b74de10c5f680aa3d5ee3/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/a7e78f6f5d453c52313b74de10c5f680aa3d5ee3/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/a7e78f6f5d453c52313b74de10c5f680aa3d5ee3/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/a7e78f6f5d453c52313b74de10c5f680aa3d5ee3/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/a7e78f6f5d453c52313b74de10c5f680aa3d5ee3/content/browser/web_contents/web_contents_view_aura.h

Comment 2 by dmazz...@chromium.org, May 25 2016

Labels: Merge-Request-52

Comment 3 by tin...@google.com, May 25 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/686c6734e8d7b277dc252be0b209ecc24b9a46e2

commit 686c6734e8d7b277dc252be0b209ecc24b9a46e2
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed May 25 22:08:27 2016

Merge to M52: Ensure LegacyRenderWidgetHostHWND is always created.

Previously, LegacyRenderWidgetHostHWND was only created inside
RenderWidgetHostViewAura::InternalSetBounds, and only if the parent
HWND was known. However, under some circumstances, InternalSetBounds
only gets called once and it gets called *before* the aura Window is
attached, so the legacy win never gets created.

Fix it by also trying to create the legacy win in
RWHVA::AddedToRootWindow().

BUG= 613336 

Review-Url: https://codereview.chromium.org/1996163002
Cr-Commit-Position: refs/heads/master@{#395649}
(cherry picked from commit a7e78f6f5d453c52313b74de10c5f680aa3d5ee3)

Review URL: https://codereview.chromium.org/2006053006 .

Cr-Commit-Position: refs/branch-heads/2743@{#61}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/686c6734e8d7b277dc252be0b209ecc24b9a46e2/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/686c6734e8d7b277dc252be0b209ecc24b9a46e2/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/686c6734e8d7b277dc252be0b209ecc24b9a46e2/content/browser/renderer_host/render_widget_host_view_aura.h
[modify] https://crrev.com/686c6734e8d7b277dc252be0b209ecc24b9a46e2/content/browser/web_contents/web_contents_view_aura.cc
[modify] https://crrev.com/686c6734e8d7b277dc252be0b209ecc24b9a46e2/content/browser/web_contents/web_contents_view_aura.h

Comment 5 by dmazz...@chromium.org, May 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment