New issue
Advanced search Search tips

Issue 613305 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 652374



Sign in to add a comment

Rename "Webkit Linux" -> WebKit Linux Precise"

Project Member Reported by qyears...@chromium.org, May 19 2016

Issue description

Reason: It's more specific; right now there's a bot named "WebKit Linux Trusty" (Ubuntu 14.04); it would be clearer to rename "WebKit Linux" to "WebKit Linux Precise" (Ubuntu 12.04).

This would mostly involve doing a search and replace through all parts of the infra build and chromium/src repos that have the literal string "WebKit Linux" referring to this builder.

https://code.google.com/p/chromium/codesearch#search/&q=%22WebKit%20Linux%22&m=100&det=none&sq=package:chromium&type=cs

TODO

- Update all 3 CLs to reference the other CLs
  - [x] https://codereview.chromium.org/2338293005
  - [x] https://codereview.chromium.org/2347293003
  - [ ] https://chromium-review.googlesource.com/386326
    - Can't find where to edit description on Geritt
- Figure out game plan for deploying this
  - Affected applications
    - Flakiness Dashboard
      - How does it get its list of master names?
  - Rebaseline-o-matic
- Create bug to make test master names more abstract
  - Via https://codereview.chromium.org/2347293003/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_test_expectations_unittest.py#newcode38
 
Is a simple search and replace CL enough or does this have to be coordinated with whomever controls/deploys the infrastructure?
This will basically be search and replace. But:
 - Other similarly named builders (e.g. WebKit Linux ASAN) should be changed at the same time.
 - This will require changes in both the build repo and the src repo.
 - After changing the build repo, we'll need to file an issue with the trooper for a master restart (https://chromium.googlesource.com/infra/infra/+/master/doc/users/contacting_troopers.md) since this will involve changing the master confg (https://cs.chromium.org/chromium/build/masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py).
 - The change to the src repo should be committed at about the same time as the master restart.
During this mass-renaming-of-things would it make sense to name it Blink Linux Precise? Or would that be too confusing?
That'd be too confusing in this case, I think.
CLs split up across 3 repos:

- https://codereview.chromium.org/2338293005
- https://codereview.chromium.org/2347293003
- https://chromium-review.googlesource.com/386326

(Does infra use a separate code review site?)
Yep, for infra they've switched to use Gerrit by default, since we're planning to switch over. If you have any issues with Gerrit you can fall back on using Rietveld for code review by uploading with `git cl upload --rietveld`.
Description: Show this description
Description: Show this description
Owner: jeffcarp@chromium.org
Status: Started (was: Unconfirmed)
(Sorry for the email spam)

Assigning myself to this issue. Also was trying to use the description as a TODO list, not sure if it's the best idea but trying it out.
Description: Show this description
Description: Show this description
Description: Show this description
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/801e0732bb06d042e62e1e9f0baa3bca8e00be6b

commit 801e0732bb06d042e62e1e9f0baa3bca8e00be6b
Author: jeffcarp <jeffcarp@chromium.org>
Date: Thu Sep 29 22:25:48 2016

Rename 'WebKit Linux' to 'WebKit Linux Precise' only in chromium.webkit master

Our game plan is to:

1. Land a CL to rename the chromium.webkit master (this one)
2. Land a CL to rename chromium.webkit slaves (https://crrev.com/2382723004)

BUG= 613305 

Review-Url: https://codereview.chromium.org/2382863002

[modify] https://crrev.com/801e0732bb06d042e62e1e9f0baa3bca8e00be6b/masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py
[modify] https://crrev.com/801e0732bb06d042e62e1e9f0baa3bca8e00be6b/masters/master.chromium.webkit/slaves.cfg

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/caf32bee7f928fa4743d71208671779f6d2b570f

commit caf32bee7f928fa4743d71208671779f6d2b570f
Author: jeffcarp <jeffcarp@chromium.org>
Date: Fri Sep 30 16:32:42 2016

Rename 'WebKit Linux' to 'WebKit Linux Precise' only on slaves

Our game plan is to:

1. Land a CL to rename the chromium.webkit master (https://crrev.com/2382863002)
2. Land a CL to rename chromium.webkit slaves (this one)

BUG= 613305 

Review-Url: https://codereview.chromium.org/2382723004

[modify] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/gatekeeper.json
[modify] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py
[modify] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipe_modules/chromium_tests/chromium_webkit.py
[modify] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipe_modules/chromium_tests/trybots.py
[modify] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json
[modify] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_chromium.json
[modify] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_webkit.json
[modify] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/chromium_webkit_warnings.json
[copy] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux_Precise___TraceWrappables.json
[rename] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux_Precise___WPTServe.json
[rename] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux_Precise_slimming_paint_v2_Dummy_Builder.json
[delete] https://crrev.com/9bd9b9870f47ea111a18d028386a9c1de3c96f76/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux___TraceWrappables.json
[rename] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Precise.json
[rename] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Precise_ASAN.json
[rename] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Precise_Leak.json
[rename] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Precise_MSAN.json
[rename] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Precise__dbg_.json
[modify] https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f/scripts/slave/recipes/chromium.py

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 30 2016

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/cebf629d36090380f9b10350c4bb29269d2a4b8b

commit cebf629d36090380f9b10350c4bb29269d2a4b8b
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 30 16:54:59 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/caf32bee7f928fa4743d71208671779f6d2b570f Rename 'WebKit Linux' to 'WebKit Linux Precise' only on slaves (jeffcarp@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 613305 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2379573007

[modify] https://crrev.com/cebf629d36090380f9b10350c4bb29269d2a4b8b/infra/config/recipes.cfg

Comment 17 by stip@chromium.org, Sep 30 2016

Issue 651871 has been merged into this issue.
Blocking: 652374
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 3 2016

Now the src changes are landed, and from https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise/builds/469 it looks like the latest builds are running correctly.
Status: Fixed (was: Started)
The rename is now completed and the builders with the new names are now building :-) The changes in the infra repo are optional but apparently unnecessary.

Sign in to add a comment