New issue
Advanced search Search tips

Issue 613281 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move payments URL class out of components/autofill/content

Project Member Reported by jdonnelly@chromium.org, May 19 2016

Issue description

The functions in components/autofill/content/browser/wallet/wallet_service_url.{h,cc} are in content because they reference switches::kReduceSecurityForTesting. However, with the removal of requestAutocomplete, the use of this switch is no longer required.

Move these functions into compenents/autofill/core. Then change all code to rely on them instead of their own copies of this data and logic. The code to update is components/autofill/core/browser/payments/payments_client.cc and the iOS settings.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65639ea0c7f964b96243603dec17ec449ec2ced4

commit 65639ea0c7f964b96243603dec17ec449ec2ced4
Author: jdonnelly <jdonnelly@chromium.org>
Date: Mon May 23 17:02:55 2016

Move the Google Payments URL functions out of content.

According to a comment in the code, switches::kReduceSecurityForTesting
(which is the only requirement for this class to be in content) was used
for requestAutocomplete testing. Now that requestAutocomplete has been
removed, these functions can be moved out of components/autofill/content
into components/autofill/core.

Also, remove the kWalletServiceUrl and kWalletSecureServiceUrl switches.
The former isn't referenced by any code and the while the latter is still
referenced, the only mention I can find for the use of that flag is in a
3 year old thread* that later goes on to specify a different set of
instructions that don't include the use of the flag.

Finally, make some progress on s/Wallet/Payments.

BUG= 613281 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1999923002
Cr-Commit-Position: refs/heads/master@{#395343}

[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/build/common.gypi
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/chrome/browser/resources/options/autofill_options_list.js
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/chrome/browser/ui/webui/options/autofill_options_handler.cc
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill.gypi
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/content/browser/BUILD.gn
[add] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/content/browser/payments/OWNERS
[rename] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/content/browser/payments/payments_client_unittest.cc
[delete] https://crrev.com/573ef22c87f5e505281b9478c9dba254bb103b5e/components/autofill/content/browser/wallet/OWNERS
[delete] https://crrev.com/573ef22c87f5e505281b9478c9dba254bb103b5e/components/autofill/content/browser/wallet/wallet_service_url.h
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/core/browser/payments/payments_client.h
[rename] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/core/browser/payments/payments_service_url.cc
[add] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/core/browser/payments/payments_service_url.h
[rename] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/core/browser/payments/payments_service_url_unittest.cc
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/core/common/autofill_switches.cc
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/autofill/core/common/autofill_switches.h
[modify] https://crrev.com/65639ea0c7f964b96243603dec17ec449ec2ced4/components/components_tests.gyp

Project Member

Comment 3 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/7aaa55e2b435672a9d27ab82a7a1ec1d0ed12323

commit 7aaa55e2b435672a9d27ab82a7a1ec1d0ed12323
Author: jdonnelly <jdonnelly@google.com>
Date: Fri May 27 23:14:19 2016

Status: Fixed (was: Started)

Sign in to add a comment