New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613279 link

Starred by 3 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Jun 2016
Cc:
█ tkonch...@chromium.org
bettes@chromium.org
█ shrike@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953
issue 615163
issue 615224



Sign in to add a comment

[Mac][MaterialDesign] Bookmarks Bar: The hover state in folder menus are 2pt on top & 2pt on bottom larger than the hover state on the Bar

Project Member Reported by meh...@chromium.org, May 19 2016 
Version: Build 394774
OS: OS X 10.11.5

What steps will reproduce the problem?
(1) Compare the hover state on the Bar with the hover state in the Folders

What is the expected output? What do you see instead?
The hover state in folder menus are 2pt on top & 1pt on bottom larger than the hover state on the Bar. Not sure if this is intended, but it would be nice if they were equal.

Screenshot is attached.

Thanks
Mehmet
Bildschirmfoto 2016-05-19 um 22.07.09.png
19.8 KB View Download

Comment 1 by shrike@chromium.org, May 19 2016

Cc: shrike@chromium.org
Owner: sgabr...@chromium.org
sgabriel@ - what is your thought on this?

Comment 2 by shrike@chromium.org, May 19 2016

Cc: bettes@chromium.org

Comment 3 by meh...@chromium.org, May 19 2016 

Sorry typo: ...2pt on on top & **2pt** on bottom larger than...

Comment 4 by meh...@chromium.org, May 19 2016 

I see the same on the chevron icon. Please see the screenshot. Thanks.
Bildschirmfoto 2016-05-19 um 22.22.48.png
21.3 KB View Download

Comment 5 by shrike@chromium.org, May 19 2016

Blocking: 547953

Comment 6 by sgabr...@chromium.org, May 20 2016 

All hover items should be 20pt tall. Chevron should be 20x20pt. Dropdown menu hover 20pt as well.

Comment 7 by sgabr...@chromium.org, May 20 2016 

Updated specs attached. 
As you'll see I updated the padding between the bookmark/bookmark groups to 4pt between their hover states boxes.
SPEC-core-ui-tap-feedback-bookmark-bar.png
136 KB View Download

Comment 8 by sgabr...@chromium.org, May 20 2016

Owner: shrike@chromium.org

Comment 9 by shrike@chromium.org, May 24 2016

Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dad117aa41824da2da9bf35b465c03de1ba23133

commit dad117aa41824da2da9bf35b465c03de1ba23133
Author: shrike <shrike@chromium.org>
Date: Thu May 26 16:32:30 2016

[Mac][Material Design] Bring bookmark hover state,  etc. up to spec.

This cl brings the bookmark hover state appearance in various places,
the padding between buttons, and the layout of folder buttons within
folder menus up to spec.

R=avi@chromium.org
BUG= 613279 

Review-Url: https://codereview.chromium.org/2013523005
Cr-Commit-Position: refs/heads/master@{#396195}

[modify] https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm
[modify] https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
[modify] https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
[modify] https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[modify] https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
[modify] https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[modify] https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133/chrome/browser/ui/cocoa/gradient_button_cell.mm
Project Member

Comment 11 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0729a712fa55766bdb45cf5f75818297f36a558

commit c0729a712fa55766bdb45cf5f75818297f36a558
Author: shrike <shrike@chromium.org>
Date: Thu May 26 20:59:39 2016

Revert of [Mac][Material Design] Bring bookmark hover state,  etc. up to spec. (patchset #1 id:1 of https://codereview.chromium.org/2013523005/ )

Reason for revert:
Regression in position of chevron button.

Original issue's description:
> [Mac][Material Design] Bring bookmark hover state,  etc. up to spec.
>
> This cl brings the bookmark hover state appearance in various places,
> the padding between buttons, and the layout of folder buttons within
> folder menus up to spec.
>
> R=avi@chromium.org
> BUG= 613279 
>
> Committed: https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133
> Cr-Commit-Position: refs/heads/master@{#396195}

TBR=avi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 613279 

Review-Url: https://codereview.chromium.org/2011173002
Cr-Commit-Position: refs/heads/master@{#396280}

[modify] https://crrev.com/c0729a712fa55766bdb45cf5f75818297f36a558/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/c0729a712fa55766bdb45cf5f75818297f36a558/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm
[modify] https://crrev.com/c0729a712fa55766bdb45cf5f75818297f36a558/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
[modify] https://crrev.com/c0729a712fa55766bdb45cf5f75818297f36a558/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
[modify] https://crrev.com/c0729a712fa55766bdb45cf5f75818297f36a558/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[modify] https://crrev.com/c0729a712fa55766bdb45cf5f75818297f36a558/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
[modify] https://crrev.com/c0729a712fa55766bdb45cf5f75818297f36a558/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[modify] https://crrev.com/c0729a712fa55766bdb45cf5f75818297f36a558/chrome/browser/ui/cocoa/gradient_button_cell.mm

Comment 12 by shrike@chromium.org, May 26 2016

Blocking: 615163

Comment 13 by shrike@chromium.org, May 26 2016

Blocking: 615224

Comment 14 by suherv...@gmail.com, May 28 2016 

suhervin5@gmail.com
Pada tanggal 27 Mei 2016 04.02, "bugdroid1@chromium.org via Monorail" <
monorail@chromium.org> menulis:
Project Member

Comment 15 by bugdroid1@chromium.org, May 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/384032da30351eb07a56b86e9dd38e316add54d6

commit 384032da30351eb07a56b86e9dd38e316add54d6
Author: shrike <shrike@chromium.org>
Date: Tue May 31 17:14:27 2016

[Mac][Material Design] Bring bookmark hover state,  etc. up to spec.

This cl brings the bookmark hover state appearance in various places,
the padding between buttons, and the layout of folder buttons within
folder menus up to spec.

R=avi@chromium.org
BUG= 613279 , 615224 , 615163 , 613086 

Committed: https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133
Cr-Commit-Position: refs/heads/master@{#396195}

Review-Url: https://codereview.chromium.org/2013523005
Cr-Commit-Position: refs/heads/master@{#396851}

[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/gradient_button_cell.mm
Project Member

Comment 16 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by shrike@chromium.org, Jun 2 2016

Labels: -M-53 -MovedFrom-52 Merge-Request-52 M-52

Comment 18 by tin...@google.com, Jun 2 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 19 by bugdroid1@chromium.org, Jun 2 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e06c09b0327766bbca9a09b375586fe89e9b9cd

commit 8e06c09b0327766bbca9a09b375586fe89e9b9cd
Author: Jayson Adams <shrike@chromium.org>
Date: Thu Jun 02 18:46:04 2016

[Mac][Material Design] Bring bookmark hover state,  etc. up to spec.

This cl brings the bookmark hover state appearance in various places,
the padding between buttons, and the layout of folder buttons within
folder menus up to spec.

R=avi@chromium.org
BUG= 613279 , 615224 , 615163 , 613086 

Committed: https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133
Cr-Commit-Position: refs/heads/master@{#396195}

Review-Url: https://codereview.chromium.org/2013523005
Cr-Commit-Position: refs/heads/master@{#396851}
(cherry picked from commit 384032da30351eb07a56b86e9dd38e316add54d6)

Review URL: https://codereview.chromium.org/2034813002 .

Cr-Commit-Position: refs/branch-heads/2743@{#195}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
[modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/gradient_button_cell.mm

Comment 20 by shrike@chromium.org, Jun 2 2016

Status: Fixed (was: Started)

Comment 21 by tkonch...@chromium.org, Jun 3 2016

Cc: tkonch...@chromium.org
Labels: TE-Verified-M53 TE-Verified-53.0.2757.0
Tested the same on mac 10.11 chrome version 53.0.2757.0	- Hover state appearance on the bookmark bar and in the folder remains look similar

Please find the screencast

Adding TE-Verified labels
613279.mov
9.8 MB Download

Comment 22 by tkonch...@chromium.org, Jun 8 2016

Labels: TE-Verified-52.0.2743.33 TE-Verified-M52
Tested the same on mac 10.11 chrome version 52.0.2743.33 with the flag #top-chrome-md enabled	- Hover state appearance on the bookmark bar and in the folder look similar.

Adding TE-Verified labels
►

Sign in to add a comment