New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613259 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

In Canary and Dev (M52), delay_tcp_race is not being defaulted to true

Project Member Reported by rtenneti@chromium.org, May 19 2016

Issue description

In Canary and Dev (M52), delay_tcp_race is not being defaulted to true if the delay_tcp_race option is not set. 

If there is no "delay_tcp_race" experiment, we should enable it by default. This was the reason why QUIC was loosing the race more often in Canary and Dev.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/977b13bbcc96e7dd1cf500909e29c677e8257776

commit 977b13bbcc96e7dd1cf500909e29c677e8257776
Author: rtenneti <rtenneti@chromium.org>
Date: Tue May 24 20:52:18 2016

QUIC - added disable_delay_tcp_race field trial param to disable
delaying of racing TCP connection.

When this param is set to true, TCP and QUIC connections will be raced
without any delay.

BUG= 613259 
R=rch@chromium.org

Review-Url: https://codereview.chromium.org/1998863002
Cr-Commit-Position: refs/heads/master@{#395688}

[modify] https://crrev.com/977b13bbcc96e7dd1cf500909e29c677e8257776/components/network_session_configurator/network_session_configurator.cc
[modify] https://crrev.com/977b13bbcc96e7dd1cf500909e29c677e8257776/components/network_session_configurator/network_session_configurator_unittest.cc

Comment 2 by suherv...@gmail.com, May 24 2016

25 Mei 2016 03.55, "bugdroid1@chromium.org via Monorail" <
monorail@chromium.org> menulis:
Labels: Merge-Request-52 M-52
The fix in Comment#1 gives the ability to run an experiment that disables TCP race. Missed the branch (was working on another crash bug). This change will give us the ability to turn off the QUIC experiment (if we find that the delay_tcp_race shouldn't be enabled by default via finch field trials).

This change is in Canary in 53.0.2748.0 (Branch Base Position: 395748) for 17 hours.

Comment 4 by tin...@google.com, May 25 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 5 by bugdroid1@chromium.org, May 26 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/556a3255a9a88105467c520cd8d54911a53b97bb

commit 556a3255a9a88105467c520cd8d54911a53b97bb
Author: Raman Tenneti <rtenneti@google.com>
Date: Thu May 26 00:35:27 2016

QUIC - added disable_delay_tcp_race field trial param to disable
delaying of racing TCP connection.

When this param is set to true, TCP and QUIC connections will be raced
without any delay.

BUG= 613259 
TBR=rch@chromium.org

Review-Url: https://codereview.chromium.org/1998863002/#ps20001
Cr-Commit-Position: refs/heads/master@{#395688}
(cherry picked from commit 977b13bbcc96e7dd1cf500909e29c677e8257776 Patch Set 2 of 1998863002)

Review URL: https://codereview.chromium.org/2009403002 .

Cr-Commit-Position: refs/branch-heads/2743@{#68}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/556a3255a9a88105467c520cd8d54911a53b97bb/chrome/browser/io_thread.cc
[modify] https://crrev.com/556a3255a9a88105467c520cd8d54911a53b97bb/chrome/browser/io_thread_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment