In Canary and Dev (M52), delay_tcp_race is not being defaulted to true |
|||||
Issue descriptionIn Canary and Dev (M52), delay_tcp_race is not being defaulted to true if the delay_tcp_race option is not set. If there is no "delay_tcp_race" experiment, we should enable it by default. This was the reason why QUIC was loosing the race more often in Canary and Dev.
,
May 24 2016
25 Mei 2016 03.55, "bugdroid1@chromium.org via Monorail" < monorail@chromium.org> menulis:
,
May 25 2016
The fix in Comment#1 gives the ability to run an experiment that disables TCP race. Missed the branch (was working on another crash bug). This change will give us the ability to turn off the QUIC experiment (if we find that the delay_tcp_race shouldn't be enabled by default via finch field trials). This change is in Canary in 53.0.2748.0 (Branch Base Position: 395748) for 17 hours.
,
May 25 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/556a3255a9a88105467c520cd8d54911a53b97bb commit 556a3255a9a88105467c520cd8d54911a53b97bb Author: Raman Tenneti <rtenneti@google.com> Date: Thu May 26 00:35:27 2016 QUIC - added disable_delay_tcp_race field trial param to disable delaying of racing TCP connection. When this param is set to true, TCP and QUIC connections will be raced without any delay. BUG= 613259 TBR=rch@chromium.org Review-Url: https://codereview.chromium.org/1998863002/#ps20001 Cr-Commit-Position: refs/heads/master@{#395688} (cherry picked from commit 977b13bbcc96e7dd1cf500909e29c677e8257776 Patch Set 2 of 1998863002) Review URL: https://codereview.chromium.org/2009403002 . Cr-Commit-Position: refs/branch-heads/2743@{#68} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/556a3255a9a88105467c520cd8d54911a53b97bb/chrome/browser/io_thread.cc [modify] https://crrev.com/556a3255a9a88105467c520cd8d54911a53b97bb/chrome/browser/io_thread_unittest.cc
,
May 26 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, May 24 2016