"WebViewContextMenuInteractiveTest.ContextMenuParamsAfterCSSTransforms" is flaky |
||||||||||
Issue description"WebViewContextMenuInteractiveTest.ContextMenuParamsAfterCSSTransforms" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUAsSBUZsYWtlIkVXZWJWaWV3Q29udGV4dE1lbnVJbnRlcmFjdGl2ZVRlc3QuQ29udGV4dE1lbnVQYXJhbXNBZnRlckNTU1RyYW5zZm9ybXMM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 19 2016
It looks like the test has been flaky for some time, so it's not clear what is the culprit. I'm going to disable it
,
May 19 2016
Disabling it seems right. I suspect it's a race condition because running locally I had no flakiness after 100 runs. Other tests in this suit related to plugins/popups are also disabled due to flakiness, suggesting the test methodology is at fault.
,
May 19 2016
CC'ing ekaramad@, since the test was introduced in https://codereview.chromium.org/1293963002.
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/241be47e4ee2818f923d0b9ff1f13b803492e681 commit 241be47e4ee2818f923d0b9ff1f13b803492e681 Author: spqchan <spqchan@chromium.org> Date: Thu May 19 21:14:17 2016 Disable flaky WebViewContextMenuInteractiveTest test on ChromeOS BUG=613258 TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/1992323002 Cr-Commit-Position: refs/heads/master@{#394862} [modify] https://crrev.com/241be47e4ee2818f923d0b9ff1f13b803492e681/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
,
May 19 2016
The initial problem addressed in https://codereview.chromium.org/1293963002 was that context menu was misplaced on a <webview> which has CSS transforms. The input path is routed as: Browser=>Renderer: App=>BrowserPlugin=>Browser=>Renderer: Guest. The issue is that ContextMenuParams's x and y coordinates are with respect to RenderView's origin. The <webview> is oblivious to such CSS transforms and when receives the input event, it will assume it is without any such transforms. Since we are not packing screen coordinates with the IPC's, or at least not in ContextMenuParams, there seems to be no way around the issue; unless we send the screen coords along. The underlying issue might need a fix anyway. But as for the flaky test, I think it has to do with GetViewBounds() on both guest and embedder RenderWidgetHostViews. They get updated during the mouse input journey and what the test predicts for the location does not match that of the guest's. I can take a look at this later.
,
May 20 2016
This is also failing on Linux: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/232616 This test should probably be disabled on all platforms, not just CrOS.
,
May 20 2016
This is failing almost (but not quite) all the time on the waterfall for Linux: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests
,
May 20 2016
Since no sheriff responded on IRC, I am disabling this myself: https://codereview.chromium.org/1995193002/
,
May 20 2016
I'm still confused about #1, #2, #3 blaming r394808 and then unblaming it. On the Linux trybots (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests) the test wasn't failing at all, and then suddenly after a CL in range r394807--r394810 (inclusive), it then failed 9 of the next 12 runs. So I'd say it's definitely r394808 that triggered this.
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5347830d726c6e4fc3d8ab125d2554be695d0e6e commit 5347830d726c6e4fc3d8ab125d2554be695d0e6e Author: mgiuca <mgiuca@chromium.org> Date: Fri May 20 03:50:38 2016 Disable test ContextMenuParamsAfterCSSTransforms on all platforms. WebViewContextMenuInteractiveTest.ContextMenuParamsAfterCSSTransforms was previously disabled on Chrome OS (r394862), but it has been found flaky on Linux as well. Disabling on all platforms. BUG=613258 TBR=sky@chromium.org Review-Url: https://codereview.chromium.org/1995193002 Cr-Commit-Position: refs/heads/master@{#394988} [modify] https://crrev.com/5347830d726c6e4fc3d8ab125d2554be695d0e6e/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
,
May 20 2016
,
May 20 2016
Detected 53 new flakes for test/step "WebViewContextMenuInteractiveTest.ContextMenuParamsAfterCSSTransforms". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUAsSBUZsYWtlIkVXZWJWaWV3Q29udGV4dE1lbnVJbnRlcmFjdGl2ZVRlc3QuQ29udGV4dE1lbnVQYXJhbXNBZnRlckNTU1RyYW5zZm9ybXMM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
May 23 2016
Removing from sheriff queue, since the test got disabled and has owners.
,
Jun 1 2016
WebViewContextMenuInteractiveTest.ContextMenuParamsAfterCSSTransforms failed on https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20ChromeOS%20Buildspec%20Tests. See https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/Linux%20ChromeOS%20Buildspec%20Tests/builds/693
,
Jun 15 2016
,
Jan 24 2018
,
Jan 24 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by spqc...@chromium.org
, May 19 2016