New issue
Advanced search Search tips

Issue 613255 link

Starred by 3 users

Issue metadata

Status: Duplicate
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

cvox2: options page shouldn't offer key binding for Next

Project Member Reported by dmazz...@chromium.org, May 19 2016

Issue description

ChromeVox Next doesn't let you rebind keys currently so we shouldn't offer it in the options page.

In general we should hide features that aren't part of ChromeVox Next and make it easy for users to see what mode they're in and switch modes.

 
Components: UI>Accessibility
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 9 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by dtseng@chromium.org, Oct 13 2016

Status: Duplicate (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c06fcef4ed344b4cafaf6888df51ca290e240af6

commit c06fcef4ed344b4cafaf6888df51ca290e240af6
Author: dtseng <dtseng@chromium.org>
Date: Thu Oct 20 22:57:37 2016

Make ChromeVox Next the default ChromeVox experience

- removes obsolete key configuration code from options; this leaves options as a simple, clean list of documentable settings
- change the tutorial url to point to the Next tutorial

Pending/Optional
- change the update notification to point to a release note (rather than the tutorial)

BUG= 613255 , 618097 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2410773003
Cr-Commit-Position: refs/heads/master@{#426632}

[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/chromeos/accessibility/speech_monitor.cc
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/c06fcef4ed344b4cafaf6888df51ca290e240af6/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9e01d4887910e1a5a385359fdd75f1ed3373fa5

commit f9e01d4887910e1a5a385359fdd75f1ed3373fa5
Author: pkasting <pkasting@chromium.org>
Date: Fri Oct 21 01:53:49 2016

Revert of Make ChromeVox Next the default ChromeVox experience (patchset #3 id:40001 of https://chromiumcodereview.appspot.com/2410773003/ )

Reason for revert:
Causing many interactive_ui_tests failures, see e.g. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/19184

Original issue's description:
> Make ChromeVox Next the default ChromeVox experience
>
> - removes obsolete key configuration code from options; this leaves options as a simple, clean list of documentable settings
> - change the tutorial url to point to the Next tutorial
>
> Pending/Optional
> - change the update notification to point to a release note (rather than the tutorial)
>
> BUG= 613255 , 618097 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=dmazzoni@chromium.org,achuith@chromium.org,dtseng@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 613255 , 618097 

Review-Url: https://chromiumcodereview.appspot.com/2438893004
Cr-Commit-Position: refs/heads/master@{#426685}

[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/chromeos/accessibility/speech_monitor.cc
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/resources/chromeos/chromevox/chromevox/background/prefs.js
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/f9e01d4887910e1a5a385359fdd75f1ed3373fa5/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js

Sign in to add a comment