New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613252 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router] Remove dependency on ExtensionActionRedesign field trial

Project Member Reported by imch...@chromium.org, May 19 2016

Issue description

ExtensionActionRedesign expires after M51. Also, the feature is already enabled by default. We should remove Media Router's FeatureSwitch's dependency on it.

This needs to be in M52.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9013e165f40d23f8fd28424f157fa4bb3805d018

commit 9013e165f40d23f8fd28424f157fa4bb3805d018
Author: imcheng <imcheng@chromium.org>
Date: Fri May 20 21:08:43 2016

[Media Router] Remove MR FeatureSwitch's dependency on EAR.

The ExtensionActionRedesign field trial	expires after M51, and the
feature is already enabled by default. We should remove MR's dependency
on it.

Also, remove media_router_with_cast_extension FeatureSwitch as it's no
longer used.

BUG= 613252 

Review-Url: https://codereview.chromium.org/1996123002
Cr-Commit-Position: refs/heads/master@{#395165}

[modify] https://crrev.com/9013e165f40d23f8fd28424f157fa4bb3805d018/chrome/common/extensions/feature_switch_unittest.cc
[modify] https://crrev.com/9013e165f40d23f8fd28424f157fa4bb3805d018/extensions/common/feature_switch.cc
[modify] https://crrev.com/9013e165f40d23f8fd28424f157fa4bb3805d018/extensions/common/feature_switch.h

Comment 2 by sko...@chromium.org, May 20 2016

This will need a merge, yes?
Yes, unless the branch hasn't been cut yet :)

Comment 4 by sko...@chromium.org, May 20 2016

Supposedly that was yesterday, but maybe we get lucky.  :)

Comment 5 by amp@chromium.org, May 23 2016

Looks like it didn't make it into 52. :(

$git tag --contains 9013e165f40d23f8fd28424f157fa4bb3805d018
53.0.2744.0
53.0.2744.1
53.0.2745.0
53.0.2745.1
53.0.2746.0
53.0.2746.1
Labels: Merge-Request-52

Comment 7 by tin...@google.com, May 23 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 8 by bugdroid1@chromium.org, May 23 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94f2c95daa02e03ce1aef6f572abae74a857e8f5

commit 94f2c95daa02e03ce1aef6f572abae74a857e8f5
Author: Derek Cheng <imcheng@chromium.org>
Date: Mon May 23 20:14:42 2016

[Media Router] Remove MR FeatureSwitch's dependency on EAR.

The ExtensionActionRedesign field trial	expires after M51, and the
feature is already enabled by default. We should remove MR's dependency
on it.

Also, remove media_router_with_cast_extension FeatureSwitch as it's no
longer used.

BUG= 613252 

Review-Url: https://codereview.chromium.org/1996123002
Cr-Commit-Position: refs/heads/master@{#395165}
(cherry picked from commit 9013e165f40d23f8fd28424f157fa4bb3805d018)

Review URL: https://codereview.chromium.org/1997423003 .

Cr-Commit-Position: refs/branch-heads/2743@{#16}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/94f2c95daa02e03ce1aef6f572abae74a857e8f5/chrome/common/extensions/feature_switch_unittest.cc
[modify] https://crrev.com/94f2c95daa02e03ce1aef6f572abae74a857e8f5/extensions/common/feature_switch.cc
[modify] https://crrev.com/94f2c95daa02e03ce1aef6f572abae74a857e8f5/extensions/common/feature_switch.h

Status: Fixed (was: Started)

Sign in to add a comment