The extension assumes it should send a URL. Media Router is split between referring to the help page string as a URL and help page ID. The message handler and WebUI refers to and handles this as a help page ID.

We should discuss how we want this to be handled; this may require some extension side changes too.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e68cd12ddd2fcc30c317c5725a5349ba0524be34

commit e68cd12ddd2fcc30c317c5725a5349ba0524be34
Author: apacible <apacible@chromium.org>
Date: Tue May 24 16:55:22 2016

[Media Router] Consistently refer to issue's learn more help page by ID.

When users click on "learn more" on an issue, there should be a new tab opened to the "learn more" link. Currently, some parts of Media Router assume that an Issue keeps track of a URL, whereas other places assume that it keeps track of the help page ID, which would later be concat'd to a help center URL prefix. This mismatch breaks the "learn more" link for any issues created in the extension.

This change makes Issues consistently refer to the help page ID.

Also fix presubmit warnings.

BUG= 613242 

Review-Url: https://codereview.chromium.org/1993373002
Cr-Commit-Position: refs/heads/master@{#395615}

[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/media/router/issue.cc
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/media/router/issue.h
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/media/router/issue_manager_unittest.cc
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/media/router/issue_unittest.cc
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/media/router/mojo/media_router_type_converters.cc
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/e68cd12ddd2fcc30c317c5725a5349ba0524be34/extensions/renderer/resources/media_router_bindings.js

Your change meets the bar and is auto-approved for M52 (branch: 2743)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b04f2be4168d4fece67a79a212e5b522a98ca0a

commit 5b04f2be4168d4fece67a79a212e5b522a98ca0a
Author: Jennifer Apacible <apacible@google.com>
Date: Thu May 26 17:45:25 2016

[Media Router] Consistently refer to issue's learn more help page by ID.

When users click on "learn more" on an issue, there should be a new tab opened to the "learn more" link. Currently, some parts of Media Router assume that an Issue keeps track of a URL, whereas other places assume that it keeps track of the help page ID, which would later be concat'd to a help center URL prefix. This mismatch breaks the "learn more" link for any issues created in the extension.

This change makes Issues consistently refer to the help page ID.

Also fix presubmit warnings.

BUG= 613242 

Review-Url: https://codereview.chromium.org/1993373002
Cr-Commit-Position: refs/heads/master@{#395615}
(cherry picked from commit e68cd12ddd2fcc30c317c5725a5349ba0524be34)

Review URL: https://codereview.chromium.org/2014903002 .

Cr-Commit-Position: refs/branch-heads/2743@{#79}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/media/router/issue.cc
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/media/router/issue.h
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/media/router/issue_manager_unittest.cc
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/media/router/issue_unittest.cc
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/media/router/mojo/media_router_type_converters.cc
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/ui/toolbar/media_router_action_unittest.cc
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/5b04f2be4168d4fece67a79a212e5b522a98ca0a/extensions/renderer/resources/media_router_bindings.js