cc: put background filters on the makeWithFilter() fast-path |
|||||
Issue description(Foreground) filters are being optimized to use Skia's SkImage::makeWithFilter() fast path: https://codereview.chromium.org/1959033002/. However, background filters use a separate sampler input in the cc shdaer and thus can't yet benefit from this optimization. As part of that patch, I've moved the legacy (non-optimized) code from ApplyImageFilter() to ApplyBackgroundFilters(), where they still create a destination SkSurface and call drawImage(). Fixing this will probably require adding a background_tex_tramsform uniform, so that the background texture input can be scaled and offset separately from the contents texture.
,
Jun 8 2016
Hi, are you planning to work on this bug? May be I could help you with that one - looks like an interesting change to try.
,
Jun 8 2016
You're welcome to give it a shot. I don't think anyone plans to work on it in the near future.
,
Jun 23 2016
Thanks, will try to upload the patch this or next week.
,
Jul 12 2016
Hi, plz check: https://codereview.chromium.org/2136003003/
,
Apr 5 2017
,
Apr 13 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 13 2018
senorblanco: Please triage this, or close it if it's obsolete.
,
May 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5db50711bfd255df9bb4715b21efa5581147216 commit c5db50711bfd255df9bb4715b21efa5581147216 Author: Vadim Petrov <lof84@yandex-team.ru> Date: Fri May 04 13:17:48 2018 Improve performance of background filters Part 1: Refactoring and improve background filters shaders. Bug: 613233 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I93c7ecf0933f6c7095bfc94d0d404097b6e1a384 Reviewed-on: https://chromium-review.googlesource.com/899350 Commit-Queue: Vadim Petrov <lof84@yandex-team.ru> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556036} [modify] https://crrev.com/c5db50711bfd255df9bb4715b21efa5581147216/cc/trees/layer_tree_host_pixeltest_masks.cc [modify] https://crrev.com/c5db50711bfd255df9bb4715b21efa5581147216/components/viz/service/display/gl_renderer.cc [modify] https://crrev.com/c5db50711bfd255df9bb4715b21efa5581147216/components/viz/service/display/shader.cc [add] https://crrev.com/c5db50711bfd255df9bb4715b21efa5581147216/components/viz/test/data/mask_of_background_filter_and_blend.png
,
Jan 4
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by senorblanco@chromium.org
, May 19 2016Labels: -Type-Bug OS-All Type-Feature