New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613232 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Devtools] Esc pressed while search response/preview

Project Member Reported by allada@chromium.org, May 19 2016

Issue description

When a search is being performed in network tab preview or response it should close the search dialog then if pressed again should close the selected request not both.
 

Comment 1 by allada@chromium.org, May 19 2016

Components: Platform>DevTools>Network

Comment 2 by allada@chromium.org, May 24 2016

Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c9c1f684d0376f3be57284da16ab5c70ba0ff9b

commit 2c9c1f684d0376f3be57284da16ab5c70ba0ff9b
Author: allada <allada@chromium.org>
Date: Fri May 27 02:43:35 2016

[Devtools] Esc closes searchview if focused and open

If ESC key is pressed while search input box is focused and open
it will now always close the search input box and stop propagation.

BUG= 613232 
R=lushnikov

Review-Url: https://codereview.chromium.org/2013473003
Cr-Commit-Position: refs/heads/master@{#396363}

[modify] https://crrev.com/2c9c1f684d0376f3be57284da16ab5c70ba0ff9b/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js

Comment 4 by allada@chromium.org, May 27 2016

Status: Fixed (was: Started)

Sign in to add a comment