New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613208 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 547953



Sign in to add a comment

[Mac][Material Design] Bookmarks Bar: Hover state disappears after clicking on a bookmark

Project Member Reported by meh...@chromium.org, May 19 2016

Issue description

Version: Chrome 52.0.2741.0 canary (64-bit)
OS: OS X 10.11.5

What steps will reproduce the problem?
(1) mouse over a bookmark on the Bookmarks Bar
(2) hover state appears on the bookmark
(3) click on it

What is the expected output? What do you see instead?
The hover state disappears. It shouldn't disappear (like when you click on the reload, back or forward button).

Thanks
Mehmet
 

Comment 1 by shrike@chromium.org, May 19 2016

Blocking: 547953

Comment 2 by meh...@chromium.org, May 27 2016

Just a note: I see, that the Chevron icon also loses its hover state after clicking on it. But I think, this is probably related to this bug report and will also be fixed when this bug report is fixed.
Bildschirmfoto 2016-05-20 um 15.06.24.png
41.2 KB View Download
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by shrike@chromium.org, Jun 23 2016

Status: WontFix (was: Assigned)
Seems to work OK when following the steps in # 1. This is with 53.0.2777.0 Canary.

Comment 5 by meh...@chromium.org, Jun 23 2016

Status: Assigned (was: WontFix)
I can still reproduce the issue with Chrome Version 53.0.2777.0 canary (64-bit).

The hover button disappears after the click. It should not disappear.

Can you please check again? 

A screencast is attached.

Thanks.
screencast.mov
311 KB Download

Comment 6 by shrike@chromium.org, Jun 23 2016

I misunderstood and thought the problem was with bookmark folders. But in # 2 you mention a problem with the overflow chevron - that works correctly for me.

Comment 7 by meh...@chromium.org, Jun 23 2016

There is still an issue with the chevron overflow. When you click 2-times on the chevron button, the hover never disappears.

Here is a screencast.
chevron_hover.mov
646 KB Download

Comment 8 by meh...@chromium.org, Jun 24 2016

shrike@: Should I file a separate report regarding the chevron issue mentioned in #7 or is it related to this one?

Thanks.

Comment 9 by shrike@chromium.org, Jun 25 2016

Hi mehmet@, if you could file a separate bug that would be great. I am unable to reproduce the problem in 53.0.2774.3.

Filed  issue 623291  regarding the chevron button.
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 9 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: spqc...@chromium.org
Components: UI>Browser>Bookmarks
+ spqchan@, since you are also looking into Bookmarks Bar issues atm. Thanks :-)
 Issue 643914  has been merged into this issue.
Cc: -spqc...@chromium.org shrike@chromium.org
Labels: M-55
Owner: spqc...@chromium.org
Hi spqchan@, would you please take a look at this one? Thank you.

Status: WontFix (was: Assigned)
Cannot reproduce. Please reopen if otherwise
Status: Assigned (was: WontFix)
Hello spqchan@: I still can reproduce it in latest Canary.

Please find attached a screencast: The hover state is missing after you are clicking on the Bookmark button. It should be there because the mouse cursor is still on it.

Thanks.
bookmark_button_hover_is_missing_after_pressed.mov
152 KB Download
Status: Started (was: Assigned)
Oh never mind, it looks like the bug is caused by that.
I agree that the hover state should be disabled here, but the button should show its pressed state. Is there a straightforward way to make that happen (I haven't picked through the code)?
Looking into that right now. 
Project Member

Comment 22 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3009675f23c9d898168e015c9bed2c9c6f27a099

commit 3009675f23c9d898168e015c9bed2c9c6f27a099
Author: spqchan <spqchan@chromium.org>
Date: Wed Dec 06 18:19:00 2017

[Mac] Fix for incorrect bookmark bar hover state

Currently if you click on an item in the bookmark
bar, the item will lose its highlight state.

This CL makes sure it retains it by updating the
highlight on a mouse up.

Testing:
Unit test BookmarkButtonTest.MouseUpAndDownHighlight

Bug:  613208 
Change-Id: I2a3063af49065d3e985f681f69b0978666455243
Reviewed-on: https://chromium-review.googlesource.com/804695
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522141}
[modify] https://crrev.com/3009675f23c9d898168e015c9bed2c9c6f27a099/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm
[modify] https://crrev.com/3009675f23c9d898168e015c9bed2c9c6f27a099/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm
[modify] https://crrev.com/3009675f23c9d898168e015c9bed2c9c6f27a099/chrome/browser/ui/cocoa/gradient_button_cell.h

Status: Fixed (was: Started)
Hello spqchan@,

Thank you for fixing this bug. I tested it in latest Snapshot 522144, which includes your CL but I still can reproduce the issue on my MacBook Air 11" Mid 2012 :-(

Should I wait until tomorrow's Canary and test it then again?

Please see the enclosed screencast.

Thanks.
screencast.mov
769 KB Download
Status: Started (was: Fixed)
Strange, I thought I fixed it. Thanks for pointing that out, I'll look at it again
I think this is fixed under MdRefresh. Please feel free to close this report. Thanks :)
Status: WontFix (was: Started)
Thanks mehmet :)

Sign in to add a comment