New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613202 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 547953



Sign in to add a comment

[Mac][Material Design] Bookmarks Bar: The "quick access info text" is not vertically aligned

Project Member Reported by meh...@chromium.org, May 19 2016

Issue description

Version: Chrome 52.0.2741.0 canary (64-bit)
OS: OS X 10.11.5

What steps will reproduce the problem?
(1) create a new profile or delete all bookmarks
(2) open a new window
(3) take a look at the Bookmarksbar

What is the expected output? What do you see instead?
The "quick access info text" is not vertically aligned with the Apps link text.

Please use labels and text to provide additional information.
A screenshot is attached.

Thanks,
Mehmet
 
Bildschirmfoto 2016-05-19 um 18.46.53.png
89.8 KB View Download

Comment 1 by shrike@chromium.org, May 19 2016

Blocking: 547953

Comment 2 by shrike@chromium.org, May 20 2016

Labels: -Type-Bug -Pri-2 ReleaseBlock-Stable Pri-1 Type-Bug-Regression

Comment 3 by shrike@chromium.org, May 20 2016

Cc: nyerramilli@chromium.org ashej...@chromium.org shrike@chromium.org
 Issue 613478  has been merged into this issue.
Still able to reproduce the issue on Mac 10.11.5 using latest M-52(52.0.2743.6).

Comment 5 by shrike@chromium.org, May 25 2016

The fix has not landed yet.

Comment 6 by shrike@chromium.org, May 25 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/207cf6c07dcd9e9ebcb518a38668e4a08e286d0c

commit 207cf6c07dcd9e9ebcb518a38668e4a08e286d0c
Author: shrike <shrike@chromium.org>
Date: Thu May 26 00:06:39 2016

[Mac][Material Design] Adjust location of Import Bookmarks textfield.

This change aligns the baselines of the Import Bookmarks text and book-
mark button text.

R=avi@chromium.org
BUG= 613202 

Review-Url: https://codereview.chromium.org/2006053005
Cr-Commit-Position: refs/heads/master@{#396050}

[modify] https://crrev.com/207cf6c07dcd9e9ebcb518a38668e4a08e286d0c/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Comment 8 by shrike@chromium.org, May 26 2016

Labels: Merge-Request-52

Comment 9 by tin...@google.com, May 26 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 10 by bugdroid1@chromium.org, May 26 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fc24f7d2f00fc1f5f2946da68930ca3d164f1f1

commit 0fc24f7d2f00fc1f5f2946da68930ca3d164f1f1
Author: Jayson Adams <shrike@chromium.org>
Date: Thu May 26 23:18:14 2016

[Mac][Material Design] Adjust location of Import Bookmarks textfield.

This change aligns the baselines of the Import Bookmarks text and book-
mark button text.

R=avi@chromium.org
BUG= 613202 

Review-Url: https://codereview.chromium.org/2006053005
Cr-Commit-Position: refs/heads/master@{#396050}
(cherry picked from commit 207cf6c07dcd9e9ebcb518a38668e4a08e286d0c)

Review URL: https://codereview.chromium.org/2020453002 .

Cr-Commit-Position: refs/branch-heads/2743@{#93}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/0fc24f7d2f00fc1f5f2946da68930ca3d164f1f1/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Status: Fixed (was: Started)
Labels: TE-Verified-M52 TE-Verified-52.0.2743.19
Verified the issue on Mac 10.11.5 using 52.0.2743.19 and its working fine.Please find the attached screen shot for the same.
613202_May_31.png
60.7 KB View Download

Sign in to add a comment