New issue
Advanced search Search tips

Issue 613183 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 613925
Owner:
Closed: Jun 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.9%-22% regression in tracing.tracing_with_debug_overhead at 394066:394108

Project Member Reported by majidvp@chromium.org, May 19 2016

Issue description

Note that this is happening only on Mac bots!

The regression range overlap with  https://crbug.com/613181  which is another mac specific regression but benchmarks are unrelated.
 
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -performance-sheriff Performance-Sheriff
Original bisect failed. Kicked off two more.
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jun 17 2016

Mergedinto: 613925
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Enable GPU Raster on OSX (patchset #4 id:140001 of https://codereview.chromium.org/1881053003/ )
Author  : wfh
Commit description:
  
Reason for revert:
Causing stability issues on OS X, please put behind a fieldtrial.

BUG=610544,608566,610971,609612

Original issue's description:
> This change enables GPU Raster on OSX.
>
> I've compiled a bit of benchmark data to support turning this on -
> https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo7ilx9KDB_nJnwpc/edit?usp=sharing
> Still filling in more data, but I'm pretty happy with the results so far. In
> a number of cases we have a performance win, and in most cases we have a power win.
>
> Checking this in now will give us a long canary period before the next branch
> point to catch any issues.
>
> BUG= 542959 
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel
>
> Committed: https://crrev.com/8325892c2efdef8cff86ba16e7569f8b424daeda
> Cr-Commit-Position: refs/heads/master@{#391655}

TBR=vmiura@chromium.org,piman@chromium.org,ericrk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 542959 , 610544, 608566, 610971, 609612

Review-Url: https://codereview.chromium.org/1984183002
Cr-Commit-Position: refs/heads/master@{#394096}
Commit  : 7f558620b78cc53d2a50d11b9d5bf94a229d2874
Date    : Tue May 17 11:01:38 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@394082  5841191  109568   5  good
chromium@394095  5886631  56195.8  5  good
chromium@394096  6599350  26660.5  5  bad    <--
chromium@394097  6471535  161047   5  bad
chromium@394098  6470289  127261   5  bad
chromium@394101  6484284  102390   5  bad
chromium@394107  6576540  134356   5  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 613183

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tracing.tracing_with_debug_overhead
Test Metric: Total trace size in bytes/Total trace size in bytes
Relative Change: 12.59%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2152
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009573256291795904


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5272359573913600

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Jun 18 2016


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Enable GPU Raster on OSX (patchset #4 id:140001 of https://codereview.chromium.org/1881053003/ )
Author  : wfh
Commit description:
  
Reason for revert:
Causing stability issues on OS X, please put behind a fieldtrial.

BUG=610544,608566,610971,609612

Original issue's description:
> This change enables GPU Raster on OSX.
>
> I've compiled a bit of benchmark data to support turning this on -
> https://docs.google.com/a/google.com/document/d/1RPEnillJOaOKW47t9DYuttQkvWDo7ilx9KDB_nJnwpc/edit?usp=sharing
> Still filling in more data, but I'm pretty happy with the results so far. In
> a number of cases we have a performance win, and in most cases we have a power win.
>
> Checking this in now will give us a long canary period before the next branch
> point to catch any issues.
>
> BUG= 542959 
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.blink:mac_blink_rel
>
> Committed: https://crrev.com/8325892c2efdef8cff86ba16e7569f8b424daeda
> Cr-Commit-Position: refs/heads/master@{#391655}

TBR=vmiura@chromium.org,piman@chromium.org,ericrk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 542959 , 610544, 608566, 610971, 609612

Review-Url: https://codereview.chromium.org/1984183002
Cr-Commit-Position: refs/heads/master@{#394096}
Commit  : 7f558620b78cc53d2a50d11b9d5bf94a229d2874
Date    : Tue May 17 11:01:38 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@394083  5203333  61972.4  5  good
chromium@394095  5278268  83764.5  5  good
chromium@394096  6064289  108498   5  bad    <--
chromium@394097  6028384  117014   5  bad
chromium@394098  5958281  67341.2  5  bad
chromium@394101  6085326  106041   5  bad
chromium@394107  6002484  128420   5  bad

Bisect job ran on: mac_hdd_perf_bisect
Bug ID: 613183

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tracing.tracing_with_debug_overhead
Test Metric: Total trace size in bytes/Total trace size in bytes
Relative Change: 15.36%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_hdd_perf_bisect/builds/589
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9009573274588498208


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5904450594537472

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment