New issue
Advanced search Search tips

Issue 613182 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

[CVox] Keyboard Explorer Improvements

Project Member Reported by lpalmaro@chromium.org, May 19 2016

Issue description

Version: 52.0.2734
ChromeVox classic and next 
OS: Chrome

Keyboard explorer - 3 improvements needed 

1. Any keys with duel meaning don't speak what the second function is. For example. the comma key says comma but not left caret. Here is a list of all the keys we should consider revising spoken labels for: 

Comma - change spoken label to comma or left caret 
Period -- change to period or right comma 
Forward slash - change to forward slash or question mark
Semicolon - change to semicolon or colon
Single quote - change to single quote or double quote 
Backslash - change to backslash or vertical line (not sure what that vertical line is called)
Grave accent - change to grave accent or tilde 
1 - change to 1 or exclamation point
2 - change to 2 or at 
3 - change to 3 or pound 
4 - change to 4 or dollar sign 
5 - change to 5 or percent sign
6 - change to 6 or caret 
7 - change to 7 or ampersand 
8 - change to 8 or asterisk 
9 - change to 9 or open parenthesis 
10 - change to 10 or close parenthesis 
Dash - change to dash or underscore 
Equal sign - change to equal sign or plus sign 

The alternative here is to make it so that when the user holds down shift and that given key, that it then reads the secondary key name. But, currently that doesn't work because pressing shift makes chromevox read "shift". 

2. Also, it's great that all the top row keys now have spoken labels. However, when I press them, they actually execute the given function, which can be confusing for the user since none of the other keys do that. Is there a way we can make these non-functional until the user exits this mode? 

3. When you load the keyboard explorer, a very lengthy URL is read aloud. Can we make it so that the page title is simply read instead? 




 
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccadbd282a6274b910922cb1a253315964576f5c

commit ccadbd282a6274b910922cb1a253315964576f5c
Author: dtseng <dtseng@chromium.org>
Date: Thu May 26 23:26:10 2016

Begin using ChromeVox Next to read tab and window titles.

By relying upon the automation tree to make tab and window created, and changed announcements, ChromeVox can compute output that takes into account eh focused node at the time.

This also takes care of legacy bugs related to tab switching cutting off tab title announcements.

Keystrokes impacted
alt+tab: the name the newly focused item, then the root web area, and finally the window gets read
ctrl+tab: similar to above, except window isn't included (diff of ancestry chains). This cleaned up some of the previous hacks to focus the root web area. Selection had been set to the tab node; now, ensure the selection target is a descendant of the focused node.
ctrl+1-0: same as above
cvox+o+o: no longer reads the url of the options page. This is because the page programmatically sets it at around load time. The tabs api handler logic reads out the tab using the url since it has nothing at creation time.

BUG= 613182 

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2008773002
Cr-Commit-Position: refs/heads/master@{#396314}

[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/browser/resources/chromeos/chromevox/testing/common.js
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/chrome/test/data/extensions/api_test/automation/tests/desktop/initial_focus.js
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/ui/views/accessibility/ax_widget_obj_wrapper.cc
[modify] https://crrev.com/ccadbd282a6274b910922cb1a253315964576f5c/ui/views/accessibility/ax_window_obj_wrapper.cc

Comment 2 by dtseng@chromium.org, Oct 11 2016

Status: fixed (was: Assigned)

Sign in to add a comment