Split Media.Controls.Show in two different UMA for audio/video |
||||||
Issue descriptionI should have think about this: audio with default controls is rare enough that it is likely changing significantly the values we get. I will deprecate Media.Controls.Show and create: - Media.Controls.Show.Audio - Media.Controls.Show.Video
,
May 23 2016
,
May 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c446293173e6c5d20ae437e0b83981907b911c9 commit 1c446293173e6c5d20ae437e0b83981907b911c9 Author: mlamouri <mlamouri@chromium.org> Date: Tue May 24 17:02:49 2016 Split Media.Controls.Show in .Video and .Audio. In order to differentiate metrics coming from audio elements versus coming from video elements. BUG= 613178 Review-Url: https://codereview.chromium.org/1990313002 Cr-Commit-Position: refs/heads/master@{#395618} [modify] https://crrev.com/1c446293173e6c5d20ae437e0b83981907b911c9/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp [modify] https://crrev.com/1c446293173e6c5d20ae437e0b83981907b911c9/third_party/WebKit/Source/core/html/HTMLMediaElement.h [modify] https://crrev.com/1c446293173e6c5d20ae437e0b83981907b911c9/tools/metrics/histograms/histograms.xml
,
May 26 2016
,
May 26 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 26 2016
Please have a the CL merged by EOD tomorrow (05/27), so it gets tested for dev channel scheduled on 06/02.
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba86a2fe16339c5323a2b3c4ac7066ddaf4e09eb commit ba86a2fe16339c5323a2b3c4ac7066ddaf4e09eb Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu May 26 23:44:17 2016 Split Media.Controls.Show in .Video and .Audio. In order to differentiate metrics coming from audio elements versus coming from video elements. BUG= 613178 Review-Url: https://codereview.chromium.org/1990313002 Cr-Commit-Position: refs/heads/master@{#395618} (cherry picked from commit 1c446293173e6c5d20ae437e0b83981907b911c9) Review URL: https://codereview.chromium.org/2018813002 . Cr-Commit-Position: refs/branch-heads/2743@{#94} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/ba86a2fe16339c5323a2b3c4ac7066ddaf4e09eb/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp [modify] https://crrev.com/ba86a2fe16339c5323a2b3c4ac7066ddaf4e09eb/third_party/WebKit/Source/core/html/HTMLMediaElement.h [modify] https://crrev.com/ba86a2fe16339c5323a2b3c4ac7066ddaf4e09eb/tools/metrics/histograms/histograms.xml
,
May 26 2016
Marking this as fixed but worth noting that we can still improve the metric. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mlamouri@chromium.org
, May 19 2016