[Chrome][M51][Android 6.0] Crash when trying to add "Bookmarks 3*2" widget to home screen
Reported by
seiyon.p...@gmail.com,
May 19 2016
|
||||||||
Issue descriptionSteps to reproduce the problem: 1. Precondition : Set partner bookmark 2. Touch and hold home screen to add widget 3. Touch "Bookmarks 3*2" widget and drag it to home screen What is the expected behavior? User can add "Bookmarks 3*2" widget to home screen What went wrong? Chrome crashes Crashed report ID: How much crashed? Whole browser Is it a problem with a plugin? No Did this work before? Yes 50.0.2661.89 Chrome version: 51.0.2704.10 Channel: beta OS Version: 6.0.1 Flash Version: Shockwave Flash 21.0 r0 According to log (Callstack.png), null pointer exception is thrown from loadFavicon method (Method loadFavicon.png). Because fromBookmarkItem method (Method fromBookmarkItem.png) returns null.
,
May 25 2016
Gentle reminder
,
May 30 2016
Gentle reminder
,
May 31 2016
Will fix this bug in M53. I escalated the priority. :) Thanks for the detailed logcat!
,
May 31 2016
,
May 31 2016
,
Jun 1 2016
CL in review. https://codereview.chromium.org/2031893002
,
Jun 2 2016
The crash is a regression in M51. How about adding a simple null check in loadBookmarks() to avoid the crash in M52?
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41dd21f931b7f87a57e97efe7d9930316ad7310a commit 41dd21f931b7f87a57e97efe7d9930316ad7310a Author: ianwen <ianwen@chromium.org> Date: Thu Jun 02 23:26:48 2016 [Android] Add support for Partner bookmarks to Chrome bookmark widget Before this CL, the current folder of the widget is stored as a long in the shared preferences. Now it will be stored as a String that can be serialized directly into a BookmarkId object. The advantage of storing strings is that it carries sufficient info about whether a bookmark is a partner bookmark. BUG= 613171 Review-Url: https://codereview.chromium.org/2031893002 Cr-Commit-Position: refs/heads/master@{#397539} [modify] https://crrev.com/41dd21f931b7f87a57e97efe7d9930316ad7310a/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java [add] https://crrev.com/41dd21f931b7f87a57e97efe7d9930316ad7310a/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/OWNERS
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5584e512972695b475753d0de3a1b84117a052bd commit 5584e512972695b475753d0de3a1b84117a052bd Author: Alex Mineer <amineer@chromium.org> Date: Thu Jun 02 23:31:33 2016 [Android] Add support for Partner bookmarks to Chrome bookmark widget Before this CL, the current folder of the widget is stored as a long in the shared preferences. Now it will be stored as a String that can be serialized directly into a BookmarkId object. The advantage of storing strings is that it carries sufficient info about whether a bookmark is a partner bookmark. BUG= 613171 (cherry picked from commit 41dd21f931b7f87a57e97efe7d9930316ad7310a) Review-Url: https://codereview.chromium.org/2031893002 Cr-Original-Commit-Position: refs/heads/master@{#397539} Cr-Commit-Position: refs/branch-heads/2704@{#695} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/5584e512972695b475753d0de3a1b84117a052bd/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java [add] https://crrev.com/5584e512972695b475753d0de3a1b84117a052bd/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/OWNERS
,
Jun 3 2016
Thanks for the input, guys. I landed the fix for M51, M52 and M53.
,
Jun 3 2016
Issue 615972 has been merged into this issue.
,
Jun 3 2016
This issue is verified as fixed on 51.0.2704.81 on S7 Edge T-Mobile / MMB29M. Will verify on other channels and close the bug soon.
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a93694b27f3711efa984b89b8b7b99167ba5cec commit 6a93694b27f3711efa984b89b8b7b99167ba5cec Author: Ian Wen <ianwen@google.com> Date: Fri Jun 03 17:31:03 2016 [Android] Add support for Partner bookmarks to Chrome bookmark widget Before this CL, the current folder of the widget is stored as a long in the shared preferences. Now it will be stored as a String that can be serialized directly into a BookmarkId object. The advantage of storing strings is that it carries sufficient info about whether a bookmark is a partner bookmark. BUG= 613171 Review-Url: https://codereview.chromium.org/2031893002 Cr-Commit-Position: refs/heads/master@{#397539} TBR=dfalcantara@chromium.org Review URL: https://codereview.chromium.org/2038893002 . Cr-Commit-Position: refs/branch-heads/2743@{#205} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/6a93694b27f3711efa984b89b8b7b99167ba5cec/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java [add] https://crrev.com/6a93694b27f3711efa984b89b8b7b99167ba5cec/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/OWNERS
,
Jun 7 2016
Verified this fix on 52.0.2743.32 on S5 ATT/LMY47X. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ppolise...@chromium.org
, May 19 2016Owner: ian...@chromium.org
Status: Assigned (was: Unconfirmed)