Issue metadata
Sign in to add a comment
|
22.3%-40.6% regression in blink_perf.css at 393773:393855 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 19 2016
=== Auto-CCing suspected CL author yukishiino@chromium.org === Hi yukishiino@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : bindings: Supports [SameObject] extended attribute. Author : yukishiino Commit description: Syntactically we've supported [SameObject] extended attribute, but we've not had any implementation for it. This CL stores the first returned value in the holder's private value, and returns it for the second time. BUG= 462913 Review-Url: https://codereview.chromium.org/1980553002 Cr-Commit-Position: refs/heads/master@{#393827} Commit : 40d19a73c02f0185e5a49c4761860762896dec28 Date : Mon May 16 13:47:14 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@393820 1117.95 3.19255 5 good chromium@393824 1146.39 6.2047 5 good chromium@393826 1141.93 10.7605 5 good chromium@393827 900.863 2.10832 5 bad <-- chromium@393828 902.323 2.00099 5 bad Bisect job ran on: android_nexus6_perf_bisect Bug ID: 613170 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.css Test Metric: CSSPropertyUpdateValue/CSSPropertyUpdateValue Relative Change: 19.29% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2192 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9012223915827382800 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=6369192786264064 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdd68c2f872ba56475500d80dcf02b1aeb97cbc4 commit fdd68c2f872ba56475500d80dcf02b1aeb97cbc4 Author: yukishiino <yukishiino@chromium.org> Date: Fri May 20 13:34:11 2016 Revert of bindings: Supports [SameObject] extended attribute. (patchset #2 id:20001 of https://codereview.chromium.org/1980553002/ ) Reason for revert: This CL hits terrible performance regressions. Original issue's description: > bindings: Supports [SameObject] extended attribute. > > Syntactically we've supported [SameObject] extended attribute, > but we've not had any implementation for it. > > This CL stores the first returned value in the holder's > private value, and returns it for the second time. > > BUG= 462913 > > Committed: https://crrev.com/40d19a73c02f0185e5a49c4761860762896dec28 > Cr-Commit-Position: refs/heads/master@{#393827} TBR=bashi@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 462913 , 613172 , 613170 Review-Url: https://codereview.chromium.org/2000643002 Cr-Commit-Position: refs/heads/master@{#395064} [modify] https://crrev.com/fdd68c2f872ba56475500d80dcf02b1aeb97cbc4/third_party/WebKit/LayoutTests/fast/dom/gc-9-expected.txt [modify] https://crrev.com/fdd68c2f872ba56475500d80dcf02b1aeb97cbc4/third_party/WebKit/Source/bindings/scripts/v8_attributes.py [modify] https://crrev.com/fdd68c2f872ba56475500d80dcf02b1aeb97cbc4/third_party/WebKit/Source/bindings/templates/attributes.cpp [modify] https://crrev.com/fdd68c2f872ba56475500d80dcf02b1aeb97cbc4/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp [modify] https://crrev.com/fdd68c2f872ba56475500d80dcf02b1aeb97cbc4/third_party/WebKit/Source/core/css/CSSImportRule.cpp [modify] https://crrev.com/fdd68c2f872ba56475500d80dcf02b1aeb97cbc4/third_party/WebKit/Source/core/css/CSSImportRule.idl
,
May 23 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by majidvp@chromium.org
, May 19 2016