New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613147 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 569685



Sign in to add a comment

Android restore should do nothing if the user was not signed in.

Project Member Reported by aber...@chromium.org, May 19 2016

Issue description

As discussed with ewald@, Android restore should only suppress the FRE if the user was previously signed in to an account that exists on the new device.
 

Comment 1 by ew...@chromium.org, May 19 2016

Given that this is occurring at device-setup time, it really would have to be that the user is restoring to the same account with which they were syncing on the old device, right?

Comment 2 by ew...@chromium.org, May 19 2016

Blocking: 569685

Comment 4 by ew...@chromium.org, Jun 1 2016

Labels: Merge-Request-52

Comment 5 by tin...@google.com, Jun 1 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/3d65aadfa547a44aa7d51a2f1b77882bc812af14

commit 3d65aadfa547a44aa7d51a2f1b77882bc812af14
Author: Anthony Berent <aberent@chromium.org>
Date: Fri May 20 17:05:23 2016

Project Member

Comment 7 by sheriffbot@chromium.org, Jun 5 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 7 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfdec1b37c51a44ac71730af24f881713d476a9c

commit bfdec1b37c51a44ac71730af24f881713d476a9c
Author: Anthony Berent <aberent@chromium.org>
Date: Tue Jun 07 10:16:26 2016

[Android backup] Restore nothing if signed in user isn't valid

If the user was previously not signed in, or if the account doesn't
exist on the new device, then restore nothing.

BUG= 613147 

Review-Url: https://codereview.chromium.org/1990233002
Cr-Commit-Position: refs/heads/master@{#397135}
(cherry picked from commit 074761b1a1d52efdccd1188841a821fb91249d9e)

Review URL: https://codereview.chromium.org/2047673002 .

Cr-Commit-Position: refs/branch-heads/2743@{#260}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/bfdec1b37c51a44ac71730af24f881713d476a9c/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/bfdec1b37c51a44ac71730af24f881713d476a9c/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackupAgent.java
[modify] https://crrev.com/bfdec1b37c51a44ac71730af24f881713d476a9c/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackupIntegrationTest.java
[modify] https://crrev.com/bfdec1b37c51a44ac71730af24f881713d476a9c/chrome/android/junit/src/org/chromium/chrome/browser/ChromeBackupAgentTest.java

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/f9960f42626f002ab2a55bfda934a02dac92b278

commit f9960f42626f002ab2a55bfda934a02dac92b278
Author: Anthony Berent <aberent@chromium.org>
Date: Fri May 20 17:05:23 2016

Labels: -Hotlist-Merge-Approved
Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 8 2016

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 15 2016

Sign in to add a comment