New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 613128 link

Starred by 3 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
hwi@chromium.org
nyerramilli@chromium.org
bettes@chromium.org
█ ashej...@chromium.org
█ shrike@chromium.org
sgabr...@chromium.org
█ rpop@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 547953



Sign in to add a comment

Regression: Favicon is not seen properly for internal page at bookmark bar in Incognito mode.

Reported by dmascare...@etouch.net, May 19 2016 
Chrome Version:52.0.2741.0 (Official Build) 19d105a2a1ec66924ff415f27ff170db7a67ba36-refs/heads/master@{#394609} 64 bit
OS: Mac (10.10.5, 10.11.4) , Mac Retina (10.11.4)

Pre-condition: Bookmark any chrome internal page like ‘chrome://settings/', chrome://chrome-urls/ etc.

What steps will reproduce the problem?
1. Launch chrome and open Incognito window.
2. Hover the mouse over bookmarked pages and observe.

Actual: Favicon is not visible on hovering mouse.
Expected: Favicon icon should be visible.

This is regression issue, broken in ‘M 52’ and will soon update the bisect info.

Note: Above issue is not seen on Windows and Linux Os.

Comment 1 by dmascare...@etouch.net, May 19 2016

Components: UI>Browser>Bookmarks
Labels: hasbisect
Owner: shrike@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/d195033a24b74413492685d93766932b64ad571e..27ceeaa6e172119ef8c1c7e21f0c61ea824d5e83?pretty=fuller&n=100

Suspecting: r394165 ?

Good build:52.0.2739.0
Bad build:52.0.2740.0
Actual.png
23.5 KB View Download

Comment 2 by ashej...@chromium.org, May 19 2016

Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable, as this is recent regression.

Thank you!

Comment 3 by shrike@chromium.org, May 19 2016

Blocking: 547953

Comment 4 by shrike@chromium.org, May 19 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f108ab948c53674428f0a5a518a48a2a6d6b5198

commit f108ab948c53674428f0a5a518a48a2a6d6b5198
Author: shrike <shrike@chromium.org>
Date: Thu May 19 20:45:03 2016

[Mac][Material Design] Show light default favicon in Incognito mode.

The original MD bookmarks cl did not update the default bookmark
favicon to Material Design.

R=avi@chromium.org
BUG= 613128 

Review-Url: https://codereview.chromium.org/1993313002
Cr-Commit-Position: refs/heads/master@{#394851}

[modify] https://crrev.com/f108ab948c53674428f0a5a518a48a2a6d6b5198/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h
[modify] https://crrev.com/f108ab948c53674428f0a5a518a48a2a6d6b5198/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
[modify] https://crrev.com/f108ab948c53674428f0a5a518a48a2a6d6b5198/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm

Comment 6 by shrike@chromium.org, May 19 2016

Status: Fixed (was: Started)

Comment 7 by shrike@chromium.org, May 22 2016

Cc: hwi@chromium.org rpop@chromium.org shrike@chromium.org sgabr...@chromium.org bettes@chromium.org
 Issue 613867  has been merged into this issue.
►

Sign in to add a comment