Issue metadata
Sign in to add a comment
|
Regression: Weird focus ring is seen on bookmark bar after pressing 'Tab' key.
Reported by
rk...@etouch.net,
May 19 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:52.0.2741.0 (Official Build) 19d105a2a1ec66924ff415f27ff170db7a67ba36-refs/heads/master@{#394609} 64 bit OS:Mac (10.10.5 , 10.11.4), Retina(10.11.4) What steps will reproduce the problem? 1. Launch chrome, open NTP and press Tab key upto bookmark bar. 2. Observe the focus ring on 'Apps' and bookmarks. Actual: Weird focus ring is seen for 'Apps' and bookmarks on bookmark bar . Expected: Focus ring should seen properly. This is regression issue,broken in ‘M 52’ and below is narrow bisect: Good build:52.0.2739.0 Bad build:52.0.2740.0 Narrow Bisect: https://chromium.googlesource.com/chromium/src/+log/d195033a24b74413492685d93766932b64ad571e..27ceeaa6e172119ef8c1c7e21f0c61ea824d5e83?pretty=fuller&n=100 Suspecting: r394165 ? Note: Above issue is not reproducible on Windows and Linux OS.
,
May 19 2016
Note - to reproduce, you have to have full keyboard access enabled (System Preferences, Keyboard pane, Shortcuts tab).
,
May 19 2016
,
May 24 2016
@shrike: Friendly Ping! Request you to please provide an update on the above issue? Appreciate your help. Thank you!
,
May 24 2016
Planning to look into this today.
,
May 31 2016
@shrike: Waiting for your update ? Thank you!
,
Jun 2 2016
,
Jun 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8e8a8f7a7fc3f66e0bc149602d8abac251b0304 commit b8e8a8f7a7fc3f66e0bc149602d8abac251b0304 Author: shrike <shrike@chromium.org> Date: Fri Jun 03 02:44:30 2016 [Mac][Material Design] Fix MD bookmarks button focus ring regression. After the Material Design changes to the bookmarks bar the focus rings no longer align with the button images. R=avi@chromium.org BUG= 613124 Review-Url: https://codereview.chromium.org/2030233003 Cr-Commit-Position: refs/heads/master@{#397598} [modify] https://crrev.com/b8e8a8f7a7fc3f66e0bc149602d8abac251b0304/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
,
Jun 7 2016
,
Jun 7 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
Jun 7 2016
Please merge your change to M52 branch asap, so that it will be picked up for next Beta release.
,
Jun 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d9ad2a378673abce3aacb2f3f7c5ff6068ea118 commit 8d9ad2a378673abce3aacb2f3f7c5ff6068ea118 Author: Jayson Adams <shrike@chromium.org> Date: Thu Jun 09 20:14:54 2016 [Mac][Material Design] Fix MD bookmarks button focus ring regression. After the Material Design changes to the bookmarks bar the focus rings no longer align with the button images. R=avi@chromium.org BUG= 613124 Review-Url: https://codereview.chromium.org/2030233003 Cr-Commit-Position: refs/heads/master@{#397598} (cherry picked from commit b8e8a8f7a7fc3f66e0bc149602d8abac251b0304) Review URL: https://codereview.chromium.org/2051973002 . Cr-Commit-Position: refs/branch-heads/2743@{#299} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/8d9ad2a378673abce3aacb2f3f7c5ff6068ea118/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
,
Jun 9 2016
Thank you Jayson for merging the fix in to M52 branch. Can you please mark the bug as "Fixed" ?
,
Jun 9 2016
,
Jun 10 2016
Rechecked the issue on chrome canary version 53.0.2764.0 for MAC 10.11.5. fix is working as intended. Focus ring is displayed fine. Attached screenshot for the same. Adding TE-Verified labels
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d9ad2a378673abce3aacb2f3f7c5ff6068ea118 commit 8d9ad2a378673abce3aacb2f3f7c5ff6068ea118 Author: Jayson Adams <shrike@chromium.org> Date: Thu Jun 09 20:14:54 2016 [Mac][Material Design] Fix MD bookmarks button focus ring regression. After the Material Design changes to the bookmarks bar the focus rings no longer align with the button images. R=avi@chromium.org BUG= 613124 Review-Url: https://codereview.chromium.org/2030233003 Cr-Commit-Position: refs/heads/master@{#397598} (cherry picked from commit b8e8a8f7a7fc3f66e0bc149602d8abac251b0304) Review URL: https://codereview.chromium.org/2051973002 . Cr-Commit-Position: refs/branch-heads/2743@{#299} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/8d9ad2a378673abce3aacb2f3f7c5ff6068ea118/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm
,
Jun 15 2016
Rechecked the issue on chrome beta version 52.0.2743.41 for MAC 10.11.5. Merged is working as intended. Focus ring is displayed fine. Attached screenshot for the same. Adding TE-Verified labels |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ashej...@chromium.org
, May 19 2016