New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613116 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

DexLoaderTest.testPreviouslyLoadedFromLocalDataDir flaky

Project Member Reported by peconn@chromium.org, May 19 2016

Issue description

Android Tests (dbg) failed on testPreviouslyLoadedFromLocalDataDir:

Failed build: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20(dbg)/builds/34429

Log:
[FAIL] org.chromium.webapk.shell_apk.DexLoaderTest#testPreviouslyLoadedFromLocalDataDir:
junit.framework.AssertionFailedError
	at org.chromium.webapk.shell_apk.DexLoaderTest.testPreviouslyLoadedFromLocalDataDir(DexLoaderTest.java:212)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

It seems to be passing most of the time though.
 

Comment 1 by peconn@chromium.org, May 19 2016

CL that added test: https://codereview.chromium.org/1981473002

Comment 4 by aelias@chromium.org, May 23 2016

Cc: pkotw...@chromium.org
Owner: aelias@chromium.org
Status: Assigned (was: Untriaged)
I'm going to disable.
Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4be351834826fa6bc3576f63c144b88d75ea49d9

commit 4be351834826fa6bc3576f63c144b88d75ea49d9
Author: aelias <aelias@chromium.org>
Date: Tue May 24 00:29:28 2016

Mark DexLoaderTest.testPreviouslyLoadedFromDataDir flaky.

This test has been 25% flaky since it was added last week in r394656.
(The other tests in the DexLoaderTest package are consistently green.)

TBR=pkotwicz
NOTRY=true
BUG= 613116 

Review-Url: https://codereview.chromium.org/2005073002
Cr-Commit-Position: refs/heads/master@{#395484}

[modify] https://crrev.com/4be351834826fa6bc3576f63c144b88d75ea49d9/chrome/android/webapk/shell_apk/BUILD.gn
[modify] https://crrev.com/4be351834826fa6bc3576f63c144b88d75ea49d9/chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java

Comment 6 by aelias@chromium.org, May 24 2016

Cc: aelias@chromium.org
Labels: -Pri-3 OS-Android Pri-2
Owner: pkotw...@chromium.org
Summary: DexLoaderTest.testPreviouslyLoadedFromLocalDataDir flaky (was: testPreviouslyLoadedFromLocalDataDir appears to be flaky)
Back to pkotwicz@ to track fixing and reenabling this.
Thanks for disabling this.
Project Member

Comment 8 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/498ec85734442ebbefca2874a934a5700e53e0aa

commit 498ec85734442ebbefca2874a934a5700e53e0aa
Author: pkotwicz <pkotwicz@chromium.org>
Date: Wed May 25 21:27:53 2016

Remove flaky assertion in DexLoaderTest#testPreviouslyLoadedFromLocalDataDir

Previously the test was checking whether canary.dex was being read - testing
the internal implementation of BaseDexClassLoader. It is possible that
BaseDexClassLoader reads the optimized version of canary.dex and not canary.dex

BUG= 613116 

Review-Url: https://codereview.chromium.org/2007553005
Cr-Commit-Position: refs/heads/master@{#395988}

[modify] https://crrev.com/498ec85734442ebbefca2874a934a5700e53e0aa/chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java

Status: Fixed (was: Assigned)
Pada tanggal 27 Mei 2016 02.44, "pkotwicz@chromium.org via Monorail" <
monorail@chromium.org> menulis:

Sign in to add a comment