New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613113 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Analyse BrotliFilter behavior

Project Member Reported by eustas@chromium.org, May 19 2016

Issue description

BrotliFilter.Status UMA's show that about 0.5% of requests finish with "In Progress" status and 0.05% with "Error" status.

The same data sliced by platform:

            | Windows | Android |
------------+---------+---------+
In progress |   0.57% |   0.29% |
Error       |   0.00% |   0.15% |
------------+---------+---------+
          Σ |   0.57% |   0.44% |

The sum for Windows and Android looks similar.

This makes me suspicious that it both results may have the same reason:
actual content has invalid (non-brotli) encoding.

To check this I plan to add additional UMA's: one will report if zlib header is detected, the other one will report brotli error code that will allow to understand at what point "corrupted" input is detected.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a2ee1339095755400f7249f6add4e97d29717c6

commit 5a2ee1339095755400f7249f6add4e97d29717c6
Author: eustas <eustas@chromium.org>
Date: Tue May 24 09:15:24 2016

TL;DR: adding "gzip-header-detected" and "brotli-error-code" UMA's

BrotliFilter.Status UMA's show that about 0.5% of requests finish with "In Progress" status and 0.05% with "Error" status.

The same data sliced by platform:

            | Windows | Android |
------------+---------+---------+
In progress |   0.57% |   0.29% |
Error       |   0.00% |   0.15% |
------------+---------+---------+
          Σ |   0.57% |   0.44% |

The sum for Windows and Android looks similar.

This makes me suspicious that it both results may have the same reason:
actual content has invalid (non-brotli) encoding.

To check this I plan to add additional UMA's: one will report if gzip header is detected, the other one will report brotli error code that will allow to understand at what point "corrupted" input is detected.

BUG=613113

Review-Url: https://codereview.chromium.org/1995513002
Cr-Commit-Position: refs/heads/master@{#395552}

[modify] https://crrev.com/5a2ee1339095755400f7249f6add4e97d29717c6/net/filter/brotli_filter.cc
[modify] https://crrev.com/5a2ee1339095755400f7249f6add4e97d29717c6/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 9 2016

Labels: -M-53 -Pri-1 M-54 MovedFrom-53 Pri-2
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by eustas@chromium.org, Feb 20 2017

            | Windows | Android |  OS X  |
------------+---------+---------+--------|
In progress |  0.069% |  0.193% | 0.067% |
Error       |  0.002% |  0.000% | 0.001% |
------------+---------+---------+--------|
          Σ |  0.071% |  0.193% | 0.067% |

Error rate on Android improved a lot. Overall "not-Done" rate is 10x lower nowadays. It seems that content producers / proxies has fixed their pipelines.

Comment 5 by eustas@chromium.org, Feb 20 2017

Labels: -Pri-2 -M-54 -MovedFrom-52 -MovedFrom-53 Pri-3

Sign in to add a comment