New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613108 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Search engine shortcuts get underscores at the end after sync

Project Member Reported by valbulescu@google.com, May 19 2016

Issue description

Chrome Version       : 50.0.2661.102 (64-bit)

What steps will reproduce the problem?
Set up 'g' as a shortcut to searching on Google (in Manage Search Engines). Google is also the default search engine.
I have Chrome synchronizing across two machines (a Linux workstation and my Macbook Pro).

What is the expected result?
'g' remains the shortcut (this is obviously not critical, but a workflow preference on my part).


What happens instead?
I come back to Chrome a while later, 'g' has become 'g_', and eventually 'g_____'. It seems to happen fairly consistently.

Looks like this is not a new issue, but it was considered fixed: https://bugs.chromium.org/p/chromium/issues/detail?id=99218

 
Cc: stevet@chromium.org
Components: Services>Sync
ccing  stevet to get more inputs on this issue as the similar kind of issue fixed by him.



Comment 2 by zea@chromium.org, May 24 2016

Owner: pnoland@chromium.org
Steve is no longer working on this project. We can look into this on the sync side though to figure out if it's similar to that old issue.

valbulescu, what account are you syncing with? Could we get your permission to inspect the server data?

Also, does this reliably reproduce? 
Labels: Needs-Feedback
Status: Assigned (was: Unconfirmed)
It applies to my valbulescu@google.com account. if it is required for the
investigation, feel free to look at the data.
Cc: -stevet@chromium.org
Can you confirm whether you have a default search engine set? i.e. Google is marked as (Default) in Manage Search Engines.
Google is the default search engine.
Labels: -Needs-Feedback
Looks related: https://bugs.chromium.org/p/chromium/issues/detail?id=443024

Comment 9 by suherv...@gmail.com, May 28 2016

Pada tanggal 27 Mei 2016 04.07, "valbulescu@google.com via Monorail" <
monorail@chromium.org> menulis:
On what day did you first set the shortcut to "g"?
To be honest, I don't recall. I've done it several times until I realised
it keeps getting clobbered. I could set it again and report back if you
think it would help with testing?
The exact day isn't that important. But was it before May 3rd? 
I've set it to 'g' both before and after May 3rd.
Project Member

Comment 14 by sheriffbot@chromium.org, Jun 2 2016

Labels: Hotlist-Google
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ec6ae8d86bc2badeb731ad4d85521d65aceae9c

commit 8ec6ae8d86bc2badeb731ad4d85521d65aceae9c
Author: pnoland <pnoland@chromium.org>
Date: Wed Jun 15 21:40:22 2016

[sync] Search engine shortcuts get underscores at the end after sync

Currently, search engines with matching prepopulate_id are treated as distinct if their keywords don't match. This can cause multiple copies of prepopulated search engines to be created; one copy with the original keyword and another copy with the modified keyword.

In the linked bug, the problematic behavior has created a different default search engine on each client. Deleting the non-default on client 1 is an attempt to delete client 2's default. There is sync code that assumes this was a mistake and resurrects the local default by appending an underscore.

This CL treats matching prepopulate_id as a conflict, and resolves it in favor of the remote search engine if the local engine isn't yet known to sync and was modified less recently. Note that this won't fix existing clients, whose duplicated engines will be known to sync already.

R=pkasting@chromium.org, zea@chromium.org

BUG= 613108 

Review-Url: https://codereview.chromium.org/2067723002
Cr-Commit-Position: refs/heads/master@{#400017}

[modify] https://crrev.com/8ec6ae8d86bc2badeb731ad4d85521d65aceae9c/chrome/browser/search_engines/template_url_service_sync_unittest.cc
[modify] https://crrev.com/8ec6ae8d86bc2badeb731ad4d85521d65aceae9c/components/search_engines/template_url_service.cc
[modify] https://crrev.com/8ec6ae8d86bc2badeb731ad4d85521d65aceae9c/components/search_engines/template_url_service.h

Status: Verified (was: Assigned)
I have verified in the latest chrome dev (53.0.2782.0)and not able to reproduce. Looks like this got fixed. closing the bug.

Sign in to add a comment