Issue metadata
Sign in to add a comment
|
Regression: Weird highlight of chevron icon is seen on Bookmark bar.
Reported by
dmascare...@etouch.net,
May 19 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:52.0.2741.0 (Official Build) 19d105a2a1ec66924ff415f27ff170db7a67ba36-refs/heads/master@{#394609} 64 bit OS:Mac (10.10.5 , 10.11.4) Pre-condition: 1. Bookmark 8-10 webpages. 2. Apply darker theme. What steps will reproduce the problem? 1. Launch chrome and resize the browser window such that chevron icon should be seen on bookmark. 2. Hover the mouse over chevron icon and then long click on it. 3. Observe the highlight. Actual: Weird highlight of chevron icon is seen (i.e. hover highlight is 1 pixel more then the click highlight) Expected: Highlight should be proper. This is regression issue,broken in ‘M 52’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/d195033a24b74413492685d93766932b64ad571e..27ceeaa6e172119ef8c1c7e21f0c61ea824d5e83?pretty=fuller&n=100 Suspecting: r394165 ? Good build:52.0.2739.0 Bad build:52.0.2740.0 Note:1. Above issue is not reproducible on Windows and Linux OS. 2. Above issue is not reproducible on Mac Retina(10.11.4)
,
May 19 2016
,
May 19 2016
,
May 24 2016
@shrike: Gentle Ping! Request you to please provide an update on the above issue? I really appreciate your help. Thank you!
,
May 24 2016
Planning to work on this today.
,
May 31 2016
@shrike: Waiting for your update ? Thank you!
,
May 31 2016
Landing the patch right now.
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/384032da30351eb07a56b86e9dd38e316add54d6 commit 384032da30351eb07a56b86e9dd38e316add54d6 Author: shrike <shrike@chromium.org> Date: Tue May 31 17:14:27 2016 [Mac][Material Design] Bring bookmark hover state, etc. up to spec. This cl brings the bookmark hover state appearance in various places, the padding between buttons, and the layout of folder buttons within folder menus up to spec. R=avi@chromium.org BUG= 613279 , 615224 , 615163 , 613086 Committed: https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133 Cr-Commit-Position: refs/heads/master@{#396195} Review-Url: https://codereview.chromium.org/2013523005 Cr-Commit-Position: refs/heads/master@{#396851} [modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm [modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm [modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h [modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm [modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm [modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm [modify] https://crrev.com/384032da30351eb07a56b86e9dd38e316add54d6/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Jun 1 2016
Looks like the issue is fixed. Unable to repro this issue on MAC (10.11.5) for Google Chrome Canary Version - 53.0.2753.0 Screen-recording is attached. @dmascarenhas: Could you please verify the same on Canary Version - 53.0.2753.0 and update the thread accordingly. Thank you.
,
Jun 1 2016
With response to comment #9: Above issue seems to be fixed on MAC (10.11.5,10.10.5) using Latest Canary version:53.0.2754.0 ab317e073bd7b2cb74c405f23008d0a6d4db6270-refs/heads/master@{#397000}
,
Jun 1 2016
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e06c09b0327766bbca9a09b375586fe89e9b9cd commit 8e06c09b0327766bbca9a09b375586fe89e9b9cd Author: Jayson Adams <shrike@chromium.org> Date: Thu Jun 02 18:46:04 2016 [Mac][Material Design] Bring bookmark hover state, etc. up to spec. This cl brings the bookmark hover state appearance in various places, the padding between buttons, and the layout of folder buttons within folder menus up to spec. R=avi@chromium.org BUG= 613279 , 615224 , 615163 , 613086 Committed: https://crrev.com/dad117aa41824da2da9bf35b465c03de1ba23133 Cr-Commit-Position: refs/heads/master@{#396195} Review-Url: https://codereview.chromium.org/2013523005 Cr-Commit-Position: refs/heads/master@{#396851} (cherry picked from commit 384032da30351eb07a56b86e9dd38e316add54d6) Review URL: https://codereview.chromium.org/2034813002 . Cr-Commit-Position: refs/branch-heads/2743@{#195} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell.mm [modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm [modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h [modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm [modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm [modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm [modify] https://crrev.com/8e06c09b0327766bbca9a09b375586fe89e9b9cd/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Jun 2 2016
,
Jun 8 2016
Tested the same on mac 10.11 chrome version 52.0.2743.33 - Highlight remains same on hovering and clicking the chevron icon. Fix works as expected |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ashej...@chromium.org
, May 19 2016