New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613082 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK from UTF16ToASCII from TemplateURLService::MergeDataAndStartSyncing

Project Member Reported by falken@chromium.org, May 19 2016

Issue description

Dev build around 52.0.2739.0, with DCHECK enabled.

When I start the browser I get:

[3536:3536:0519/152303:FATAL:utf_string_conversions.cc(227)] Check failed: IsStringASCII(utf16). 辞書
#0 0x7f8262c5c92e base::debug::StackTrace::StackTrace()
#1 0x7f8262c7d00b logging::LogMessage::~LogMessage()
#2 0x7f8262ccaaf3 base::UTF16ToASCII()
#3 0x7f8264b01c06 TemplateURLService::MergeDataAndStartSyncing()
#4 0x7f8264b0243d TemplateURLService::MergeDataAndStartSyncing()
#5 0x7f8263afa051 sync_driver::UIDataTypeController::Associate()
#6 0x7f8262c5db39 base::debug::TaskAnnotator::RunTask()
#7 0x7f8262c87755 base::MessageLoop::RunTask()
#8 0x7f8262c87a88 base::MessageLoop::DeferOrRunPendingTask()
#9 0x7f8262c87e1b base::MessageLoop::DoWork()
#10 0x7f8262c89fba base::(anonymous namespace)::WorkSourceDispatch()
#11 0x7f825cb13e04 g_main_context_dispatch
#12 0x7f825cb14048 <unknown>
#13 0x7f825cb140ec g_main_context_iteration
#14 0x7f8262c89d06 base::MessagePumpGlib::Run()
#15 0x7f8262c87281 base::MessageLoop::RunHandler()
#16 0x7f8262cb6910 base::RunLoop::Run()
#17 0x7f826350c4ca ChromeBrowserMainParts::MainMessageLoopRun()
#18 0x7f82606389d9 content::BrowserMainLoop::RunMainMessageLoopParts()
#19 0x7f826063bc98 content::BrowserMainRunnerImpl::Run()
#20 0x7f826063420c content::BrowserMain()
#21 0x7f8260fda1db content::RunNamedProcessTypeMain()
#22 0x7f8260fdac53 content::ContentMainRunnerImpl::Run()
#23 0x7f8260fd9530 content::ContentMain()
#24 0x7f82634c4d8b ChromeMain
#25 0x7f8259ce6ec5 __libc_start_main
#26 0x7f82634c4c5d <unknown>

Note: "辞書" is "dictionary". Chrome is in English UI. If I disable the DCHECK browser starts up and later on I eventually get:
[5137:5176:0519/152811:ERROR:typed_url_syncable_service.cc(800)] Could not load visits for url: https://code.google.com/p/chromium/issues/list

Not sure if that's related.

 
Supported for all
Owner: pnoland@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/122369ab8e771215d1afca236a20d16002c5000b

commit 122369ab8e771215d1afca236a20d16002c5000b
Author: pnoland <pnoland@chromium.org>
Date: Tue May 31 18:43:31 2016

[sync] DCHECK from UTF16ToASCII from TemplateURLService
LogDuplicatesHistogram erroneously assumes that all keywords are ASCII.
This CL removes that assumption and adds a test for the crash.

R=pkasting@chromium.org

BUG= 613082 

Review-Url: https://codereview.chromium.org/2016463003
Cr-Commit-Position: refs/heads/master@{#396876}

[modify] https://crrev.com/122369ab8e771215d1afca236a20d16002c5000b/chrome/browser/search_engines/template_url_service_sync_unittest.cc
[modify] https://crrev.com/122369ab8e771215d1afca236a20d16002c5000b/components/search_engines/template_url_service.cc

Status: Fixed (was: Assigned)

Sign in to add a comment