New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 613033 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Create BUILD.gn files for each directory in //media

Project Member Reported by jrumm...@chromium.org, May 19 2016

Issue description

The media/BUILD.gn file for component("media") includes references to files in media/cdm, media/filters, media/formats, etc. These directories should have their own BUILD.gn file and component("media") should just depend on them.

This may require some moving of files, or other changes. Some dependencies that currently exist:

media/formats files that reference media/filters:
  media/formats/mp4/avc.cc
  media/formats/webm/webm_cluster_parser.cc

media/filters files that reference media/formats:
  media/filters/ffmpeg_demuxer.cc
  media/filters/ffmpeg_h264_to_annex_b_bitstream_converter.cc
  media/filters/gpu_video_decoder.cc
  media/filters/h264_to_annex_b_bitstream_converter.cc
  media/filters/stream_parser_factory.cc
 
Owner: jrumm...@chromium.org
Status: Assigned (was: Untriaged)
give to john in order to remove out of untriaged group.
John, let me know if you need me create individual bugs for each area owner create BUILD.gn file for these directories.
I have created a patch for it. https://codereview.chromium.org/2872853003
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cf16502586c8e7c6ba9e9293bda196c04ac4b0e

commit 1cf16502586c8e7c6ba9e9293bda196c04ac4b0e
Author: a.suchit <a.suchit@samsung.com>
Date: Wed May 24 02:27:50 2017

Create BUILD.gn files for //media/formats.

Create new BUILD.gn files for media/formats and moved respective
media component changes from media/BUILD.gn file to new BUILD.gn
files.

BUG= 613033 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2872853003
Cr-Commit-Position: refs/heads/master@{#474130}

[modify] https://crrev.com/1cf16502586c8e7c6ba9e9293bda196c04ac4b0e/media/BUILD.gn
[modify] https://crrev.com/1cf16502586c8e7c6ba9e9293bda196c04ac4b0e/media/base/BUILD.gn
[add] https://crrev.com/1cf16502586c8e7c6ba9e9293bda196c04ac4b0e/media/formats/BUILD.gn

Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0fc11f9713bc1e54f94a2f23690cfc565f73ea0

commit b0fc11f9713bc1e54f94a2f23690cfc565f73ea0
Author: a.suchit <a.suchit@samsung.com>
Date: Thu May 25 19:15:57 2017

Created new target unit_tests in //media/formats.

Created unit_tests target in //media/formats/BUILD.gn and moved the
respective unit_test changes from //media/BUILD.gn to
//media/formats/BUILD.gn.

BUG= 613033 

R=jrummell@chromium.org, xhwang@chromium.org

Review-Url: https://codereview.chromium.org/2888523002
Cr-Commit-Position: refs/heads/master@{#474743}

[modify] https://crrev.com/b0fc11f9713bc1e54f94a2f23690cfc565f73ea0/media/BUILD.gn
[modify] https://crrev.com/b0fc11f9713bc1e54f94a2f23690cfc565f73ea0/media/formats/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4492feec756684e4873073648fa3504f41a20b6

commit f4492feec756684e4873073648fa3504f41a20b6
Author: a.suchit <a.suchit@samsung.com>
Date: Wed Jun 14 04:15:28 2017

Create BUILD.gn files for //media/filters.

Create new BUILD.gn file for media/filters and moved respective
media component changes from media/BUILD.gn file to new BUILD.gn
file.

BUG= 613033 

R=dalecurtis@chromium.org

Review-Url: https://codereview.chromium.org/2911643002
Cr-Commit-Position: refs/heads/master@{#479280}

[modify] https://crrev.com/f4492feec756684e4873073648fa3504f41a20b6/media/BUILD.gn
[modify] https://crrev.com/f4492feec756684e4873073648fa3504f41a20b6/media/base/BUILD.gn
[modify] https://crrev.com/f4492feec756684e4873073648fa3504f41a20b6/media/base/mac/BUILD.gn
[add] https://crrev.com/f4492feec756684e4873073648fa3504f41a20b6/media/filters/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54527a18f625f91ae7cc6a00eae26102323e38a9

commit 54527a18f625f91ae7cc6a00eae26102323e38a9
Author: grunell <grunell@chromium.org>
Date: Wed Jun 14 08:53:36 2017

Revert of Create BUILD.gn files for //media/filters. (patchset #13 id:240001 of https://codereview.chromium.org/2911643002/ )

Reason for revert:
Speculative revert to see if it caused the failure on https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29 (I'll re-land if it didn't.)

Original issue's description:
> Create BUILD.gn files for //media/filters.
>
> Create new BUILD.gn file for media/filters and moved respective
> media component changes from media/BUILD.gn file to new BUILD.gn
> file.
>
> BUG= 613033 
>
> R=dalecurtis@chromium.org
>
> Review-Url: https://codereview.chromium.org/2911643002
> Cr-Commit-Position: refs/heads/master@{#479280}
> Committed: https://chromium.googlesource.com/chromium/src/+/f4492feec756684e4873073648fa3504f41a20b6

TBR=mlamouri@chromium.org,a.suchit@chromium.org,dalecurtis@chromium.org,phajdan@google.com,a.suchit@samsung.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 613033 

Review-Url: https://codereview.chromium.org/2937913002
Cr-Commit-Position: refs/heads/master@{#479330}

[modify] https://crrev.com/54527a18f625f91ae7cc6a00eae26102323e38a9/media/BUILD.gn
[modify] https://crrev.com/54527a18f625f91ae7cc6a00eae26102323e38a9/media/base/BUILD.gn
[modify] https://crrev.com/54527a18f625f91ae7cc6a00eae26102323e38a9/media/base/mac/BUILD.gn
[delete] https://crrev.com/e2d1d93c5b61ce06be4b0620b7e40429365e3582/media/filters/BUILD.gn

Cc: a.suchit@chromium.org a.suc...@samsung.com
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/817eaa785afc8487e82ebd476c6461a53b3c4ea7

commit 817eaa785afc8487e82ebd476c6461a53b3c4ea7
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Jun 28 02:55:28 2017

Fix dependencies for macOS media/ code.

Root BUILD.gn doesn't need these libs, only the places where the
code is actually called should get these libs.

BUG= 613033 
TEST=try bots

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2426a26551382f92feea3675bf78c35b666ceeaa
Reviewed-on: https://chromium-review.googlesource.com/550961
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482862}
[modify] https://crrev.com/817eaa785afc8487e82ebd476c6461a53b3c4ea7/media/BUILD.gn
[modify] https://crrev.com/817eaa785afc8487e82ebd476c6461a53b3c4ea7/media/audio/BUILD.gn
[modify] https://crrev.com/817eaa785afc8487e82ebd476c6461a53b3c4ea7/media/base/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29af7c299ff70e3e2d203dd715af412dbcb87689

commit 29af7c299ff70e3e2d203dd715af412dbcb87689
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Thu Jun 29 22:34:31 2017

Create BUILD.gn files for //media/filters.

Create new BUILD.gn file for media/filters and moved respective
media component changes from media/BUILD.gn file to new BUILD.gn
file.

BUG= 613033 

R=dalecurtis@chromium.org, mlamouri@chromium.org

Change-Id: Ic9558a89625209fe2fd584ce9c929f88565d8c75
Reviewed-on: https://chromium-review.googlesource.com/532694
Commit-Queue: Suchit Agrawal <a.suchit@samsung.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483522}
[modify] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/chrome/utility/extensions/extensions_handler.cc
[modify] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/chrome/utility/media_galleries/media_metadata_parser.cc
[modify] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/media/BUILD.gn
[modify] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/media/base/BUILD.gn
[add] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/media/filters/BUILD.gn
[rename] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/media/filters/audio_video_metadata_extractor.cc
[rename] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/media/filters/audio_video_metadata_extractor.h
[rename] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/media/filters/audio_video_metadata_extractor_unittest.cc
[rename] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/media/filters/media_file_checker.cc
[rename] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/media/filters/media_file_checker.h
[rename] https://crrev.com/29af7c299ff70e3e2d203dd715af412dbcb87689/media/filters/media_file_checker_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c848f01ca9008e1a63c477df8980857eece1183

commit 7c848f01ca9008e1a63c477df8980857eece1183
Author: paulmiller <paulmiller@chromium.org>
Date: Fri Jun 30 03:07:57 2017

Revert of Created new target unit_tests in //media/formats. (patchset #4 id:60001 of https://codereview.chromium.org/2888523002/ )

Reason for revert:
broke official builds: https://crbug.com/737857 tried to fix here: https://codereview.chromium.org/2966573002/ but that's turning out to be complicated

Original issue's description:
> Created new target unit_tests in //media/formats.
>
> Created unit_tests target in //media/formats/BUILD.gn and moved the
> respective unit_test changes from //media/BUILD.gn to
> //media/formats/BUILD.gn.
>
> BUG= 613033 
>
> R=jrummell@chromium.org, xhwang@chromium.org
>
> Review-Url: https://codereview.chromium.org/2888523002
> Cr-Commit-Position: refs/heads/master@{#474743}
> Committed: https://chromium.googlesource.com/chromium/src/+/b0fc11f9713bc1e54f94a2f23690cfc565f73ea0

TBR=dalecurtis@chromium.org,a.suchit@chromium.org,jrummell@chromium.org,xhwang@chromium.org,a.suchit@samsung.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 613033 

Review-Url: https://codereview.chromium.org/2967543004
Cr-Commit-Position: refs/heads/master@{#483610}

[modify] https://crrev.com/7c848f01ca9008e1a63c477df8980857eece1183/media/BUILD.gn
[modify] https://crrev.com/7c848f01ca9008e1a63c477df8980857eece1183/media/formats/BUILD.gn

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/611b35e0bbf518c76733783f0d21c48c3b298f51

commit 611b35e0bbf518c76733783f0d21c48c3b298f51
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Thu Jul 06 08:21:54 2017

Create BUILD.gn files for //media/cdm.

Create new BUILD.gn file for media/cdm and moved respective
media component changes from media/BUILD.gn file to new BUILD.gn
file.

BUG= 613033 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I33e0119d29defaa93bd9fcb0143f65ea1a410d96
Reviewed-on: https://chromium-review.googlesource.com/558304
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484495}
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/chrome/browser/BUILD.gn
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/chrome/common/BUILD.gn
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/chrome/test/BUILD.gn
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/media/BUILD.gn
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/media/base/BUILD.gn
[add] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/media/cdm/BUILD.gn
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/media/cdm/ppapi/BUILD.gn
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/media/cdm/ppapi/ppapi_cdm_adapter.gni
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/media/filters/BUILD.gn
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/media/gpu/BUILD.gn
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/media/mojo/BUILD.gn
[modify] https://crrev.com/611b35e0bbf518c76733783f0d21c48c3b298f51/media/mojo/services/BUILD.gn

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/967b256250d1e7777ca458aa062ded48628c370d

commit 967b256250d1e7777ca458aa062ded48628c370d
Author: Alexander Potapenko <glider@chromium.org>
Date: Thu Jul 06 10:48:26 2017

Revert "Create BUILD.gn files for //media/cdm."

This reverts commit 611b35e0bbf518c76733783f0d21c48c3b298f51.

Reason for revert: broke generate_build_files step on two builders, see https://bugs.chromium.org/p/chromium/issues/detail?id=739673

Original change's description:
> Create BUILD.gn files for //media/cdm.
> 
> Create new BUILD.gn file for media/cdm and moved respective
> media component changes from media/BUILD.gn file to new BUILD.gn
> file.
> 
> BUG= 613033 
> 
> Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I33e0119d29defaa93bd9fcb0143f65ea1a410d96
> Reviewed-on: https://chromium-review.googlesource.com/558304
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#484495}

TBR=dalecurtis@chromium.org,xhwang@chromium.org,a.suchit@chromium.org,a.suchit@samsung.com

Change-Id: I7b9ffb4ad763ac9fb62b40177b554ced43a82bb0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  613033 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/561318
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484535}
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/chrome/browser/BUILD.gn
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/chrome/common/BUILD.gn
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/chrome/test/BUILD.gn
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/media/BUILD.gn
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/media/base/BUILD.gn
[delete] https://crrev.com/9a9f85e93556227001f76c170e1c54b073cb7955/media/cdm/BUILD.gn
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/media/cdm/ppapi/BUILD.gn
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/media/cdm/ppapi/ppapi_cdm_adapter.gni
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/media/filters/BUILD.gn
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/media/gpu/BUILD.gn
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/media/mojo/BUILD.gn
[modify] https://crrev.com/967b256250d1e7777ca458aa062ded48628c370d/media/mojo/services/BUILD.gn

Status: Started (was: Assigned)
Cc: dpranke@chromium.org
Hmm, we need to find some way to force a clobber build for these CLs, they're getting reverted too much.

cc: dpranke to see if there's a way to force CQ to do a clean build. tl;dr: we're having trouble landing build file refactorings since CQ bots keep missing errors due to cached build results.
I do not know if some more problems would come in this patch or not but this time, it was my mistake. I missed one place to change the dependent target. Which was under one flag (enable_cdm_host_verification) and it seems, default bots are not enabled enable_cdm_host_verification so we could not find it out before land the patch.
You're not supposed to ever need to do a clobber, and I'm not sure what you mean by "CQ bots keep missing errors due to cached build results", but it sounds like there are bugs there somewhere that need to be fixed.

For example, in the linked bug (739673), that looks like a real failure; you removed //media:cdm_paths but didn't remove the reference to it in //content/common . I think that probably got through the CQ because we don't have any is_chrome_branded bots in the CQ and so that build configuration wouldn't have been tested.
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33aa4027589f0e506549501cd5bda0fffdf62476

commit 33aa4027589f0e506549501cd5bda0fffdf62476
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Wed Jul 12 04:13:41 2017

Create BUILD.gn files for //media/cdm.

Create new BUILD.gn file for media/cdm and moved respective
media component changes from media/BUILD.gn file to new BUILD.gn
file.

BUG= 613033 , 739673 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I944b712791833edf6417db308225295c6cb3bdbf
Reviewed-on: https://chromium-review.googlesource.com/561265
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485843}
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/chrome/browser/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/chrome/common/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/chrome/test/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/content/common/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/base/BUILD.gn
[add] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/cdm/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/cdm/ppapi/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/cdm/ppapi/ppapi_cdm_adapter.gni
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/filters/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/gpu/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/mojo/BUILD.gn
[modify] https://crrev.com/33aa4027589f0e506549501cd5bda0fffdf62476/media/mojo/services/BUILD.gn

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da0d3ffe8defa1ebb38248fa6ee5eab50d469e43

commit da0d3ffe8defa1ebb38248fa6ee5eab50d469e43
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Thu Jul 13 03:38:00 2017

Create BUILD.gn files for //media/muxers.

Create new BUILD.gn file for media/muxers and moved respective
media component changes from media/filters/BUILD.gn file to new
BUILD.gn file.

BUG= 613033 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Change-Id: I7fd8a2cc3573efc81f3bb75409bed2860c0a3d46
Reviewed-on: https://chromium-review.googlesource.com/561236
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486258}
[modify] https://crrev.com/da0d3ffe8defa1ebb38248fa6ee5eab50d469e43/media/filters/BUILD.gn
[add] https://crrev.com/da0d3ffe8defa1ebb38248fa6ee5eab50d469e43/media/muxers/BUILD.gn

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cda8c46bcac1f766d96f3610c9bf04d939d7eb0

commit 0cda8c46bcac1f766d96f3610c9bf04d939d7eb0
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Mon Jul 17 12:39:58 2017

Create BUILD.gn files for //media/video.

Create new BUILD.gn file for media/video and moved respective
media component changes from media/filters/BUILD.gn file to new
BUILD.gn file.

BUG= 613033 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Change-Id: Iaa2ff8c16d697ede5e8e249fbc01c058eaef6d78
Reviewed-on: https://chromium-review.googlesource.com/569528
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487055}
[modify] https://crrev.com/0cda8c46bcac1f766d96f3610c9bf04d939d7eb0/media/filters/BUILD.gn
[add] https://crrev.com/0cda8c46bcac1f766d96f3610c9bf04d939d7eb0/media/video/BUILD.gn

Project Member

Comment 20 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dd5fcf6628e2232a0e100b130ab2ea688443c4c

commit 0dd5fcf6628e2232a0e100b130ab2ea688443c4c
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Thu Jul 20 00:12:42 2017

Create BUILD.gn files for //media/renderers.

Create new BUILD.gn file for media/renderers and moved respective
media component changes from media/BUILD.gn file to new BUILD.gn file.

Bug= 613033 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Change-Id: Ibb763bfe7db56b197fb0e0be3b280900caa79b82
Reviewed-on: https://chromium-review.googlesource.com/577336
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488057}
[modify] https://crrev.com/0dd5fcf6628e2232a0e100b130ab2ea688443c4c/media/BUILD.gn
[add] https://crrev.com/0dd5fcf6628e2232a0e100b130ab2ea688443c4c/media/renderers/BUILD.gn

Project Member

Comment 21 by bugdroid1@chromium.org, Jul 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e11490bf3263f3ac1fa9107107a76871dc6b83a9

commit e11490bf3263f3ac1fa9107107a76871dc6b83a9
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Mon Jul 24 04:39:18 2017

Create BUILD.gn files for //media/device_monitors.

Create new BUILD.gn file for media/device_monitors and moved respective
media component changes from media/BUILD.gn file to new BUILD.gn file.

Bug= 613033 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Change-Id: I1162346fb859b0280f8958405bb472fe7112c783
Reviewed-on: https://chromium-review.googlesource.com/580730
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488911}
[modify] https://crrev.com/e11490bf3263f3ac1fa9107107a76871dc6b83a9/media/BUILD.gn
[add] https://crrev.com/e11490bf3263f3ac1fa9107107a76871dc6b83a9/media/device_monitors/BUILD.gn

Can I own this issue in my name ?
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db3e4c7d47b4ea082d3c741955b68f66bd8e5bff

commit db3e4c7d47b4ea082d3c741955b68f66bd8e5bff
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Thu Aug 10 13:33:10 2017

Create unit_tests target in //media/cdm.

Create new target 'unit_tests' in //media/cdm and moved respective
cdm changes from //media:unit_tests to //media/cdm:unit_tests.

Bug= 613033 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Change-Id: Ie8133aa0d621a213367341bebe6095fd80a73adb
Reviewed-on: https://chromium-review.googlesource.com/584648
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493369}
[modify] https://crrev.com/db3e4c7d47b4ea082d3c741955b68f66bd8e5bff/media/BUILD.gn
[modify] https://crrev.com/db3e4c7d47b4ea082d3c741955b68f66bd8e5bff/media/cdm/BUILD.gn

Project Member

Comment 24 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77be7aef526705f9e752c9cf1abf6a8d99e26803

commit 77be7aef526705f9e752c9cf1abf6a8d99e26803
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Aug 18 15:56:48 2017

Organize internal media dependencies into sub-components.

- Introduce concept of subcomponents which roll up
into //media DEPs.
- Cleanup unnecessary visibility and comment blocks while
adding explicit visibility for sub-components.
- Relocate webvtt_util.h from filters/ to base/
- Move demuxer_perftest from base/ to filters/
- Switch base to be source_set with internal only DEPS.
- Drop unnecessary media/audio deps from base.
- Drop media/ffmpeg dep from base/
- Relocate video/* files into video/BUILD.gn
- Drop media/filters dep from media/video (was circular).

With this we've got a clear organization of the //media
folder and are fairly close to being able to enable
gn check over the entire //media component.

Apologies for the massive CL, but this is a ball of yarn
that just kept growing and growing while trying to pull
apart unfortunately.

I've paid close attention to some previous work from
brucedawson@ to ensure we haven't regressed any sizes
on windows builds by switching //media/base back to
a source_set from a static_library. Actually this seems
to shave ~11.5kb off chrome.dll and chrome_child.dll in
official build configuration:

new_chrome = 49061376
new_child = 68613120
static_chrome = 49065984
static_child = 68618240
old_chrome = 49067520
old_child = 68618752

(static_* == this patch but with static_library base)

BUG= 613033 
TEST=no size regressions, passes CQ

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id3f173d467147506403be1a352097a7372d71ef1
Reviewed-on: https://chromium-review.googlesource.com/612208
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495557}
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/chrome/test/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/chrome/test/media_router/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/chromecast/browser/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/chromecast/media/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/chromecast/media/cma/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/chromecast/media/cma/test/DEPS
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/chromecast/media/cma/test/frame_segmenter_for_test.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/content/browser/media/capture/web_contents_audio_muter.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/content/renderer/media/gpu/rtc_video_decoder_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/content/renderer/media/gpu/rtc_video_encoder.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/content/renderer/media/gpu/rtc_video_encoder_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/content/renderer/media/media_stream_video_renderer_sink_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/content/test/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/extensions/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/audio/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/audio/audio_io.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/audio/fake_audio_input_stream.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/audio/fake_audio_output_stream.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/audio/null_audio_sink.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/audio/virtual_audio_input_stream.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/android/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/audio_block_fifo_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/audio_bus.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/audio_latency.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/audio_parameters.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/audio_point.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/channel_layout.h
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/fake_audio_worker.cc
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/fake_audio_worker.h
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/fake_audio_worker_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/fake_text_track_stream.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/mac/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/mac/audio_latency_mac.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/media.cc
[add] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/media_shmem_export.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/mime_util_internal.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/silent_sink_suspender.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/text_renderer_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/vector_math.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/vector_math_testing.h
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/webvtt_util.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/base/win/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/blink/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/capture/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/capture/content/android/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/capture/video/android/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/cast/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/cast/sender/external_video_encoder.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/cdm/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/cdm/cdm_helpers.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/cdm/supported_cdm_versions.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/device_monitors/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/ffmpeg/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/filters/BUILD.gn
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/filters/demuxer_perftest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/filters/h264_bitstream_buffer.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/filters/h264_to_annex_b_bitstream_converter.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/filters/h265_parser.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/filters/source_buffer_stream_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/formats/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/formats/mp2t/es_parser_h264.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/formats/mp2t/es_parser_h264_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/formats/mp4/avc.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/formats/mp4/avc_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/formats/mp4/box_definitions.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/formats/webm/webm_cluster_parser.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/gpu/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/gpu/dxva_video_decode_accelerator_win.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/gpu/h264_decoder.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/gpu/h264_dpb.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/gpu/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/gpu/v4l2_video_encode_accelerator.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/gpu/video_decode_accelerator_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/gpu/video_encode_accelerator_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/gpu/vt_video_decode_accelerator_mac.h
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/media_options.gni
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/mojo/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/mojo/services/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/muxers/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/remoting/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/renderers/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/renderers/video_renderer_impl_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/test/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/BUILD.gn
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/h264_bit_reader.cc
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/h264_bit_reader.h
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/h264_bit_reader_unittest.cc
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/h264_parser.cc
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/h264_parser.h
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/h264_parser_fuzzertest.cc
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/h264_parser_unittest.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/h264_poc.cc
[modify] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/h264_poc_unittest.cc
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/mock_gpu_memory_buffer_video_frame_pool.cc
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/mock_gpu_memory_buffer_video_frame_pool.h
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/mock_gpu_video_accelerator_factories.cc
[rename] https://crrev.com/77be7aef526705f9e752c9cf1abf6a8d99e26803/media/video/mock_gpu_video_accelerator_factories.h

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f933792eb7e04671da98b8d88fdf813efe4f3f1

commit 4f933792eb7e04671da98b8d88fdf813efe4f3f1
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Aug 18 16:26:05 2017

Fix media_perftests BUILD.gn

BUG= 613033 
TBR=jrummell
NOTRY=true
TEST=media_perftest

Change-Id: I8329efbdbc78b591edbb276ffcb94225434024a9
Reviewed-on: https://chromium-review.googlesource.com/621366
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495567}
[modify] https://crrev.com/4f933792eb7e04671da98b8d88fdf813efe4f3f1/media/base/BUILD.gn

Project Member

Comment 26 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/863022e074f7df1e9e39ad4e86b76ceced856bc2

commit 863022e074f7df1e9e39ad4e86b76ceced856bc2
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Sat Aug 19 02:05:34 2017

Move sample_rates.* and gpu_video_accelerator_factories.* for gn check.

Relocates media/audio/sample_rates.{cc,h} and
media/renderers/gpu_video_accelerator_factories.{h,cc} in preparation
for getting gn check working.

BUG= 613033 
TEST=cq
TBR=nick

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I044001d9c9e358f5a631aa8c65a4e677d7fcd1c2
Reviewed-on: https://chromium-review.googlesource.com/622095
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495786}
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/public/renderer/video_encode_accelerator.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.h
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/gpu/rtc_video_decoder.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/gpu/rtc_video_decoder_factory.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/gpu/rtc_video_encoder.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/gpu/rtc_video_encoder_factory.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/media_stream_video_renderer_sink.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/media_stream_video_renderer_sink_unittest.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/webrtc/processed_local_audio_source.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/webrtc_audio_device_impl.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/media/webrtc_audio_renderer.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/pepper/pepper_video_encoder_host.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/content/renderer/render_view_impl.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/audio/BUILD.gn
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/audio/audio_output_device_unittest.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/audio/audio_output_resampler.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/base/BUILD.gn
[rename] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/base/sample_rates.cc
[rename] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/base/sample_rates.h
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/filters/BUILD.gn
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/mojo/clients/mojo_video_decoder.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/mojo/services/test_mojo_media_client.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/remoting/metrics.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/renderers/BUILD.gn
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/renderers/default_renderer_factory.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/renderers/video_overlay_factory.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/renderers/video_renderer_impl.cc
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/renderers/video_renderer_impl.h
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/video/BUILD.gn
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/video/fake_video_encode_accelerator.h
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/video/gpu_memory_buffer_video_frame_pool.cc
[rename] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/video/gpu_video_accelerator_factories.h
[modify] https://crrev.com/863022e074f7df1e9e39ad4e86b76ceced856bc2/media/video/mock_gpu_video_accelerator_factories.h

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1

commit b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Sat Aug 19 17:06:52 2017

Various //media fixes to prepare for gn check turn on.

- Remove //media/base:base_config to prevent accidental usage.
- Unify size_t and int truncation comments on a still open bug.
- Move //media/base/callback_holder.h into //media/base from unit_tests.
- Fixup //media/formats and //media/filters DEPS.
- Fixup //media/filters dependency for gpu::SyncToken

BUG= 613033 
TEST=cq

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibc49bee9001e86e82cf39abae62f4dba93e69900
Reviewed-on: https://chromium-review.googlesource.com/622097
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495819}
[modify] https://crrev.com/b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1/media/audio/BUILD.gn
[modify] https://crrev.com/b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1/media/base/BUILD.gn
[modify] https://crrev.com/b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1/media/base/android/BUILD.gn
[modify] https://crrev.com/b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1/media/cdm/BUILD.gn
[modify] https://crrev.com/b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1/media/device_monitors/BUILD.gn
[modify] https://crrev.com/b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1/media/filters/BUILD.gn
[modify] https://crrev.com/b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1/media/formats/BUILD.gn
[modify] https://crrev.com/b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1/media/renderers/BUILD.gn
[modify] https://crrev.com/b9b2d4f475c4274b155f5d4f683d00dc6aaff3e1/media/video/BUILD.gn

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c654b0a2172b21f5123526379bb20b7df751d973

commit c654b0a2172b21f5123526379bb20b7df751d973
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Mon Aug 21 23:14:11 2017

Fixup a couple more media gn check issues.

- Move //media/filters/h265_parser* to //media/video
- Add missing //ui/gl DEP to //media/video

BUG= 613033 
TEST=gn check passes

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I48d79ab8cd826e24ce49db28d21f3c4038e066f6
Reviewed-on: https://chromium-review.googlesource.com/624660
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496112}
[modify] https://crrev.com/c654b0a2172b21f5123526379bb20b7df751d973/media/BUILD.gn
[modify] https://crrev.com/c654b0a2172b21f5123526379bb20b7df751d973/media/filters/BUILD.gn
[modify] https://crrev.com/c654b0a2172b21f5123526379bb20b7df751d973/media/formats/mp4/hevc.cc
[modify] https://crrev.com/c654b0a2172b21f5123526379bb20b7df751d973/media/video/BUILD.gn
[rename] https://crrev.com/c654b0a2172b21f5123526379bb20b7df751d973/media/video/h265_parser.cc
[rename] https://crrev.com/c654b0a2172b21f5123526379bb20b7df751d973/media/video/h265_parser.h
[rename] https://crrev.com/c654b0a2172b21f5123526379bb20b7df751d973/media/video/h265_parser_unittest.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58fc6b805e1ded1c65e22406b49020f20725f69f

commit 58fc6b805e1ded1c65e22406b49020f20725f69f
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Aug 22 02:36:17 2017

Fixup media/capture in preparation for gn check

Adds some missing DEPS and breaks out a target which capture/*/android
can depend on without creating a circular dependency.

BUG= 613033 
TEST=none

Change-Id: I00ce3456ca7460c9791ca4a16432279c415e4329
Reviewed-on: https://chromium-review.googlesource.com/622099
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496183}
[modify] https://crrev.com/58fc6b805e1ded1c65e22406b49020f20725f69f/media/capture/BUILD.gn
[modify] https://crrev.com/58fc6b805e1ded1c65e22406b49020f20725f69f/media/capture/content/android/BUILD.gn
[modify] https://crrev.com/58fc6b805e1ded1c65e22406b49020f20725f69f/media/capture/ipc/BUILD.gn
[modify] https://crrev.com/58fc6b805e1ded1c65e22406b49020f20725f69f/media/capture/video/android/BUILD.gn

Project Member

Comment 30 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efa5c50077ad36c9d548609120ca33d3eb5f5a65

commit efa5c50077ad36c9d548609120ca33d3eb5f5a65
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Aug 22 03:26:49 2017

Ignore size_t conversion errors on new media/capture target.

BUG= 613033 
TBR=miu
NOTRY=true

Change-Id: Ie3e0242327ffb476f9c980078b40322018fb3bce
Reviewed-on: https://chromium-review.googlesource.com/625456
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496198}
[modify] https://crrev.com/efa5c50077ad36c9d548609120ca33d3eb5f5a65/media/capture/BUILD.gn

Project Member

Comment 31 by bugdroid1@chromium.org, Aug 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4b6de131ff7e248b4404d7cca45c14a7ccf1441

commit f4b6de131ff7e248b4404d7cca45c14a7ccf1441
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Aug 22 04:04:05 2017

Enable gn check for all of //media

Hopefully passing now...

BUG= 613033 
TEST=cq

Change-Id: I740bf35977da9f0cea9ddc29779f294ef3a75aeb
Reviewed-on: https://chromium-review.googlesource.com/622151
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496205}
[modify] https://crrev.com/f4b6de131ff7e248b4404d7cca45c14a7ccf1441/.gn

Cc: sande...@chromium.org jrumm...@chromium.org xhw...@chromium.org dcasta...@chromium.org servolk@chromium.org
 Issue 599578  has been merged into this issue.
Cc: -a.suchit@chromium.org
Owner: a.suchit@chromium.org
Cc: -a.suc...@samsung.com
Project Member

Comment 35 by bugdroid1@chromium.org, Aug 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a38be4ebb8f898d4867111b82c1ff1e4ff20ff2

commit 0a38be4ebb8f898d4867111b82c1ff1e4ff20ff2
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Sun Aug 27 08:29:22 2017

Create unit_tests target in //media/device_monitors.

Create new target 'unit_tests' in //media/device_monitors and moved
respective device_monitors changes from //media:unit_tests to
//media/device_monitors:unit_tests.

Bug:  613033 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Change-Id: I2385fa4f32080a2e120bf5558384432cf5de667e
Reviewed-on: https://chromium-review.googlesource.com/610284
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497675}
[modify] https://crrev.com/0a38be4ebb8f898d4867111b82c1ff1e4ff20ff2/media/BUILD.gn
[modify] https://crrev.com/0a38be4ebb8f898d4867111b82c1ff1e4ff20ff2/media/device_monitors/BUILD.gn

Project Member

Comment 36 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/425e329bac769ee3fc32f561ee49e7816f6c5f1a

commit 425e329bac769ee3fc32f561ee49e7816f6c5f1a
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Thu Aug 31 00:28:06 2017

Create unit_tests target in //media/formats.

Create new target 'unit_tests' in //media/formats and moved respective
formats changes from //media:unit_tests to //media/formats:unit_tests.

Bug:  613033 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Change-Id: Idf40e7c1f36c12018607296b049265bac320bd0c
Reviewed-on: https://chromium-review.googlesource.com/637930
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498694}
[modify] https://crrev.com/425e329bac769ee3fc32f561ee49e7816f6c5f1a/media/BUILD.gn
[modify] https://crrev.com/425e329bac769ee3fc32f561ee49e7816f6c5f1a/media/base/BUILD.gn
[modify] https://crrev.com/425e329bac769ee3fc32f561ee49e7816f6c5f1a/media/formats/BUILD.gn

Project Member

Comment 37 by bugdroid1@chromium.org, Aug 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a54feb939e2a03decb5e0533b3950ee84c35fd9

commit 7a54feb939e2a03decb5e0533b3950ee84c35fd9
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Thu Aug 31 01:25:52 2017

Add size_t suppressions for Win in the new //media/formats targets.

BUG= 613033 
TEST=none
NOTREECHECKS=true
NOTRY=true
TBR=wolenetz

Change-Id: Icd5e84b09512dacb1580e4442cb3fed89e211dd9
Reviewed-on: https://chromium-review.googlesource.com/644766
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498704}
[modify] https://crrev.com/7a54feb939e2a03decb5e0533b3950ee84c35fd9/media/formats/BUILD.gn

Project Member

Comment 38 by bugdroid1@chromium.org, Sep 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07e0f18c79a044c3ff374470f04e6b1950d48486

commit 07e0f18c79a044c3ff374470f04e6b1950d48486
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Fri Sep 01 01:03:28 2017

Create unit_tests target in //media/filters.

Create new target 'unit_tests' in //media/filters and moved respective
filters changes from //media:unit_tests to //media/filters:unit_tests.

Bug:  613033 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifa51bf869cfd7378b6562c73f2909e99b2a1636b
Reviewed-on: https://chromium-review.googlesource.com/644966
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499089}
[modify] https://crrev.com/07e0f18c79a044c3ff374470f04e6b1950d48486/media/BUILD.gn
[modify] https://crrev.com/07e0f18c79a044c3ff374470f04e6b1950d48486/media/filters/BUILD.gn

Project Member

Comment 39 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8da0d01d4f111e47b6e107a4618f43f235790398

commit 8da0d01d4f111e47b6e107a4618f43f235790398
Author: Suchit Agrawal <a.suchit@samsung.com>
Date: Thu Sep 07 00:32:44 2017

Create unit_tests target in //media/muxers.

Create new target 'unit_tests' in //media/muxers and moved respective
muxers changes from //media:unit_tests to //media/muxers:unit_tests.

Bug:  613033 

Signed-off-by: Suchit Agrawal <a.suchit@samsung.com>
Change-Id: Ie6f2c8de8bb43b16cf666e87d0476f74fd86e1fe
Reviewed-on: https://chromium-review.googlesource.com/646347
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: SUCHIT AGRAWAL <a.suchit@chromium.org>
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500156}
[modify] https://crrev.com/8da0d01d4f111e47b6e107a4618f43f235790398/media/BUILD.gn
[modify] https://crrev.com/8da0d01d4f111e47b6e107a4618f43f235790398/media/muxers/BUILD.gn

Status: Fixed (was: Started)
Build.gn files are created for all the folders based on //media/BUILD.gn
Thanks for your hard work a.suchit! 

Sign in to add a comment