"New" Task Manager on Mac: Shared Memory is always 0 bytes |
||||
Issue descriptionChrome Version : 52.0.2740.0 OS Version: OS X 10.11.5 What steps will reproduce the problem? 1. chrome://flags/#mac-views-dialogs 2. Right-click a heading, enable 'Shared Memory' What is the expected result? Shared memory > 0 What happens instead of that? Shared memory == 0 B
,
May 19 2016
The mac implementation of base::ProcessMetrics::GetWorkingSetKBytes() calls base::ProcessMetrics::GetCommittedAndWorkingSetKBytes() which sets both shared and shareable memories to 0 [1]! On mac, apparently ProcessMetrics::GetMemoryBytes() should be used instead. Uploading the CL with a fix shortly. +asvitkine if he wants to make any comments. [1] https://code.google.com/p/chromium/codesearch#chromium/src/base/process/process_metrics_mac.cc&q=ProcessMetrics::GetCommittedAndWorkingSetKBytes&sq=package:chromium&type=cs&l=245-246
,
May 19 2016
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07a8e7b48eeff1b271e50ea371d8c7e722ee3891 commit 07a8e7b48eeff1b271e50ea371d8c7e722ee3891 Author: afakhry <afakhry@chromium.org> Date: Fri May 20 19:09:31 2016 Fix the views Task Manager on Mac showing 0s for the Shared Memory R=nick@chromium.org BUG= 613025 Review-Url: https://codereview.chromium.org/1994653006 Cr-Commit-Position: refs/heads/master@{#395129} [modify] https://crrev.com/07a8e7b48eeff1b271e50ea371d8c7e722ee3891/chrome/browser/task_management/sampling/task_group_sampler.cc
,
May 20 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by afakhry@chromium.org
, May 19 2016Status: Assigned (was: Untriaged)